Skip to contentSkip to conversation

staging: iio: dummy: Fix undefined symbol build error

PATCH In review Daniel Baluta 2 participants 2 messages Mar 9, 2015

Subsystems (3)
Staging IIO Staging - industrial io
lore
Share & tools
lore

Daniel Baluta

author
#0 lore raw

PATCH 1/1 staging: iio: dummy: Fix undefined symbol build error

CONFIG_SIMPLE_DUMMY_BUFFER compiles in iio_simple_dummy_buffer.c file which uses functions from industrialio-trigger.c.

So, CONFIG_SIMPLE_DUMMY_BUFFER needs to select IIO_TRIGGER in order to avoid build error like this:

Quoted 5 lines

ERROR: "iio_trigger_notify_done" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_triggered_buffer_postenable" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_triggered_buffer_predisable" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_alloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_dealloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!

Cc Arnd Bergmann <[email protected]>
Reported-by kbuild test robot <[email protected]>
Signed-off-by Daniel Baluta <[email protected]>
---
 drivers/staging/iio/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/iio/Kconfig +1 -0
index fa38be0..2a15426 100644
@@ -38,6 +38,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
 config IIO_SIMPLE_DUMMY_BUFFER
 	boolean "Buffered capture support"
 	select IIO_BUFFER
+	select IIO_TRIGGER
 	select IIO_KFIFO_BUF
 	help
 	  Add buffered data capture to the simple dummy driver.
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 12 lines · Daniel Baluta

CONFIG_SIMPLE_DUMMY_BUFFER compiles in iio_simple_dummy_buffer.c file which uses functions from industrialio-trigger.c.

So, CONFIG_SIMPLE_DUMMY_BUFFER needs to select IIO_TRIGGER in order to avoid build error like this:

Quoted 5 lines

ERROR: "iio_trigger_notify_done" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_triggered_buffer_postenable" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_triggered_buffer_predisable" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_alloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
ERROR: "iio_dealloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!

Quoted 3 lines
Cc Arnd Bergmann <[email protected]>
Reported-by kbuild test robot <[email protected]>
Signed-off-by Daniel Baluta <[email protected]>

Thanks,

This one had me rather confused as well.

Anyhow, applied to the fixes-togreg branch of iio.git. Will push out later today.

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/staging/iio/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/iio/Kconfig +1 -0
index fa38be0..2a15426 100644
@@ -38,6 +38,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
 config IIO_SIMPLE_DUMMY_BUFFER
 	boolean "Buffered capture support"
 	select IIO_BUFFER
+	select IIO_TRIGGER
 	select IIO_KFIFO_BUF
 	help
 	  Add buffered data capture to the simple dummy driver.