Staging: dgnc: fix bitmask
PATCH 1/1 Staging: dgnc: fix bitmask
From: Matteo Semenzato <[email protected]>
The bitmask should be used on msignals since the signals variable is not used anywhere in the function.
Signed-off-by Matteo Semenzato <[email protected]>
--- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +1 -1
@@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)* Scrub off lower bits. They signify delta's, which I don't * care about */ - signals &=0xf0 ; + msignals &=0xf0 ;spin_lock_irqsave (&ch->ch_lock, flags);if (msignals &UART_MSR_DCD )
Signature · 1 line
2.3.1
Quoted 5 lines · Matteo Semenzato
From: Matteo Semenzato <[email protected]>
The bitmask should be used on msignals since the signals variable is not used anywhere in the function.
You're probably right. I would really like to get Mark's Ack on this though becuase it's sort of a guess and not tested.
regards,
dan carpenter
Quoted 25 lines
Signed-off-by Matteo Semenzato <[email protected]>--- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/dgnc/dgnc_cls.c +1
-1@@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)* Scrub off lower bits. They signify delta's, which I don't * care about */ - signals &=0xf0 ; + msignals &=0xf0 ;spin_lock_irqsave (&ch->ch_lock, flags);if (msignals &UART_MSR_DCD )Signature · 6 lines
2.3.1 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel