Skip to contentSkip to conversation

gdb: fix target gdb building from git

PATCH New Alexey Brodkin 2 participants 5 messages Feb 24, 2015 – Mar 16, 2015

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH 1/1 gdb: fix target gdb building from git

Currently we only add "host-texinfo" dependency for host GDB built from git sources. But in case of target gdb texinfo won't be built and so gdb building will fail on attempt to build documentation.

Fix is trivial - add "host-texinfo" as a dependency for target gdb in the sme way as we disable documentation building via both GDB_CONF_ENV (for target) and HOST_GDB_CONF_ENV (host) GDB flavors.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/gdb/gdb.mk | 1 +
 1 file changed, 1 insertion(+)
package/gdb/gdb.mk +1 -0
index 24084b8..579d9ca 100644
@@ -158,6 +158,7 @@ else
 endif
 
 ifeq ($(GDB_FROM_GIT),y)
+GDB_DEPENDENCIES += host-texinfo
 HOST_GDB_DEPENDENCIES += host-texinfo
 else
 # don't generate documentation
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 gdb: fix target gdb building from git

Dear Alexey Brodkin,

Quoted 4 lines · Alexey Brodkin

Currently we only add "host-texinfo" dependency for host GDB built from git sources. But in case of target gdb texinfo won't be built and so gdb building will fail on attempt to build documentation.

Quoted 8 lines

Fix is trivial - add "host-texinfo" as a dependency for target gdb in the sme way as we disable documentation building via both GDB_CONF_ENV (for target) and HOST_GDB_CONF_ENV (host) GDB flavors.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

Do you have a failing configuration for this one? I've tried to build the ARC target gdb today, without selecting cross-gdb (so that the host-texinfo dependency is not pulled in), and I couldn't get a failure.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 gdb: fix target gdb building from git

Hi Thomas,

Quoted 11 lines · Thomas Petazzoni

Dear Alexey Brodkin,

Quoted 8 lines · Alexey Brodkin

Currently we only add "host-texinfo" dependency for host GDB built from git sources. But in case of target gdb texinfo won't be built and so gdb building will fail on attempt to build documentation.

Fix is trivial - add "host-texinfo" as a dependency for target gdb in the sme way as we disable documentation building via both GDB_CONF_ENV (for target) and HOST_GDB_CONF_ENV (host) GDB flavors.

Quoted 8 lines
Quoted 4 lines
Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

Do you have a failing configuration for this one? I've tried to build the ARC target gdb today, without selecting cross-gdb (so that the host-texinfo dependency is not pulled in), and I couldn't get a failure.

Actually I discovered this issue when I tried to build target gdb with external tools.

So to reproduce this issue please apply
http://patchwork.ozlabs.org/patch/448242/ to your local git tree, then select external tools for ARC and try to build target gdb.

And this is my defconfig to reproduce the issue:
--->8---
BR2_arcle=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_GDB=y
BR2_PACKAGE_GDB_DEBUGGER=y
--->8---

Indeed if you build toolchain yourself this issue won't happen because "host-texinfo" gets built during toolchain building.

-Alexey

#3 lore raw

PATCH 1/1 gdb: fix target gdb building from git

Dear Alexey Brodkin,

Quoted 15 lines · Alexey Brodkin

Actually I discovered this issue when I tried to build target gdb with external tools.

So to reproduce this issue please apply
http://patchwork.ozlabs.org/patch/448242/ to your local git tree, then select external tools for ARC and try to build target gdb.

And this is my defconfig to reproduce the issue:
--->8---
BR2_arcle=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_GDB=y
BR2_PACKAGE_GDB_DEBUGGER=y
--->8---

Quoted 2 lines

Indeed if you build toolchain yourself this issue won't happen because "host-texinfo" gets built during toolchain building.

Ah, ok, indeed makes sense. Then I'll wait for your external toolchain patch to be ready (I've just sent a bunch of comments), and I'll apply this one as well.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 gdb: fix target gdb building from git

In reply to Alexey Brodkin

Dear Alexey Brodkin,

Quoted 4 lines · Alexey Brodkin

Currently we only add "host-texinfo" dependency for host GDB built from git sources. But in case of target gdb texinfo won't be built and so gdb building will fail on attempt to build documentation.

Quoted 8 lines

Fix is trivial - add "host-texinfo" as a dependency for target gdb in the sme way as we disable documentation building via both GDB_CONF_ENV (for target) and HOST_GDB_CONF_ENV (host) GDB flavors.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

I was indeed able to reproduce the problem, so patch applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com