sym53c416: Fix nasty memory corruption
PATCH 1/1 sym53c416: Fix nasty memory corruption
In sym53c416_read(), the chip can (and does sometimes) return more bytes in the FIFO than we want to read. This causes buffer overflow, resulting in nasty memory and data corruption and oopses. I couldn't even read filesystem's root directory properly (and a simple dd with 1M blocksize crashed the system) without this patch.
Add a check to make sure we never read more bytes than required. sym53c416_write() already contains similar check.
Signed-off-by Ondrej Zary <[email protected]>
--- drivers/scsi/sym53c416.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/scsi/sym53c416.c +2 -0
@@ -253,6 +253,8 @@ static __inline__ unsigned int sym53c416_read(int base, unsigned char *buffer, uwhile (len && timeout) { bytes_left =inb (base +PIO_FIFO_CNT );/* Number of bytes in the PIO FIFO */ +if (bytes_left > len) + bytes_left = len;if (fastpio && bytes_left >3 ) {insl (base +PIO_FIFO_1 , buffer, bytes_left >>2 );
Signature · 1 line
Ondrej Zary