scsi: storvsc: Increase the tablesize based on host's capabilities
Subsystems (2)
cover scsi: storvsc: Increase the tablesize based on host's capabilities
Presently, storvsc limits the I/O size arbitrarily. Make this configurable based on what the host advertises.
K. Y. Srinivasan (3):
scsi: storvsc: Retrieve information about the capability of the
target
scsi: storvsc: Set the tablesize based on the information given by
the host
scsi: storvsc: Enable clustering
drivers/scsi/storvsc_drv.c | 78 +++++++++++++++++++++++++++++++++++--------- 1 files changed, 62 insertions(+), 16 deletions(-)
Signature · 1 line
1.7.4.1
PATCH 1/3 scsi: storvsc: Retrieve information about the capability of the target
The storage protocol informs the guest of the I/O capabilities of the storage stack. Retrieve this information and use it in the guest.
--- drivers/scsi/storvsc_drv.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/scsi/storvsc_drv.c +6 -0
@@ -377,6 +377,10 @@ struct storvsc_device {unsigned char path_id;unsigned char target_id; +/* +* Max I/O, the device can support. +*/ +u32 max_transfer_bytes;/* Used for vsc/vsp channel reset process */ struct storvsc_cmd_request init_request;struct storvsc_cmd_request reset_request;
@@ -974,6 +978,8 @@ static int storvsc_channel_init(struct hv_device *device) STORAGE_CHANNEL_SUPPORTS_MULTI_CHANNEL) process_sub_channels = true; } + stor_device->max_transfer_bytes = + vstor_packet->storage_channel_properties.max_transfer_bytes;memset (vstor_packet,0 ,sizeof (struct vstor_packet )); vstor_packet->operation =VSTOR_OPERATION_END_INITIALIZATION ;
Signature · 1 line
1.7.4.1
PATCH 2/3 scsi: storvsc: Set the tablesize based on the information given by the host
Set the tablesize based on what the host has informed us.
--- drivers/scsi/storvsc_drv.c | 70 ++++++++++++++++++++++++++++++++++--------- 1 files changed, 55 insertions(+), 15 deletions(-)
drivers/scsi/storvsc_drv.c +55 -15
@@ -351,7 +351,10 @@ struct storvsc_cmd_request {/* Synchronize the request/response if needed */ struct completion wait_event; -struct hv_multipage_buffer data_buffer; +struct vmbus_channel_packet_multipage_buffer mpb; +struct vmbus_packet_mpb_array *payload; +u32 payload_sz; +struct vstor_packet vstor_packet; };
@@ -1119,10 +1122,14 @@ static void storvsc_command_completion(struct storvsc_cmd_request *cmd_request) sense_hdr.ascq);scsi_set_resid (scmnd, - cmd_request->data_buffer.len - + cmd_request->payload->range.len - vm_srb->data_transfer_length); scmnd->scsi_done (scmnd); + +if (cmd_request->payload_sz > +sizeof (struct vmbus_channel_packet_multipage_buffer )) +kfree (cmd_request->payload); } static void storvsc_on_io_completion(struct hv_device *device,
@@ -1324,7 +1331,7 @@ static int storvsc_dev_remove(struct hv_device *device) }static int storvsc_do_io (struct hv_device *device, -struct storvsc_cmd_request *request) +struct storvsc_cmd_request *request) {struct storvsc_device *stor_device;struct vstor_packet *vstor_packet;
@@ -1356,13 +1363,14 @@ static int storvsc_do_io(struct hv_device *device, vstor_packet->vm_srb.data_transfer_length = - request->data_buffer.len; + request->payload->range.len; vstor_packet->operation =VSTOR_OPERATION_EXECUTE_SRB ; -if (request->data_buffer.len) { - ret = vmbus_sendpacket_multipagebuffer(outgoing_channel, - &request->data_buffer, +if (request->payload->range.len) { + + ret = vmbus_sendpacket_mpb_desc(outgoing_channel, + request->payload, request->payload_sz, vstor_packet, (sizeof(struct vstor_packet) - vmscsi_size_delta),
@@ -1535,6 +1543,10 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)struct scatterlist *sgl;unsigned int sg_count =0 ;struct vmscsi_request *vm_srb; +struct vmbus_packet_mpb_array *payload; +u32 payload_sz; +u32 pfn_cnt; +u32 length;if (vmstor_current_major <=VMSTOR_WIN8_MAJOR ) {/*
@@ -1588,7 +1600,11 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)memcpy (vm_srb->cdb, scmnd->cmnd, vm_srb->cdb_length); - cmd_request->data_buffer.len =scsi_bufflen (scmnd); + sgl = (struct scatterlist *)scsi_sglist (scmnd); + length =scsi_bufflen (scmnd); + payload = (struct vmbus_packet_mpb_array *)&cmd_request->mpb; + payload_sz =sizeof (cmd_request->mpb); +if (scsi_sg_count (scmnd)) { sgl = (struct scatterlist *)scsi_sglist (scmnd); sg_count =scsi_sg_count (scmnd);
@@ -1615,19 +1631,40 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) sg_count = cmd_request->bounce_sgl_count; } - cmd_request->data_buffer.offset = sgl[0 ].offset; + pfn_cnt =DIV_ROUND_UP (sgl[0 ].offset + length,PAGE_SIZE ); + +if (pfn_cnt >MAX_PAGE_BUFFER_COUNT ) { + + payload_sz = (pfn_cnt *sizeof (void *) + +sizeof (struct vmbus_packet_mpb_array )); + payload =kzalloc (payload_sz,GFP_ATOMIC ); +if (!payload) { +if (cmd_request->bounce_sgl_count) +destroy_bounce_buffer ( + cmd_request->bounce_sgl, + cmd_request->bounce_sgl_count); + +return SCSI_MLQUEUE_DEVICE_BUSY ; + } + } + + payload->range.len = length; + payload->range.offset = sgl[0 ].offset;for (i =0 ; i < sg_count; i++) - cmd_request->data_buffer.pfn_array[i] = + payload->range.pfn_array[i] =page_to_pfn (sg_page ((&sgl[i]))); }else if (scsi_sglist (scmnd)) { - cmd_request->data_buffer.offset = + payload->range.len = length; + payload->range.offset =virt_to_phys (scsi_sglist (scmnd)) & (PAGE_SIZE -1 ); - cmd_request->data_buffer.pfn_array[0 ] = + payload->range.pfn_array[0 ] =virt_to_phys (scsi_sglist (scmnd)) >>PAGE_SHIFT ; } + cmd_request->payload = payload; + cmd_request->payload_sz = payload_sz;/* Invokes the vsc to start an IO */ ret =storvsc_do_io (dev, cmd_request);
@@ -1656,9 +1693,6 @@ static struct scsi_host_template scsi_driver = { .slave_configure = storvsc_device_configure, .cmd_per_lun = 255, .this_id = -1, -/* no use setting to 0 since ll_blk_rw reset it to 1 */ -/* currently 32 */ - .sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT, .use_clustering = DISABLE_CLUSTERING,/* Make sure we dont get a sg segment crosses a page boundary */ .dma_boundary = PAGE_SIZE-1,
@@ -1796,6 +1830,12 @@ static int storvsc_probe(struct hv_device *device,/* max cmd length */ host->max_cmd_len =STORVSC_MAX_CMD_LEN ; +/* +* set the table size based on the info we got +* from the host. +*/ + host->sg_tablesize = (stor_device->max_transfer_bytes >>PAGE_SHIFT ); +/* Register the HBA and start the scsi bus scan */ ret =scsi_add_host (host, &device->device);if (ret !=0 )
Signature · 1 line
1.7.4.1
PATCH 3/3 scsi: storvsc: Enable clustering
In reply to K. Y. Srinivasan--- drivers/scsi/storvsc_drv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/storvsc_drv.c +1 -1
@@ -1693,7 +1693,7 @@ static struct scsi_host_template scsi_driver = { .slave_configure = storvsc_device_configure, .cmd_per_lun = 255, .this_id = -1, - .use_clustering = DISABLE_CLUSTERING, + .use_clustering = ENABLE_CLUSTERING,/* Make sure we dont get a sg segment crosses a page boundary */ .dma_boundary = PAGE_SIZE-1, .no_write_same = 1,
Signature · 1 line
1.7.4.1
Quoted 23 lines
-----Original Message-----
From: K. Y. Srinivasan [mailto:[email protected]]
Sent: Monday, March 9, 2015 8:42 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: KY Srinivasan
Subject: [PATCH 0/3] scsi: storvsc: Increase the tablesize based on host's capabilitiesPresently, storvsc limits the I/O size arbitrarily. Make this configurable based on what the host advertises.
K. Y. Srinivasan (3):
scsi: storvsc: Retrieve information about the capability of the
target
scsi: storvsc: Set the tablesize based on the information given by
the host
scsi: storvsc: Enable clustering
Quoted 3 lines
drivers/scsi/storvsc_drv.c | 78 +++++++++++++++++++++++++++++++++++--------- 1 files changed, 62 insertions(+), 16 deletions(-)
Christoph,
Let me know if I should resend these patches.
Regards,
K. Y
Quoted 3 lines
--
1.7.4.1
Quoted 40 lines
-----Original Message-----
From: KY Srinivasan
Sent: Monday, March 16, 2015 4:45 PM
To: 'K. Y. Srinivasan'; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH 0/3] scsi: storvsc: Increase the tablesize based on host's capabilitiesQuoted 11 lines
-----Original Message-----
From: K. Y. Srinivasan [mailto:[email protected]]
Sent: Monday, March 9, 2015 8:42 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: KY Srinivasan
Subject: [PATCH 0/3] scsi: storvsc: Increase the tablesize based on host's capabilitiesQuoted 1 line
Presently, storvsc limits the I/O size arbitrarily. Make this configurable
based
Quoted 9 lines
on what the host advertises.
K. Y. Srinivasan (3):
scsi: storvsc: Retrieve information about the capability of the
target
scsi: storvsc: Set the tablesize based on the information given by
the host
scsi: storvsc: Enable clusteringQuoted 3 lines
drivers/scsi/storvsc_drv.c | 78 +++++++++++++++++++++++++++++++++++--------- 1 files changed, 62 insertions(+), 16 deletions(-)
Quoted 5 lines
Christoph,
Let me know if I should resend these patches.
Regards,
Christoph,
Please drop this set. I will resend the patches with a couple of additional patches that need to go in before I can enable clustering.
Regards,
K. Y