iw: Allow configuring empty legacy and ht ratesets.
PATCH 1/1 iw: Allow configuring empty legacy and ht ratesets.
From: Ben Greear <[email protected]>
This allows one to configure exactly one rate for drivers such as ath10k that will only allow a single rate to be configured.
--- bitrate.c | 4 ++++ 1 file changed, 4 insertions(+)
bitrate.c +4 -0
@@ -176,6 +176,8 @@ static int handle_bitrates(struct nl80211_state *state, tmpd =strtod (argv[i], &end);if (*end !='\0' )return 1 ; +if (tmpd ==-1 )/* terminator, could be empty list */ +break ;if (tmpd <1 || tmpd >255 *2 )return 1 ; legacy[(*n_legacy)++] = tmpd *2 ;
@@ -184,6 +186,8 @@ static int handle_bitrates(struct nl80211_state *state, tmpl =strtol (argv[i], &end,0 );if (*end !='\0' )return 1 ; +if (tmpl ==-1 )/* terminator, could be empty list */ +break ;if (tmpl <0 || tmpl >255 )return 1 ; mcs[(*n_mcs)++] = tmpl;
Signature · 1 line
1.9.3
Quoted 6 lines · On 11 March 2015 at 00:00, <[email protected]> wrote:
From: Ben Greear <[email protected]>
This allows one to configure exactly one rate for drivers such as ath10k that will only allow a single rate to be configured.
Hello,
But iw already support setting single rate with ath10k. This is example from ath10k commit log:
Example:
iw wlanX set bitrates legacy-5 ht-mcs-5 vht-mcs-5 2:9 will setup VHT, nss=2, mcs=9
iw wlanX set bitrates legacy-5 18 ht-mcs-5 vht-mcs-5 will setup legacy, 18Mbps
iw wlanX set bitrates legacy-5 ht-mcs-5 3 vht-mcs-5 will setup HT, nss=1, mcs=3
iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 will setup nss=1
iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 2:0-9 will setup nss=2
BR
Janusz
Quoted 8 lines · Janusz Dziedzic
Quoted 6 lines · On 11 March 2015 at 00:00, <[email protected]> wrote:
From: Ben Greear <[email protected]>
This allows one to configure exactly one rate for drivers such as ath10k that will only allow a single rate to be configured.
Quoted 4 lines
Hello,
But iw already support setting single rate with ath10k. This is example from ath10k commit log:
Ahh, I see. I was confused about what syntax to use for 'iw', must have typo'd something early on and then though the limitation was in the parser.
Thanks,
Ben
Quoted 20 lines
Example:
iw wlanX set bitrates legacy-5 ht-mcs-5 vht-mcs-5 2:9 will setup VHT, nss=2, mcs=9iw wlanX set bitrates legacy-5 18 ht-mcs-5 vht-mcs-5 will setup legacy, 18Mbps
iw wlanX set bitrates legacy-5 ht-mcs-5 3 vht-mcs-5 will setup HT, nss=1, mcs=3
iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 will setup nss=1
iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 2:0-9 will setup nss=2
BR
Janusz
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com