x86: crownbay: Enable saving environment in SPI flash
PATCH 1/2 x86: crownbay: Enable saving environment in SPI flash
Saving U-Boot's environment in SPI flash on Intel CrownBay board.
---
include/configs/crownbay.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/configs/crownbay.h +8 -0
@@ -56,4 +56,12 @@#undef CONFIG_VIDEO#undef CONFIG_CFB_CONSOLE +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */
Signature · 1 line
1.8.2.1
PATCH 2/2 x86: galileo: Enable saving environment in SPI flash
Saving U-Boot's environment in SPI flash on Intel Galileo board.
---
include/configs/galileo.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/configs/galileo.h +8 -0
@@ -62,4 +62,12 @@#define CONFIG_DW_ALTDESCRIPTOR #define CONFIG_PHYLIB +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */
Signature · 1 line
1.8.2.1
PATCH 2/2 x86: galileo: Enable saving environment in SPI flash
Quoted 26 lines · Bin Meng
Saving U-Boot's environment in SPI flash on Intel Galileo board.
Signed-off-by Bin Meng <[email protected]>---
include/configs/galileo.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/galileo.h +8
-1@@ -62,4 +62,12 @@#define CONFIG_DW_ALTDESCRIPTOR #define CONFIG_PHYLIB +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */ --
Quoted 2 lines
1.8.2.1
I wonder at what point we should move some of this to x86-common.h?
PATCH 2/2 x86: galileo: Enable saving environment in SPI flash
Hi Simon,
Quoted 32 lines · Simon Glass
Quoted 26 lines · Bin Meng
Saving U-Boot's environment in SPI flash on Intel Galileo board.
Signed-off-by Bin Meng <[email protected]>---
include/configs/galileo.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/galileo.h +8
-1@@ -62,4 +62,12 @@#define CONFIG_DW_ALTDESCRIPTOR #define CONFIG_PHYLIB +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */ --Quoted 2 lines
1.8.2.1
Acked-by Simon Glass <[email protected]>
Quoted 1 line
I wonder at what point we should move some of this to
x86-common.h?
I believe we can only put
#define CONFIG_ENV_IS_IN_SPI_FLASH
in x86-common.h and leave others still in the board file due to they are spi flash/board-specific.
Regards,
Bin
PATCH 2/2 x86: galileo: Enable saving environment in SPI flash
Quoted 35 lines · Bin Meng
Hi Simon,
Quoted 32 lines · Simon Glass
Quoted 26 lines · Bin Meng
Saving U-Boot's environment in SPI flash on Intel Galileo board.
Signed-off-by Bin Meng <[email protected]>---
include/configs/galileo.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/galileo.h +8
-1@@ -62,4 +62,12 @@#define CONFIG_DW_ALTDESCRIPTOR #define CONFIG_PHYLIB +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */ --Quoted 2 lines
1.8.2.1
Acked-by Simon Glass <[email protected]>
Quoted 8 lines
Quoted 1 line
I wonder at what point we should move some of this to
x86-common.h?I believe we can only put
#define
CONFIG_ENV_IS_IN_SPI_FLASHin
x86-common.hand leave others still in the board file due to they are spi flash/board-specific.
Yes that sounds right.
Applied to u-boot-x86, thanks!
PATCH 1/2 x86: crownbay: Enable saving environment in SPI flash
In reply to Bin MengQuoted 26 lines · Bin Meng
Saving U-Boot's environment in SPI flash on Intel CrownBay board.
Signed-off-by Bin Meng <[email protected]>---
include/configs/crownbay.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/crownbay.h +8
-1@@ -56,4 +56,12 @@#undef CONFIG_VIDEO#undef CONFIG_CFB_CONSOLE +/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */ --
Quoted 2 lines
1.8.2.1
PATCH 1/2 x86: crownbay: Enable saving environment in SPI flash
Quoted 17 lines · Simon Glass
Quoted 16 lines · Bin Meng
Saving U-Boot's environment in SPI flash on Intel CrownBay board.
Signed-off-by Bin Meng <[email protected]>---
include/configs/crownbay.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/crownbay.h +0
-0@@ -56,4 +56,12 @@#undef CONFIG_VIDEO#undef CONFIG_CFB_CONSOLE
Quoted 14 lines
Quoted 10 lines
include/configs/crownbay.h +8
-1+/* Environment configuration */ +#undef CONFIG_ENV_IS_NOWHERE +#undef CONFIG_ENV_SIZE +#define CONFIG_ENV_IS_IN_SPI_FLASH +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_SECT_SIZE 0x1000 +#define CONFIG_ENV_OFFSET 0 +#endif /* __CONFIG_H */ --Quoted 2 lines
1.8.2.1
Acked-by Simon Glass <[email protected]>
Applied to u-boot-x86, thanks!