Skip to contentSkip to conversation

staging: rtl8723au: Fix sparse warning cast to restricted __le16

PATCH NAK Marcus Folkesson 2 participants 2 messages Mar 11, 2015 Staging

lore
Share & tools
lore

Marcus Folkesson

author
#0 lore raw

PATCH 1/1 staging: rtl8723au: Fix sparse warning cast to restricted __le16

This patch fixes the following sparse warnings:

CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning:
cast to restricted __le16

Signed-off-by Marcus Folkesson <[email protected]>
---
 drivers/staging/rtl8723au/include/rtl8723a_hal.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8723au/include/rtl8723a_hal.h +4 -4
index e146336..f642b11 100644
@@ -255,10 +255,10 @@ struct hal_data_8723a {
 	struct hal_version		VersionID;
 	enum rt_customer_id CustomerID;
 
-	u16	FirmwareVersion;
-	u16	FirmwareVersionRev;
-	u16	FirmwareSubVersion;
-	u16	FirmwareSignature;
+	__le16	FirmwareVersion;
+	__le16	FirmwareVersionRev;
+	__le16	FirmwareSubVersion;
+	__le16	FirmwareSignature;
 
 	/* current WIFI_PHY values */
 	u32	ReceiveConfig;
Signature · 1 line
1.9.1
NAK
#1 lore raw
Quoted 19 lines · Marcus Folkesson

This patch fixes the following sparse warnings:

CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning:
cast to restricted __le16

Signed-off-by Marcus Folkesson <[email protected]>
---
 drivers/staging/rtl8723au/include/rtl8723a_hal.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8723au/include/rtl8723a_hal.h +0 -0
index e146336..f642b11 100644
@@ -255,10 +255,10 @@ struct hal_data_8723a {
 	struct hal_version		VersionID;

drivers/staging/rtl8723au/include/rtl8723a_hal.h struct hal_data_8723a { · line 261

Quoted 10 lines
drivers/staging/rtl8723au/include/rtl8723a_hal.h +4 -4
 	enum rt_customer_id CustomerID;
 
-	u16	FirmwareVersion;
-	u16	FirmwareVersionRev;
-	u16	FirmwareSubVersion;
-	u16	FirmwareSignature;
+	__le16	FirmwareVersion;
+	__le16	FirmwareVersionRev;
+	__le16	FirmwareSubVersion;
+	__le16	FirmwareSignature;

Ehm I am pretty sure it doesn't:

rtl8723au_hal_init.c:265

        pHalData->FirmwareVersion = le16_to_cpu(pFwHdr->Version);
	pHalData->FirmwareSubVersion = pFwHdr->Subversion;
	pHalData->FirmwareSignature = le16_to_cpu(pFwHdr->Signature);

If anything, the second assignment there should be changed to use le16_to_cpu(), but your conversion is definitely wrong.

NACK

Jes