Skip to contentSkip to conversation

mx6_common: Do not select esdhc DDR mode for all boards

PATCH New Fabio Estevam 5 participants 8 messages Mar 12, 2015 – Mar 13, 2015

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/2 mx6_common: Do not select esdhc DDR mode for all boards

From: Fabio Estevam <[email protected]>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really have a DDR-capable eMMC, so remove this option from common code to avoid regressions.

Reported-by Stefan Roese <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx6_common.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/mx6_common.h +0 -2
index 29b72b2..e0528ce 100644
@@ -28,8 +28,6 @@
 #define CONFIG_SYS_PL310_BASE	L2_PL310_BASE
 #endif
 
-#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
-
 #define CONFIG_MP
 #define CONFIG_MXC_GPT_HCLK
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE

From: Fabio Estevam <[email protected]>

Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better performance:

reading zImage
5790288 bytes read in 117 ms (47.2 MiB/s)

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/warp.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/warp.h +1 -0
index bcdd112..16cda74 100644
@@ -42,6 +42,7 @@
 #define CONFIG_FSL_USDHC
 #define CONFIG_SYS_FSL_ESDHC_ADDR	0
 #define CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT
+#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
 
 #define CONFIG_MMC
 #define CONFIG_CMD_MMC
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better performance:

reading zImage
5790288 bytes read in 117 ms (47.2 MiB/s)

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

PATCH 2/2 warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better performance:

reading zImage
5790288 bytes read in 117 ms (47.2 MiB/s)

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/2 mx6_common: Do not select esdhc DDR mode for all boards

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really have a DDR-capable eMMC, so remove this option from common code to avoid regressions.

Reported-by Stefan Roese <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw

PATCH 1/2 mx6_common: Do not select esdhc DDR mode for all boards

Quoted 7 lines · Otavio Salvador
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really have a DDR-capable eMMC, so remove this option from common code to avoid regressions.

Quoted 5 lines
Quoted 2 lines
Reported-by Stefan Roese <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Reviewed-by Volodymyr Riazantsev <[email protected]>
Quoted 5 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750

Volodymyr Riazantsev

#6 lore raw

PATCH 1/2 mx6_common: Do not select esdhc DDR mode for all boards

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really have a DDR-capable eMMC, so remove this option from common code to avoid regressions.

Reported-by Stefan Roese <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

These 2 patches fix this DDR issue on my board. So:

Tested-by Stefan Roese <[email protected]>

Thanks,
Stefan

#7 lore raw

PATCH 1/2 mx6_common: Do not select esdhc DDR mode for all boards

In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really have a DDR-capable eMMC, so remove this option from common code to avoid regressions.

Reported-by Stefan Roese <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================