pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

PATCH New Axel Lin 5 participants 5 messages Mar 12, 2015 – Mar 18, 2015

Subsystems (3)

Arm MediaTek Pin control Pin controller - MediaTek

lore

Share & tools

lore

Axel Lin

author

2015-03-12 06:51 UTC #0 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2

Signed-off-by Axel Lin <[email protected]>

---
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h +1 -1

index 5019cef..e17aedb 100644
@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8135_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8135[] = {
 	MTK_PIN(

drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h +1 -1

index c1a3ca0..13e5b68 100644
@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8173_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8173[] = {
 	MTK_PIN(

Signature · 1 line

1.9.1

Matthias Brugger

maintainer

2015-03-12 10:32 UTC #1 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

2015-03-12 7:51 GMT+01:00 Axel Lin <[email protected]>:

Quoted 11 lines

Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin <[email protected]>

The fix from Guenter already addresses mt8135 case [0].

Reviewed-by Matthias Brugger <[email protected]>

for the mt8173 part.

Cheers,
Matthias

[0] https://lkml.org/lkml/2015/3/11/510

Quoted 36 lines

---
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h +1 -1

index 5019cef..e17aedb 100644
@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8135_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8135[] = {
        MTK_PIN(

drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h +1 -2

index c1a3ca0..13e5b68 100644
@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8173_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8173[] = {
        MTK_PIN(
--

1.9.1

Signature · 1 line

motzblog.wordpress.com

Guenter Roeck

2015-03-12 10:41 UTC #2 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

Quoted 11 lines · Matthias Brugger

2015-03-12 7:51 GMT+01:00 Axel Lin <[email protected]>:
Quoted 10 lines
Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2

Quoted 7 lines

Quoted 1 line
Signed-off-by Axel Lin <[email protected]>
The fix from Guenter already addresses mt8135 case [0].
Reviewed-by Matthias Brugger <[email protected]>
for the mt8173 part.

Axel's patch is more complete, so if my patch has not been applied yet I would suggest to take this one instead.

Reviewed-by Guenter Roeck <[email protected]>

Guenter

Quoted 44 lines

Cheers,
Matthias

[0] https://lkml.org/lkml/2015/3/11/510

Quoted 36 lines

---
  drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
  drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h +1 -1

index 5019cef..e17aedb 100644
@@ -16,7 +16,7 @@
  #define __PINCTRL_MTK_MT8135_H
 
  #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
  static const struct mtk_desc_pin mtk_pins_mt8135[] = {
         MTK_PIN(

drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h +1 -2

index c1a3ca0..13e5b68 100644
@@ -16,7 +16,7 @@
  #define __PINCTRL_MTK_MT8173_H
 
  #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
  static const struct mtk_desc_pin mtk_pins_mt8173[] = {
         MTK_PIN(
--

1.9.1

Hongzhou Yang

2015-03-13 19:44 UTC #3 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

In reply to Axel Lin

Quoted 34 lines · Axel Lin

Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h +1 -1
index 5019cef..e17aedb 100644
@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8135_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8135[] = {
 	MTK_PIN(
drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h +0 -0
index c1a3ca0..13e5b68 100644

drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h line 22

Quoted 8 lines

drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h +1 -1

@@ -16,7 +16,7 @@
 #define __PINCTRL_MTK_MT8173_H
 
 #include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
 
 static const struct mtk_desc_pin mtk_pins_mt8173[] = {
 	MTK_PIN(

Hi Axel,

Thank you very much.

Acked-by Hongzhou Yang <[email protected]>

Hongzhou

Linus Walleij

2015-03-18 12:07 UTC #4 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file

In reply to Axel Lin

Quoted 11 lines · Axel Lin

Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin <[email protected]>

Patch applied. Partially, since Guenther already fixed one oneliner.

Yours,
Linus Walleij