Skip to contentSkip to conversation

tools: remove chmod absolute path in setup.sh

PATCH Applied Andre Richter 2 participants 2 messages Mar 12, 2015 – Mar 17, 2015 1 message not in the archive

lore
Share & tools
lore

Andre Richter

author
#0 lore raw

PATCH 1/1 tools: remove chmod absolute path in setup.sh

setup.sh uses /usr/bin/chmod, but depending on distribution, it is not always there. For example, Ubuntu has /bin/chmod. Fix this by removing the absolute path, like it is done e.g. with grep.

---
 tools/setup.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/setup.sh +3 -3
index 245900f..ac438c2 100755
@@ -220,7 +220,7 @@ load_vfio_module()
 
 	# make sure regular users can read /dev/vfio
 	echo "chmod /dev/vfio"
-	sudo /usr/bin/chmod a+x /dev/vfio
+	sudo chmod a+x /dev/vfio
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit

@@ -278,7 +278,7 @@ set_vfio_permissions()
 {
 	# make sure regular users can read /dev/vfio
 	echo "chmod /dev/vfio"
-	sudo /usr/bin/chmod a+x /dev/vfio
+	sudo chmod a+x /dev/vfio
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit

@@ -287,7 +287,7 @@ set_vfio_permissions()
 
 	# make sure regular user can access everything inside /dev/vfio
 	echo "chmod /dev/vfio/*"
-	sudo /usr/bin/chmod 0666 /dev/vfio/*
+	sudo chmod 0666 /dev/vfio/*
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit
Signature · 1 line
1.9.1

A message that is not in the archive (sent off-list or not yet received): 1426180680-5350-1-git-send-email-andre.o.richter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Applied
#2 lore raw

2015-03-12 18:18, Andre Richter:

Quoted 3 lines

setup.sh uses /usr/bin/chmod, but depending on distribution, it is not always there. For example, Ubuntu has /bin/chmod. Fix this by removing the absolute path, like it is done e.g. with grep.

Applied, thanks