Skip to contentSkip to conversation

pinctrl: mediatek: mt8135/mt8173: Constify of_device_id table

PATCH In review Axel Lin 3 participants 3 messages Mar 13, 2015 – Mar 18, 2015

Subsystems (4)
GPIO Arm MediaTek Pin control Pin controller - MediaTek
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 pinctrl: mediatek: mt8135/mt8173: Constify of_device_id table

Also make the table a bit compact.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/mediatek/pinctrl-mt8135.c | 8 +++-----
 drivers/pinctrl/mediatek/pinctrl-mt8173.c | 8 +++-----
 2 files changed, 6 insertions(+), 10 deletions(-)
drivers/pinctrl/mediatek/pinctrl-mt8135.c +3 -5
index 1296d6d..b7e91c1 100644
@@ -347,11 +347,9 @@ static int mt8135_pinctrl_probe(struct platform_device *pdev)
 	return mtk_pctrl_init(pdev, &mt8135_pinctrl_data);
 }
 
-static struct of_device_id mt8135_pctrl_match[] = {
-	{
-		.compatible = "mediatek,mt8135-pinctrl",
-	}, {
-	}
+static const struct of_device_id mt8135_pctrl_match[] = {
+	{ .compatible = "mediatek,mt8135-pinctrl", },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, mt8135_pctrl_match);
drivers/pinctrl/mediatek/pinctrl-mt8173.c +3 -5
index f07cafb..46e4f6e 100644
@@ -427,11 +427,9 @@ static int mt8173_pinctrl_probe(struct platform_device *pdev)
 	return mtk_pctrl_init(pdev, &mt8173_pinctrl_data);
 }
 
-static struct of_device_id mt8173_pctrl_match[] = {
-	{
-		.compatible = "mediatek,mt8173-pinctrl",
-	}, {
-	}
+static const struct of_device_id mt8173_pctrl_match[] = {
+	{ .compatible = "mediatek,mt8173-pinctrl", },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, mt8173_pctrl_match);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · Axel Lin

Also make the table a bit compact.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/mediatek/pinctrl-mt8135.c | 8 +++-----
 drivers/pinctrl/mediatek/pinctrl-mt8173.c | 8 +++-----
 2 files changed, 6 insertions(+), 10 deletions(-)
drivers/pinctrl/mediatek/pinctrl-mt8135.c +3 -5
index 1296d6d..b7e91c1 100644
@@ -347,11 +347,9 @@ static int mt8135_pinctrl_probe(struct platform_device *pdev)
 	return mtk_pctrl_init(pdev, &mt8135_pinctrl_data);
 }
 
-static struct of_device_id mt8135_pctrl_match[] = {
-	{
-		.compatible = "mediatek,mt8135-pinctrl",
-	}, {
-	}
+static const struct of_device_id mt8135_pctrl_match[] = {
+	{ .compatible = "mediatek,mt8135-pinctrl", },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, mt8135_pctrl_match);
drivers/pinctrl/mediatek/pinctrl-mt8173.c +0 -1
index f07cafb..46e4f6e 100644
@@ -427,11 +427,9 @@ static int mt8173_pinctrl_probe(struct platform_device *pdev)
 	return mtk_pctrl_init(pdev, &mt8173_pinctrl_data);
 }
 
-static struct of_device_id mt8173_pctrl_match[] = {

drivers/pinctrl/mediatek/pinctrl-mt8173.c static int mt8173_pinctrl_probe(struct platform_device *pdev) · line 435

Quoted 10 lines
drivers/pinctrl/mediatek/pinctrl-mt8173.c +3 -4
-	{
-		.compatible = "mediatek,mt8173-pinctrl",
-	}, {
-	}
+static const struct of_device_id mt8173_pctrl_match[] = {
+	{ .compatible = "mediatek,mt8173-pinctrl", },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, mt8173_pctrl_match);

Hi Axel,

Thank you very much.

Acked-by Hongzhou Yang <[email protected]>

Hongzhou