iop-adma.c:1129: possible bad parameter in memset
PATCH 11/11 iop-adma.c:1129: possible bad parameter in memset
The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'.
Signed-off-by <[email protected]>
--- drivers/dma/iop-adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/iop-adma.c +1 -1
@@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device)/* Fill in src buffers */ for (i =0 ; i <IOP_ADMA_NUM_SRC_TEST ; i++) { pq_sw[i] =page_address (pq[i]); -memset (pq_sw[i],0x11111111 * (1 <<i),PAGE_SIZE ); +memset (pq_sw[i],0x11111111 & (1 <<i),PAGE_SIZE ); } pq_sw[i] =page_address (pq[i]); pq_sw[i+1 ] =page_address (pq[i+1 ]);
Signature · 1 line
2.1.0
Quoted 1 line · Ameen Ali
The 2nd
memset()argument '286331153' doesn't fit into an 'unsigned char'.
care to explain hpow it is fixed...
Quoted 2 lines
Signed-off-by <[email protected]>
This is not proper, see Documentation/SubmittingPatches
Quoted 20 lines
--- drivers/dma/iop-adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/iop-adma.c +1
-1@@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device)/* Fill in src buffers */ for (i =0 ; i <IOP_ADMA_NUM_SRC_TEST ; i++) { pq_sw[i] =page_address (pq[i]); -memset (pq_sw[i],0x11111111 * (1 <<i),PAGE_SIZE ); +memset (pq_sw[i],0x11111111 & (1 <<i),PAGE_SIZE ); } pq_sw[i] =page_address (pq[i]); pq_sw[i+1 ] =page_address (pq[i+1 ]);Signature · 1 line
2.1.0