arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts
Subsystems (4)
PATCH v5 2/4 arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts
Add initial device tree support for Qualcomm MSM8916 SoC and MTP8916 evaluation board. At the current time we only boot up a single processor.
---
v5:
* killed use of skeleton, moved to addr/size cells both being 2
* Added serial alias in prep of being able to spec uart params in chosen node
v4:
* Added chosen node so we dont need to spec everything for earlycon
* fixed up timer node to armv8, dropped clock-frequency
v3:
* Removed qcom,msm-id and qcom,board-id
* Added top level compat for "qcom,msm8916-mtp-smb1360"
v2:
* Updated to dropping CONFIG_ARCH_QCOM_MSM8916
* Updated to use qcom-ids.h
arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/qcom/Makefile | 5 + arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 21 ++++ arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi | 32 +++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 195 ++++++++++++++++++++++++++++++ 5 files changed, 254 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/Makefile create mode 100644 arch/arm64/boot/dts/qcom/msm8916-mtp.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8916.dtsi
arch/arm64/boot/dts/Makefile +1 -0
@@ -5,5 +5,6 @@ dts-dirs += cavium dts-dirs += exynos dts-dirs += freescale dts-dirs += mediatek +dts-dirs += qcom subdir-y := $(dts-dirs)
arch/arm64/boot/dts/qcom/Makefile new file +5 -0
@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtb
arch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +21 -0
@@ -0,0 +1,21 @@ +/* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 and +* only version 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +/dts-v1/; + +#include "msm8916-mtp.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. MSM 8916 MTP"; + compatible = "qcom,msm8916-mtp", "qcom,msm8916-mtp-smb1360", + "qcom,msm8916", "qcom,mtp"; +};
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +32 -0
@@ -0,0 +1,32 @@ +/* Copyright (c) 2014-2014, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "msm8916.dtsi" + +/ { + aliases { + serial0 = &blsp1_uart2; + }; + + chosen { + stdout-path = "serial0"; + }; + + soc { + serial at 78b0000 { + status = "okay"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&blsp1_uart2_default>; + pinctrl-1 = <&blsp1_uart2_sleep>; + }; + }; +};
arch/arm64/boot/dts/qcom/msm8916.dtsi new file +195 -0
195 lines not on this page · raw message
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 61 lines · Kumar Gala
Add initial device tree support for Qualcomm MSM8916 SoC and MTP8916 evaluation board. At the current time we only boot up a single processor.
Signed-off-by Kumar Gala <[email protected]>---
v5:
* killed use of skeleton, moved to addr/size cells both being 2
* Added serial alias in prep of being able to spec uart params in chosen nodev4:
* Added chosen node so we dont need to spec everything for earlycon
* fixed up timer node to armv8, dropped clock-frequencyv3:
* Removed qcom,msm-id and qcom,board-id
* Added top level compat for "qcom,msm8916-mtp-smb1360"v2:
* Updated to droppingCONFIG_ARCH_QCOM_MSM8916
* Updated to useqcom-ids.harch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/qcom/Makefile | 5 + arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 21 ++++ arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi | 32 +++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 195 ++++++++++++++++++++++++++++++ 5 files changed, 254 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/Makefile create mode 100644 arch/arm64/boot/dts/qcom/msm8916-mtp.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8916.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -5,5 +5,6 @@ dts-dirs += cavium dts-dirs += exynos dts-dirs += freescale dts-dirs += mediatek +dts-dirs += qcom subdir-y := $(dts-dirs)arch/arm64/boot/dts/qcom/Makefile new file +5
-0@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtbarch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +0
-0
arch/arm64/boot/dts/qcom/msm8916-mtp.dts line 1
Quoted 1 line
arch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +1
-0@@ -0,0 +1,21 @@ +/* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.
multi line comment rules
Quoted 26 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +20
-0+* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 and +* only version 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +/dts-v1/; + +#include "msm8916-mtp.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. MSM 8916 MTP"; + compatible = "qcom,msm8916-mtp", "qcom,msm8916-mtp-smb1360", + "qcom,msm8916", "qcom,mtp"; +};arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +0
-0
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi line 1
Quoted 1 line
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +1
-0@@ -0,0 +1,32 @@ +/* Copyright (c) 2014-2014, The Linux Foundation. All rights reserved.
multi line comment rules and 2014-2015
Quoted 20 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +20
-0+ * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "msm8916.dtsi" + +/ { + aliases { + serial0 = &blsp1_uart2; + }; + + chosen { + stdout-path = "serial0";
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi line 31
Quoted 10 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +10
-0+ }; + + soc { + serial at 78b0000 { + status = "okay"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&blsp1_uart2_default>; + pinctrl-1 = <&blsp1_uart2_sleep>; + }; + };
Why don't describe this as:
&blsp1_uart2 {
status = "okay";
pinctrl-names = xxxx;
....
};it looks more readable and obvious. This is what the other boards doing as well.
<snip>
Signature · 2 lines
regards, Stan
Quoted 129 lines · Stanimir Varbanov
Quoted 61 lines · Kumar Gala
Add initial device tree support for Qualcomm MSM8916 SoC and MTP8916 evaluation board. At the current time we only boot up a single processor.
Signed-off-by Kumar Gala <[email protected]>---
v5:
* killed use of skeleton, moved to addr/size cells both being 2
* Added serial alias in prep of being able to spec uart params in chosen nodev4:
* Added chosen node so we dont need to spec everything for earlycon
* fixed up timer node to armv8, dropped clock-frequencyv3:
* Removed qcom,msm-id and qcom,board-id
* Added top level compat for "qcom,msm8916-mtp-smb1360"v2:
* Updated to droppingCONFIG_ARCH_QCOM_MSM8916
* Updated to useqcom-ids.harch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/qcom/Makefile | 5 + arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 21 ++++ arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi | 32 +++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 195 ++++++++++++++++++++++++++++++ 5 files changed, 254 insertions(+)create mode 100644
arch/arm64/boot/dts/qcom/Makefilecreate mode 100644arch/arm64/boot/dts/qcom/msm8916-mtp.dtscreate mode 100644arch/arm64/boot/dts/qcom/msm8916-mtp.dtsicreate mode 100644arch/arm64/boot/dts/qcom/msm8916.dtsiarch/arm64/boot/dts/Makefile +0
-0@@ -5,5 +5,6 @@ dts-dirs += caviumdts-dirs += exynos
dts-dirs += freescale
dts-dirs += mediatek
+dts-dirs += qcomsubdir-y := $(dts-dirs)
arch/arm64/boot/dts/qcom/Makefile new file +5
-0@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtbarch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +0
-0arch/arm64/boot/dts/qcom/msm8916-mtp.dts line 1
Quoted 1 line
arch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +1
-0@@ -0,0 +1,21 @@ +/* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.multi line comment rules
Quoted 26 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dts new file +20
-0+* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 and +* only version 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +/dts-v1/; + +#include "msm8916-mtp.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. MSM 8916 MTP"; + compatible = "qcom,msm8916-mtp", "qcom,msm8916-mtp-smb1360", + "qcom,msm8916", "qcom,mtp"; +};arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +0
-0arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi line 1
Quoted 1 line
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +1
-0@@ -0,0 +1,32 @@ +/* Copyright (c) 2014-2014, The Linux Foundation. All rights reserved.multi line comment rules and 2014-2015
Quoted 20 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +20
-0+ * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "msm8916.dtsi" + +/ { + aliases { + serial0 = &blsp1_uart2; + }; + + chosen { + stdout-path = "serial0";arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi line 31
Quoted 10 lines
arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi new file +10
-0+ }; + + soc { + serial at 78b0000 { + status = "okay"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&blsp1_uart2_default>; + pinctrl-1 = <&blsp1_uart2_sleep>; + }; + };Why don't describe this as:
Quoted 8 lines
&blsp1_uart2 { status = "okay"; pinctrl-names = xxxx; .... };it looks more readable and obvious. This is what the other boards doing as well.
I find the way it is more explicit and obvious, plus it works for cases that don?t have a label associated with them.
I?ll fixup the multiline comment issues.
- k
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project