Split Documentation/rtc.txt
Subsystems (4)
v2 cover Split Documentation/rtc.txt
Documentation/rtc.txt is a combination of two files, a real documentation file and a test program. Splitting these up into two files is a good idea for automated testing. While testing on an AMD based system it was noticed that the RTC was not behaving properly which lead to a possible bug in the BIOS (the analysis of which is still ongoing). rtctest.c returned a false positive because it does not check the time between interrupts is what was expected. This patchset adds Documentation/rtc, splits the rtc.txt into two files and updates the test to verify the passage of time.
[v2] this patchset was built ongit://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next in order to get jstultz' latest tools/testing/selftests/timers/ changes.
Prarit Bhargava (2):
Documentation, split up rtc.txt into documentation and test file tools, update rtctest.c to verify passage of time
Documentation/rtc.txt | 264 +----------------------------- tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 271 +++++++++++++++++++++++++++++++ 3 files changed, 274 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Signature · 1 line
1.8.3.1
PATCH v2 1/2 Documentation, split up rtc.txt into documentation and test file
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the rtctest.c file. The rtctest file is moved into the kernel tools/testing/selftests/timers directory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of the rtctest.c file has changed.
--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Documentation/rtc.txt +1 -263
@@ -204,266 +204,4 @@ Some common examples: * RTC_PIE_ON, RTC_PIE_OFF: These are also emulated by the generic code. -If all else fails, check out the rtc-test.c driver! - - --------------------- 8< ---------------- 8< ----------------------------- - -/* - * Real Time Clock Driver Test/Example Program - * - * Compile with: - * gcc -s -Wall -Wstrict-prototypes rtctest.c -o rtctest - * - * Copyright (C) 1996, Paul Gortmaker. - * - * Released under the GNU General Public License, version 2, - * included herein by reference. - * - */ - -#include <stdio.h> -#include <linux/rtc.h> -#include <sys/ioctl.h> -#include <sys/time.h> -#include <sys/types.h> -#include <fcntl.h> -#include <unistd.h> -#include <stdlib.h> -#include <errno.h> - - -/* - * This expects the new RTC class driver framework, working with - * clocks that will often not be clones of what the PC-AT had. - * Use the command line to specify another RTC if you need one. - */ -static const char default_rtc[] = "/dev/rtc0"; - - -int main(int argc, char **argv) -{ - int i, fd, retval, irqcount = 0; - unsigned long tmp, data; - struct rtc_time rtc_tm; - const char *rtc = default_rtc; - - switch (argc) { - case 2: - rtc = argv[1]; - /* FALLTHROUGH */ - case 1: - break; - default: - fprintf(stderr, "usage: rtctest [rtcdev]\n"); - return 1; - } - - fd = open(rtc, O_RDONLY); - - if (fd == -1) { - perror(rtc); - exit(errno); - } - - fprintf(stderr, "\n\t\t\tRTC Driver Test Example.\n\n"); - - /* Turn on update interrupts (one per second) */ - retval = ioctl(fd, RTC_UIE_ON, 0); - if (retval == -1) { - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Update IRQs not supported.\n"); - goto test_READ; - } - perror("RTC_UIE_ON ioctl"); - exit(errno); - } - - fprintf(stderr, "Counting 5 update (1/sec) interrupts from reading %s:", - rtc); - fflush(stderr); - for (i=1; i<6; i++) { - /* This read will block */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - fprintf(stderr, "\nAgain, from using select(2) on /dev/rtc:"); - fflush(stderr); - for (i=1; i<6; i++) { - struct timeval tv = {5, 0}; /* 5 second timeout on select */ - fd_set readfds; - - FD_ZERO(&readfds); - FD_SET(fd, &readfds); - /* The select will wait until an RTC interrupt happens. */ - retval = select(fd+1, &readfds, NULL, NULL, &tv); - if (retval == -1) { - perror("select"); - exit(errno); - } - /* This read won't block unlike the select-less case above. */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - /* Turn off update interrupts */ - retval = ioctl(fd, RTC_UIE_OFF, 0); - if (retval == -1) { - perror("RTC_UIE_OFF ioctl"); - exit(errno); - } - -test_READ: - /* Read the RTC time/date */ - retval = ioctl(fd, RTC_RD_TIME, &rtc_tm); - if (retval == -1) { - perror("RTC_RD_TIME ioctl"); - exit(errno); - } - - fprintf(stderr, "\n\nCurrent RTC date/time is %d-%d-%d, %02d:%02d:%02d.\n", - rtc_tm.tm_mday, rtc_tm.tm_mon + 1, rtc_tm.tm_year + 1900, - rtc_tm.tm_hour, rtc_tm.tm_min, rtc_tm.tm_sec); - - /* Set the alarm to 5 sec in the future, and check for rollover */ - rtc_tm.tm_sec += 5; - if (rtc_tm.tm_sec >= 60) { - rtc_tm.tm_sec %= 60; - rtc_tm.tm_min++; - } - if (rtc_tm.tm_min == 60) { - rtc_tm.tm_min = 0; - rtc_tm.tm_hour++; - } - if (rtc_tm.tm_hour == 24) - rtc_tm.tm_hour = 0; - - retval = ioctl(fd, RTC_ALM_SET, &rtc_tm); - if (retval == -1) { - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Alarm IRQs not supported.\n"); - goto test_PIE; - } - perror("RTC_ALM_SET ioctl"); - exit(errno); - } - - /* Read the current alarm settings */ - retval = ioctl(fd, RTC_ALM_READ, &rtc_tm); - if (retval == -1) { - perror("RTC_ALM_READ ioctl"); - exit(errno); - } - - fprintf(stderr, "Alarm time now set to %02d:%02d:%02d.\n", - rtc_tm.tm_hour, rtc_tm.tm_min, rtc_tm.tm_sec); - - /* Enable alarm interrupts */ - retval = ioctl(fd, RTC_AIE_ON, 0); - if (retval == -1) { - perror("RTC_AIE_ON ioctl"); - exit(errno); - } - - fprintf(stderr, "Waiting 5 seconds for alarm..."); - fflush(stderr); - /* This blocks until the alarm ring causes an interrupt */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - irqcount++; - fprintf(stderr, " okay. Alarm rang.\n"); - - /* Disable alarm interrupts */ - retval = ioctl(fd, RTC_AIE_OFF, 0); - if (retval == -1) { - perror("RTC_AIE_OFF ioctl"); - exit(errno); - } - -test_PIE: - /* Read periodic IRQ rate */ - retval = ioctl(fd, RTC_IRQP_READ, &tmp); - if (retval == -1) { - /* not all RTCs support periodic IRQs */ - if (errno == ENOTTY) { - fprintf(stderr, "\nNo periodic IRQ support\n"); - goto done; - } - perror("RTC_IRQP_READ ioctl"); - exit(errno); - } - fprintf(stderr, "\nPeriodic IRQ rate is %ldHz.\n", tmp); - - fprintf(stderr, "Counting 20 interrupts at:"); - fflush(stderr); - - /* The frequencies 128Hz, 256Hz, ... 8192Hz are only allowed for root. */ - for (tmp=2; tmp<=64; tmp*=2) { - - retval = ioctl(fd, RTC_IRQP_SET, tmp); - if (retval == -1) { - /* not all RTCs can change their periodic IRQ rate */ - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Periodic IRQ rate is fixed\n"); - goto done; - } - perror("RTC_IRQP_SET ioctl"); - exit(errno); - } - - fprintf(stderr, "\n%ldHz:\t", tmp); - fflush(stderr); - - /* Enable periodic interrupts */ - retval = ioctl(fd, RTC_PIE_ON, 0); - if (retval == -1) { - perror("RTC_PIE_ON ioctl"); - exit(errno); - } - - for (i=1; i<21; i++) { - /* This blocks */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - /* Disable periodic interrupts */ - retval = ioctl(fd, RTC_PIE_OFF, 0); - if (retval == -1) { - perror("RTC_PIE_OFF ioctl"); - exit(errno); - } - } - -done: - fprintf(stderr, "\n\n\t\t\t *** Test complete ***\n"); - - close(fd); - - return 0; -} +If all else fails, check out the tools/testing/selftests/timers/rtctest.c test!
tools/testing/selftests/timers/Makefile +2 -1
@@ -5,7 +5,7 @@ LDFLAGS += -lrt -lpthread bins = posix_timers nanosleep inconsistency-check nsleep-lat raw_skew \ set-timer-lat threadtest mqueue-lat valid-adjtimex \ alarmtimer-suspend change_skew skew_consistency clocksource-switch \ - leap-a-day leapcrash set-tai set-2038 + leap-a-day leapcrash set-tai set-2038 rtctest all: ${bins}
@@ -20,6 +20,7 @@ run_tests: all ./inconsistency-check ./raw_skew ./threadtest -t 30 -n 8 + ./rtctest # these tests require escalated privledges # and may modify the system time or trigger
tools/testing/selftests/timers/rtctest.c new file +258 -0
258 lines not on this page · raw message
Signature · 1 line
1.8.3.1
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 15 lines · Prarit Bhargava
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the
rtctest.cfile. The rtctest file is moved into the kerneltools/testing/selftests/timersdirectory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of thertctest.cfile has changed.
Quoted 6 lines
--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
In reply to Prarit BhargavaQuoted 15 lines · Prarit Bhargava
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the
rtctest.cfile. The rtctest file is moved into the kerneltools/testing/selftests/timersdirectory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of thertctest.cfile has changed.
Quoted 6 lines
--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
thanks,
-- Shuah
Signature · 5 lines
Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
John Stultz
Acked-byRe: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 23 lines · Shuah Khan
Quoted 15 lines · Prarit Bhargava
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the
rtctest.cfile. The rtctest file is moved into the kerneltools/testing/selftests/timersdirectory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of thertctest.cfile has changed.Quoted 6 lines
--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Quoted 4 lines
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
So you should already have acks on both of these in your mail box, but to save you time digging through:
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 24 lines · John Stultz
Quoted 23 lines · Shuah Khan
Quoted 21 lines · Prarit Bhargava
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the
rtctest.cfile. The rtctest file is moved into the kerneltools/testing/selftests/timersdirectory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of thertctest.cfile has changed.Signed-off-by Prarit Bhargava <[email protected]>--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Quoted 9 lines
Quoted 4 lines
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
So you should already have acks on both of these in your mail box, but to save you time digging through:
Acked-by John Stultz <[email protected]>
John,
Thanks I have yours. I looking to get an Ack from Jon Corbet for the documentation change.
-- Shuah
Signature · 5 lines
Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
In reply to Shuah KhanQuoted 4 lines · On Thu, 19 Mar 2015 12:24:41 -0600 Shuah Khan <[email protected]> wrote:
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
I'd sure like to move more stuff out of the top-level Documentation/ directory, but that's no reason to hold this up.
I'll assume you're taking it from here.
Thanks,
jon
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 8 lines · Jonathan Corbet
Quoted 4 lines · On Thu, 19 Mar 2015 12:24:41 -0600 Shuah Khan <[email protected]> wrote:
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
Quoted 9 lines
I'd sure like to move more stuff out of the top-level
Documentation/directory, but that's no reason to hold this up.Acked-by Jonathan Corbet <[email protected]>I'll assume you're taking it from here.
Thanks,
Thanks. Yes I will take these through kselftest tree.
-- Shuah
Signature · 5 lines
Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 12 lines · Shuah Khan
Quoted 11 lines · Jonathan Corbet
Quoted 4 lines · On Thu, 19 Mar 2015 12:24:41 -0600 Shuah Khan <[email protected]> wrote:
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
I'd sure like to move more stuff out of the top-level
Documentation/directory, but that's no reason to hold this up.
Quoted 7 lines
Quoted 6 lines
Acked-by Jonathan Corbet <[email protected]>I'll assume you're taking it from here.
Thanks,
Hi Prarit,
Could you please rebase this patch on linux-kselftest next? I applied a patch that adds timer tests to common logic for run_tests and install. This patch changed timer Makefile and your patch conflicts with it. It would be easier to rebase than fix the conflict.
There is no need to rebase the second patch. Just this one.
thanks,
-- Shuah
Signature · 5 lines
Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 23 lines · Shuah Khan
Quoted 12 lines · Shuah Khan
Quoted 11 lines · Jonathan Corbet
Quoted 4 lines · On Thu, 19 Mar 2015 12:24:41 -0600 Shuah Khan <[email protected]> wrote:
Hi Jon,
Would you like to review the change and Ack it, so I can take the change in my tree.
I'd sure like to move more stuff out of the top-level
Documentation/directory, but that's no reason to hold this up.Quoted 7 lines
Quoted 6 lines
Acked-by Jonathan Corbet <[email protected]>I'll assume you're taking it from here.
Thanks,
Hi Prarit,
Quoted 7 lines
Could you please rebase this patch on linux-kselftest next? I applied a patch that adds timer tests to common logic for
run_testsand install. This patch changed timerMakefileand your patch conflicts with it. It would be easier to rebase than fix the conflict.There is no need to rebase the second patch. Just this one.
Sure, no problem.
Jon Corbet -- since I need to respin, you mentioned earlier that you didn't want the rtc.txt file in the Documentation/ directory. Do you want me to also at the same time move it to Documentation/timers/rtc.txt ?
P.
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
In reply to Shuah KhanThis patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the rtctest.c file. The rtctest file is moved into the kernel tools/testing/selftests/timers directory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of the rtctest.c file has changed.
[v2]: rebase
[v3]: rebase
--- Documentation/rtc.txt | 264 +------------------------------ tools/testing/selftests/timers/Makefile | 2 +- tools/testing/selftests/timers/rtctest.c | 258 ++++++++++++++++++++++++++++++ 3 files changed, 260 insertions(+), 264 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest.c
Documentation/rtc.txt +1 -263
@@ -204,266 +204,4 @@ Some common examples: * RTC_PIE_ON, RTC_PIE_OFF: These are also emulated by the generic code. -If all else fails, check out the rtc-test.c driver! - - --------------------- 8< ---------------- 8< ----------------------------- - -/* - * Real Time Clock Driver Test/Example Program - * - * Compile with: - * gcc -s -Wall -Wstrict-prototypes rtctest.c -o rtctest - * - * Copyright (C) 1996, Paul Gortmaker. - * - * Released under the GNU General Public License, version 2, - * included herein by reference. - * - */ - -#include <stdio.h> -#include <linux/rtc.h> -#include <sys/ioctl.h> -#include <sys/time.h> -#include <sys/types.h> -#include <fcntl.h> -#include <unistd.h> -#include <stdlib.h> -#include <errno.h> - - -/* - * This expects the new RTC class driver framework, working with - * clocks that will often not be clones of what the PC-AT had. - * Use the command line to specify another RTC if you need one. - */ -static const char default_rtc[] = "/dev/rtc0"; - - -int main(int argc, char **argv) -{ - int i, fd, retval, irqcount = 0; - unsigned long tmp, data; - struct rtc_time rtc_tm; - const char *rtc = default_rtc; - - switch (argc) { - case 2: - rtc = argv[1]; - /* FALLTHROUGH */ - case 1: - break; - default: - fprintf(stderr, "usage: rtctest [rtcdev]\n"); - return 1; - } - - fd = open(rtc, O_RDONLY); - - if (fd == -1) { - perror(rtc); - exit(errno); - } - - fprintf(stderr, "\n\t\t\tRTC Driver Test Example.\n\n"); - - /* Turn on update interrupts (one per second) */ - retval = ioctl(fd, RTC_UIE_ON, 0); - if (retval == -1) { - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Update IRQs not supported.\n"); - goto test_READ; - } - perror("RTC_UIE_ON ioctl"); - exit(errno); - } - - fprintf(stderr, "Counting 5 update (1/sec) interrupts from reading %s:", - rtc); - fflush(stderr); - for (i=1; i<6; i++) { - /* This read will block */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - fprintf(stderr, "\nAgain, from using select(2) on /dev/rtc:"); - fflush(stderr); - for (i=1; i<6; i++) { - struct timeval tv = {5, 0}; /* 5 second timeout on select */ - fd_set readfds; - - FD_ZERO(&readfds); - FD_SET(fd, &readfds); - /* The select will wait until an RTC interrupt happens. */ - retval = select(fd+1, &readfds, NULL, NULL, &tv); - if (retval == -1) { - perror("select"); - exit(errno); - } - /* This read won't block unlike the select-less case above. */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - /* Turn off update interrupts */ - retval = ioctl(fd, RTC_UIE_OFF, 0); - if (retval == -1) { - perror("RTC_UIE_OFF ioctl"); - exit(errno); - } - -test_READ: - /* Read the RTC time/date */ - retval = ioctl(fd, RTC_RD_TIME, &rtc_tm); - if (retval == -1) { - perror("RTC_RD_TIME ioctl"); - exit(errno); - } - - fprintf(stderr, "\n\nCurrent RTC date/time is %d-%d-%d, %02d:%02d:%02d.\n", - rtc_tm.tm_mday, rtc_tm.tm_mon + 1, rtc_tm.tm_year + 1900, - rtc_tm.tm_hour, rtc_tm.tm_min, rtc_tm.tm_sec); - - /* Set the alarm to 5 sec in the future, and check for rollover */ - rtc_tm.tm_sec += 5; - if (rtc_tm.tm_sec >= 60) { - rtc_tm.tm_sec %= 60; - rtc_tm.tm_min++; - } - if (rtc_tm.tm_min == 60) { - rtc_tm.tm_min = 0; - rtc_tm.tm_hour++; - } - if (rtc_tm.tm_hour == 24) - rtc_tm.tm_hour = 0; - - retval = ioctl(fd, RTC_ALM_SET, &rtc_tm); - if (retval == -1) { - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Alarm IRQs not supported.\n"); - goto test_PIE; - } - perror("RTC_ALM_SET ioctl"); - exit(errno); - } - - /* Read the current alarm settings */ - retval = ioctl(fd, RTC_ALM_READ, &rtc_tm); - if (retval == -1) { - perror("RTC_ALM_READ ioctl"); - exit(errno); - } - - fprintf(stderr, "Alarm time now set to %02d:%02d:%02d.\n", - rtc_tm.tm_hour, rtc_tm.tm_min, rtc_tm.tm_sec); - - /* Enable alarm interrupts */ - retval = ioctl(fd, RTC_AIE_ON, 0); - if (retval == -1) { - perror("RTC_AIE_ON ioctl"); - exit(errno); - } - - fprintf(stderr, "Waiting 5 seconds for alarm..."); - fflush(stderr); - /* This blocks until the alarm ring causes an interrupt */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - irqcount++; - fprintf(stderr, " okay. Alarm rang.\n"); - - /* Disable alarm interrupts */ - retval = ioctl(fd, RTC_AIE_OFF, 0); - if (retval == -1) { - perror("RTC_AIE_OFF ioctl"); - exit(errno); - } - -test_PIE: - /* Read periodic IRQ rate */ - retval = ioctl(fd, RTC_IRQP_READ, &tmp); - if (retval == -1) { - /* not all RTCs support periodic IRQs */ - if (errno == ENOTTY) { - fprintf(stderr, "\nNo periodic IRQ support\n"); - goto done; - } - perror("RTC_IRQP_READ ioctl"); - exit(errno); - } - fprintf(stderr, "\nPeriodic IRQ rate is %ldHz.\n", tmp); - - fprintf(stderr, "Counting 20 interrupts at:"); - fflush(stderr); - - /* The frequencies 128Hz, 256Hz, ... 8192Hz are only allowed for root. */ - for (tmp=2; tmp<=64; tmp*=2) { - - retval = ioctl(fd, RTC_IRQP_SET, tmp); - if (retval == -1) { - /* not all RTCs can change their periodic IRQ rate */ - if (errno == ENOTTY) { - fprintf(stderr, - "\n...Periodic IRQ rate is fixed\n"); - goto done; - } - perror("RTC_IRQP_SET ioctl"); - exit(errno); - } - - fprintf(stderr, "\n%ldHz:\t", tmp); - fflush(stderr); - - /* Enable periodic interrupts */ - retval = ioctl(fd, RTC_PIE_ON, 0); - if (retval == -1) { - perror("RTC_PIE_ON ioctl"); - exit(errno); - } - - for (i=1; i<21; i++) { - /* This blocks */ - retval = read(fd, &data, sizeof(unsigned long)); - if (retval == -1) { - perror("read"); - exit(errno); - } - fprintf(stderr, " %d",i); - fflush(stderr); - irqcount++; - } - - /* Disable periodic interrupts */ - retval = ioctl(fd, RTC_PIE_OFF, 0); - if (retval == -1) { - perror("RTC_PIE_OFF ioctl"); - exit(errno); - } - } - -done: - fprintf(stderr, "\n\n\t\t\t *** Test complete ***\n"); - - close(fd); - - return 0; -} +If all else fails, check out the tools/testing/selftests/timers/rtctest.c test!
tools/testing/selftests/timers/Makefile +1 -1
@@ -6,7 +6,7 @@ LDFLAGS += -lrt -lpthread # these are all "safe" tests that don't modify # system time or require escalated privledges TEST_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat mqueue-lat \ - inconsistency-check raw_skew threadtest + inconsistency-check raw_skew threadtest rtctest TEST_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex change_skew \ skew_consistency clocksource-switch leap-a-day \
tools/testing/selftests/timers/rtctest.c new file +258 -0
258 lines not on this page · raw message
Signature · 1 line
1.8.3.1
Re: [PATCH 1/2 v2] Documentation, split up rtc.txt into documentation and test file
Quoted 6 lines · Prarit Bhargava
This patch splits rtc.txt into two separate files, one for the documentation itself, and the other for the
rtctest.cfile. The rtctest file is moved into the kerneltools/testing/selftests/timersdirectory. This will make automated testing easier. Note that the only difference in the rtc.txt file is that the location of thertctest.cfile has changed.
Quoted 9 lines
Applied this patch and 2/2 to linux-kselftest next for 4.1
thanks,
-- Shuah
Signature · 5 lines
Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
PATCH v2 2/2 tools, update rtctest.c to verify passage of time
In reply to Prarit Bhargavartctest.c checks to see if PIE is functioning by testing if 20 interrupts occur at rates from 2HZ to 64HZ. While this check is good, it does not check to see if the correct amount of time has actually passed. This misses situations where the RTC may be operating at a higher or lower frequency than expected.
This patch introduces a simple check to verify if the time passed is less than 10% of what was programmed into the RTC.
--- tools/testing/selftests/timers/rtctest.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
tools/testing/selftests/timers/rtctest.c +13 -0
@@ -36,6 +36,7 @@ int main(int argc, char **argv)unsigned long tmp, data;struct rtc_time rtc_tm;const char *rtc = default_rtc; +struct timeval start, end, diff;switch (argc) {case 2 :
@@ -230,12 +231,24 @@ test_PIE: }for (i=1 ; i<21 ; i++) { +gettimeofday (&start,NULL );/* This blocks */ retval =read (fd, &data,sizeof (unsigned long ));if (retval ==-1 ) {perror ("read" );exit (errno); } +gettimeofday (&end,NULL ); +timersub (&end, &start, &diff); +if (diff.tv_sec >0 || + diff.tv_usec > ((1000000L / tmp) *1.10 )) { +fprintf (stderr,"\nPIE delta error: %ld.%06ld should be close to 0.%06ld\n" , + diff.tv_sec, diff.tv_usec, + (1000000L / tmp)); +fflush (stdout); +exit (-1 ); + } +fprintf (stderr," %d" ,i);fflush (stderr); irqcount++;
Signature · 1 line
1.8.3.1
Re: [PATCH 2/2 v2] tools, update rtctest.c to verify passage of time
Quoted 9 lines · Prarit Bhargava
rtctest.cchecks to see if PIE is functioning by testing if 20 interrupts occur at rates from 2HZ to 64HZ. While this check is good, it does not check to see if the correct amount of time has actually passed. This misses situations where the RTC may be operating at a higher or lower frequency than expected.This patch introduces a simple check to verify if the time passed is less than 10% of what was programmed into the RTC.
Quoted 8 lines
thanks
-john