MAINTAINERS: add brcmstb regex
PATCH 1/1 MAINTAINERS: add brcmstb regex
This could probably consolidate a few file listings. And it satisfies the spirit of the highly annoying [1] checkpatch warning for every new file, though it sadly won't quash it.
[1] https://lkml.org/lkml/2014/12/17/24
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -2179,6 +2179,7 @@ S: Maintained F: arch/arm/mach-bcm/*brcmstb* F: arch/arm/boot/dts/bcm7*.dts* F: drivers/bus/brcmstb_gisb.c +N: brcmstb BROADCOM BMIPS MIPS ARCHITECTURE M: Kevin Cernekee <[email protected]>
Signature · 1 line
1.9.1
Quoted 7 lines · Brian Norris
This could probably consolidate a few file listings. And it satisfies the spirit of the highly annoying [1] checkpatch warning for every new file, though it sadly won't quash it.
[1] https://lkml.org/lkml/2014/12/17/24
Signed-off-by Brian Norris <[email protected]>
Ping? Is this a good entry?
One problem is that there may be 'brcmstb' drivers for MIPS as well as ARM. But on that train of thought: there are several drivers which are already somewhat inaccurately-listed. The following are listed under either the BCM7XXX ARM subarchitecture or BMIPS MIPS subarchitecture, though they are actually used on both:
drivers/bus/brcmstb_gisb.c
drivers/irqchip/irq-brcmstb-l2.c
drivers/irqchip/irq-bcm7120-l2.c
Brian
Quoted 19 lines
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +1
-0@@ -2179,6 +2179,7 @@ S: Maintained F: arch/arm/mach-bcm/*brcmstb* F: arch/arm/boot/dts/bcm7*.dts* F: drivers/bus/brcmstb_gisb.c +N: brcmstb BROADCOM BMIPS MIPS ARCHITECTURE M: Kevin Cernekee <[email protected]>Signature · 1 line
1.9.1
(cc'ing Andrew Morton)
Quoted 10 lines · Brian Norris
Quoted 7 lines · Brian Norris
This could probably consolidate a few file listings. And it satisfies the spirit of the highly annoying [1] checkpatch warning for every new file, though it sadly won't quash it.
[1] https://lkml.org/lkml/2014/12/17/24
Signed-off-by Brian Norris <[email protected]>Ping? Is this a good entry?
As you're a MAINTAINER of this section, if you want it to be a good entry, it's a good entry.
You should get someone (Andrew?) to apply it.
Be aware that N: matches aren't as "owned" as F: matches.
Note from MAINTAINERS:
N: Files and directories with regex patterns.
One pattern per line. Multiple N: lines acceptable. scripts/get_maintainer.pl has different behavior for files that match F: pattern and matches of N: patterns. By default, get_maintainer will not look at git log history when an F: pattern match occurs. When an N: match occurs, git log history is used to also notify the people that have git commit signatures.
Quoted 31 lines
One problem is that there may be 'brcmstb' drivers for MIPS as well as ARM. But on that train of thought: there are several drivers which are already somewhat inaccurately-listed. The following are listed under either the BCM7XXX ARM subarchitecture or BMIPS MIPS subarchitecture, though they are actually used on both:
drivers/bus/brcmstb_gisb.c
drivers/irqchip/irq-brcmstb-l2.c
drivers/irqchip/irq-bcm7120-l2.cBrian
Quoted 19 lines
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +1
-0@@ -2179,6 +2179,7 @@ S: Maintained F: arch/arm/mach-bcm/*brcmstb* F: arch/arm/boot/dts/bcm7*.dts* F: drivers/bus/brcmstb_gisb.c +N: brcmstb BROADCOM BMIPS MIPS ARCHITECTURE M: Kevin Cernekee <[email protected]>Signature · 1 line
1.9.1
Quoted 8 lines · Joe Perches
(cc'ing Andrew Morton)
Quoted 5 lines · Brian Norris
Quoted 4 lines · Brian Norris
This could probably consolidate a few file listings. And it satisfies the spirit of the highly annoying [1] checkpatch warning for every new file, though it sadly won't quash it.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
[1] https://lkml.org/lkml/2014/12/17/24
Signed-off-by Brian Norris <[email protected]>Ping? Is this a good entry?
As you're a MAINTAINER of this section, if you want it to be a good entry, it's a good entry.
My comment below about MIPS vs. ARM was the key point, and it might deserve comment from others. Personally, I think it's OK, but it's just a little strange when linux-arm-kernel becomes a catch-all for all embedded drivers, even for those that are being utilized on (B)MIPS.
Quoted 1 line
You should get someone (Andrew?) to apply it.
The "apply" step would be more directed toward Florian, who manages most of the Broadcom arm-soc trees.
Quoted 20 lines
Be aware that N: matches aren't as "owned" as F: matches.
Note from
MAINTAINERS:
N: Files and directories with regex patterns.
One pattern per line. Multiple N: lines acceptable.scripts/get_maintainer.plhas different behavior for files that match F: pattern and matches of N: patterns. By default,get_maintainerwill not look at git log history when an F: pattern match occurs. When an N: match occurs, git log history is used to also notify the people that have git commit signatures.Quoted 9 lines
One problem is that there may be 'brcmstb' drivers for MIPS as well as ARM. But on that train of thought: there are several drivers which are already somewhat inaccurately-listed. The following are listed under either the BCM7XXX ARM subarchitecture or BMIPS MIPS subarchitecture, though they are actually used on both:
drivers/bus/brcmstb_gisb.c
drivers/irqchip/irq-brcmstb-l2.c
drivers/irqchip/irq-bcm7120-l2.c
Brian
Florian Fainelli
AppliedQuoted 7 lines · Brian Norris
This could probably consolidate a few file listings. And it satisfies the spirit of the highly annoying [1] checkpatch warning for every new file, though it sadly won't quash it.
[1] https://lkml.org/lkml/2014/12/17/24
Signed-off-by Brian Norris <[email protected]>
Applied, thanks!
Signature · 1 line
Florian