Skip to contentSkip to conversation

drm/i195/bxt: Add A1 stepping for Broxton

PATCH In review Nick Hoath 4 participants 8 messages Mar 20, 2015 – May 6, 2015

Subsystems (2)
lore
Share & tools
lore

Nick Hoath

author
#0 lore raw

PATCH 1/1 drm/i195/bxt: Add A1 stepping for Broxton

This stepping isn't listed separately in the specs, so needs confirmation.

---
 drivers/gpu/drm/i915/i915_drv.h | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.h +1 -0
index eec271a..68fb41a 100644
@@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
 #define SKL_REVID_E0		(0x4)
 
 #define BXT_REVID_A0		(0x0)
+#define BXT_REVID_A1		(0x1)
 #define BXT_REVID_B0		(0x3)
 #define BXT_REVID_C0		(0x6)
 
Signature · 6 lines
2.1.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#1 lore raw

Task id: 6016 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -2 274/274 272/274

ILK                                  303/303              303/303
SNB                                  303/303              303/303
IVB                 -2              342/342              340/342
BYT                                  287/287              287/287
HSW                                  362/362              362/362
BDW                                  308/308              308/308
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
*PNV  igt_gem_userptr_blits_minor-sync-interruptible      PASS(2)      DMESG_WARN(1)PASS(1)
*PNV  igt_gen3_render_linear_blits      PASS(3)      CRASH(1)PASS(1)
 IVB  igt_gem_pwrite_pread_snooped-copy-performance      DMESG_WARN(1)PASS(3)      DMESG_WARN(1)PASS(1)
*IVB  igt_gem_storedw_batches_loop_secure-dispatch      PASS(3)      DMESG_WARN(1)PASS(1)

Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 17 lines · On 03/20/2015 10:14 AM, [email protected] wrote:

Task id: 6016 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -2 274/274 272/274

ILK                                  303/303              303/303
SNB                                  303/303              303/303
IVB                 -2              342/342              340/342
BYT                                  287/287              287/287
HSW                                  362/362              362/362
BDW                                  308/308              308/308
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
*PNV  igt_gem_userptr_blits_minor-sync-interruptible      PASS(2)      DMESG_WARN(1)PASS(1)
*PNV  igt_gen3_render_linear_blits      PASS(3)      CRASH(1)PASS(1)
 IVB  igt_gem_pwrite_pread_snooped-copy-performance      DMESG_WARN(1)PASS(3)      DMESG_WARN(1)PASS(1)
*IVB  igt_gem_storedw_batches_loop_secure-dispatch      PASS(3)      DMESG_WARN(1)PASS(1)
Quoted 1 line

Note: You need to pay more attention to line start with '*'

I wonder what these warnings actually are... I've been seeing the userptr_blits tests on PNV trigger warnings in a lot of PRTS results lately, and it must be intermittent since this patch would have no effect on PNV.

Shuang, when do you think you'll be able to attach the dmesg snippets from failures like these to the msgs? Would make things easier to triage at least.

And do we have a bug open? I don't see this particular issue listed in the igt failures at bugs.fdo, but it could be a dupe with some other warning there.

Thanks,
Jesse

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 30 lines

-----Original Message-----
From: Jesse Barnes [mailto:[email protected]]
Sent: Saturday, March 21, 2015 3:17 AM
To: He, Shuang; Gao, Ethan; [email protected]; Hoath, Nicholas
Subject: Re: [Intel-gfx] [PATCH] drm/i195/bxt: Add A1 stepping for Broxton

Quoted 1 line · On 03/20/2015 10:14 AM, [email protected] wrote:
Tested-by PRC QA PRTS (Patch Regression Test System Contact:

[email protected])

Quoted 10 lines

Task id: 6016 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -2 274/274 272/274

ILK                                  303/303              303/303
SNB                                  303/303              303/303
IVB                 -2              342/342              340/342
BYT                                  287/287              287/287
HSW                                  362/362              362/362
BDW                                  308/308              308/308
Quoted 3 lines

-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gem_userptr_blits_minor-sync-interruptible PASS(2)

DMESG_WARN(1)PASS(1)

Quoted 2 lines

*PNV igt_gen3_render_linear_blits PASS(3) CRASH(1)PASS(1)
IVB igt_gem_pwrite_pread_snooped-copy-performance

DMESG_WARN(1)PASS(3) DMESG_WARN(1)PASS(1)

Quoted 1 line

*IVB igt_gem_storedw_batches_loop_secure-dispatch PASS(3)

DMESG_WARN(1)PASS(1)

Quoted 1 line

Note: You need to pay more attention to line start with '*'

Quoted 8 lines

I wonder what these warnings actually are... I've been seeing the userptr_blits tests on PNV trigger warnings in a lot of PRTS results lately, and it must be intermittent since this patch would have no effect on PNV.

Shuang, when do you think you'll be able to attach the dmesg snippets from failures like these to the msgs? Would make things easier to triage at least.

[He, Shuang] yeah, it makes sense, we will see how we can improve this

Quoted 4 lines

And do we have a bug open? I don't see this particular issue listed in the igt failures at bugs.fdo, but it could be a dupe with some other warning there.

[He, Shuang] I'll forward this to QA guys working on kernel validation, see if they already have this tracked

Thanks
--Shuang

Quoted 3 lines

Thanks,
Jesse

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Nick Hoath
Quoted 12 lines · Nick Hoath

This stepping isn't listed separately in the specs, so needs confirmation.

---
 drivers/gpu/drm/i915/i915_drv.h | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.h +0 -0
index eec271a..68fb41a 100644

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2332

Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
 #define SKL_REVID_E0		(0x4)
 
 #define BXT_REVID_A0		(0x0)
+#define BXT_REVID_A1		(0x1)

The above mapping is for the SOC RevID, but I think for all our purposes (WAs) we should check the GT/Display RevID. The A1 GT/Display RevID doesn't seem to exist, only A0 is defined with all of 0,1,2 RevIDs mapping to A0.

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2335

Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
 #define BXT_REVID_B0		(0x3)
 #define BXT_REVID_C0		(0x6)
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#5 lore raw
Quoted 15 lines · Imre
Quoted 14 lines · Nick Hoath

This stepping isn't listed separately in the specs, so needs confirmation.

---
  drivers/gpu/drm/i915/i915_drv.h | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.h +0 -0
index eec271a..68fb41a 100644
@@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
  #define SKL_REVID_E0		(0x4)
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2332

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +1 -0
  #define BXT_REVID_A0		(0x0)
+#define BXT_REVID_A1		(0x1)

The above mapping is for the SOC RevID, but I think for all our purposes (WAs) we should check the GT/Display RevID. The A1 GT/Display RevID doesn't seem to exist, only A0 is defined with all of 0,1,2 RevIDs mapping to A0.

We use the GT Device2 Revision ID for these comparisons, which does change on each SoC revision. This may map to A0 GT stepping for all the Ax SoCs, according to the specs. However, as this is a naming convention that doesn't affect the code, I suggest we stick to what I have in this patch even if it doesn't 100% reflect what's in the specs.

Quoted 6 lines

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2335

Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
  #define BXT_REVID_B0		(0x3)
  #define BXT_REVID_C0		(0x6)
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 24 lines · Nick Hoath
Quoted 15 lines · Imre
Quoted 14 lines · Nick Hoath

This stepping isn't listed separately in the specs, so needs confirmation.

---
  drivers/gpu/drm/i915/i915_drv.h | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.h +0 -0
index eec271a..68fb41a 100644
@@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
  #define SKL_REVID_E0		(0x4)
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2332

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +1 -0
  #define BXT_REVID_A0		(0x0)
+#define BXT_REVID_A1		(0x1)

The above mapping is for the SOC RevID, but I think for all our purposes (WAs) we should check the GT/Display RevID. The A1 GT/Display RevID doesn't seem to exist, only A0 is defined with all of 0,1,2 RevIDs mapping to A0.

Quoted 5 lines

We use the GT Device2 Revision ID for these comparisons, which does change on each SoC revision. This may map to A0 GT stepping for all the Ax SoCs, according to the specs. However, as this is a naming convention that doesn't affect the code, I suggest we stick to what I have in this patch even if it doesn't 100% reflect what's in the specs.

Not sure about this, as I understand all the workarounds are marked with the GT stepping not the SOC stepping, even though the latter is more fine-grained. Is there any workarounds for A1? If not I'd suggest adding this macro only when we need it.

--Imre

Quoted 6 lines
Quoted 5 lines

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2335

Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
  #define BXT_REVID_B0		(0x3)
  #define BXT_REVID_C0		(0x6)
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#7 lore raw
Quoted 31 lines · Imre
Quoted 24 lines · Nick Hoath
Quoted 15 lines · Imre
Quoted 14 lines · Nick Hoath

This stepping isn't listed separately in the specs, so needs confirmation.

---
   drivers/gpu/drm/i915/i915_drv.h | 1 +
   1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.h +0 -0
index eec271a..68fb41a 100644
@@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
   #define SKL_REVID_E0		(0x4)
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_drv.h struct drm_i915_cmd_table { · line 2332

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +1 -0
   #define BXT_REVID_A0		(0x0)
+#define BXT_REVID_A1		(0x1)

The above mapping is for the SOC RevID, but I think for all our purposes (WAs) we should check the GT/Display RevID. The A1 GT/Display RevID doesn't seem to exist, only A0 is defined with all of 0,1,2 RevIDs mapping to A0.

Quoted 5 lines

We use the GT Device2 Revision ID for these comparisons, which does change on each SoC revision. This may map to A0 GT stepping for all the Ax SoCs, according to the specs. However, as this is a naming convention that doesn't affect the code, I suggest we stick to what I have in this patch even if it doesn't 100% reflect what's in the specs.

Quoted 4 lines

Not sure about this, as I understand all the workarounds are marked with the GT stepping not the SOC stepping, even though the latter is more fine-grained. Is there any workarounds for A1? If not I'd suggest adding this macro only when we need it.

Agreed, consider this patch currently N/A.

Quoted 11 lines

--Imre

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
   #define BXT_REVID_B0		(0x3)
   #define BXT_REVID_C0		(0x6)
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx