add support for Freescale's MMA8653FC 10 bit accelerometer
Subsystems (4)
PATCH v4 1/1 add support for Freescale's MMA8653FC 10 bit accelerometer
From: Martin Kepplinger <[email protected]>
The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.
Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the poll() system call.
The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.
This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.
---
patch revision history
......................
v4 changes DT propery names, adds a missing interrupt source and removes
the DT option to set interrupt line active high due to unsuccesful testing
v3 moves the driver from drivers/input/misc to drivers/misc
v2 corrects licensing and commit messages and adds appropriate recipients
.../testing/sysfs-bus-i2c-devices-fsl-mma8653fc | 39 + .../devicetree/bindings/misc/fsl,mma8653fc.txt | 102 +++ MAINTAINERS | 5 + drivers/misc/Kconfig | 11 + drivers/misc/Makefile | 1 + drivers/misc/mma8653fc.c | 897 +++++++++++++++++++++ 6 files changed, 1055 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt create mode 100644 drivers/misc/mma8653fc.c
Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc new file +39 -0
@@ -0,0 +1,39 @@ +What: /sys/bus/i2c/drivers/mma8653fc/*/standby +Date: March 2015 +Contact: Martin Kepplinger <[email protected]> +Description: + Write 0 to this in order to turn on the device, and 1 to turn + it off. Read to see if it is turned on or off. + + +What: /sys/bus/i2c/drivers/mma8653fc/*/currentmode +Date: March 2015 +Contact: Martin Kepplinger <[email protected]> +Description: + Reading this provides the current state of the device, read + directly from a register. This can be "standby", "wake" or + "sleep". + + +What: /sys/bus/i2c/drivers/mma8653fc/*/position +Date: March 2015 +Contact: Martin Kepplinger <[email protected]> +Description: + Read only. Without interrupts enabled gets current position + values by reading. Poll "position" with interrupt conditions + set, to get notified; see Documentation/.../fsl,mma8653fc.txt + + position file format: + "x y z [landscape/portrait status] [front/back status]" + + x y z values: + in mg + landscape/portrait status char: + r landscape right + d portrait down + u portrait up + l landscape left + front/back status char: + f front facing + b back facing +
Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt new file +102 -0
102 lines not on this page · raw message
MAINTAINERS +5 -0
@@ -4104,6 +4104,11 @@ S: Maintained F: include/linux/platform_data/video-imxfb.h F: drivers/video/fbdev/imxfb.c +FREESCALE MMA8653FC ACCELEROMETER I2C DRIVER +M: Martin Kepplinger <[email protected]> +S: Maintained +F: drivers/input/misc/mma8653fc.c + FREESCALE QUAD SPI DRIVER M: Han Xu <[email protected]> L: [email protected]
drivers/misc/Kconfig +11 -0
@@ -324,6 +324,17 @@ config ISL29020 This driver can also be built as a module. If so, the module will be called isl29020. +config MMA8653FC + tristate "MMA8653FC - Freescale's 3-Axis, 10-bit Digital Accelerometer" + depends on I2C + default n + help + Say Y here if you want to support Freescale's MMA8653FC Accelerometer + through I2C interface. + + To compile this driver as a module, choose M here: the + module will be called mma8653fc. + config SENSORS_TSL2550 tristate "Taos TSL2550 ambient light sensor" depends on I2C && SYSFS
drivers/misc/Makefile +1 -0
@@ -17,6 +17,7 @@ obj-$(CONFIG_ICS932S401) += ics932s401.o obj-$(CONFIG_LKDTM) += lkdtm.o obj-$(CONFIG_TIFM_CORE) += tifm_core.o obj-$(CONFIG_TIFM_7XX1) += tifm_7xx1.o +obj-$(CONFIG_MMA8653FC) += mma8653fc.o obj-$(CONFIG_PHANTOM) += phantom.o obj-$(CONFIG_SENSORS_BH1780) += bh1780gli.o obj-$(CONFIG_SENSORS_BH1770) += bh1770glc.o
drivers/misc/mma8653fc.c new file +897 -0
897 lines not on this page · raw message
Signature · 1 line
2.1.4
Quoted 23 lines · Martin Kepplinger
From: Martin Kepplinger <[email protected]>
The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.
Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the
poll()system call.The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.
This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.
Signed-off-by Martin Kepplinger <[email protected]>Signed-off-by Christoph Muellner <[email protected]>---
(...)
Quoted 6 lines
drivers/misc/mma8653fc.c new file +6
-0+static int mma8653fc_i2c_probe (struct i2c_client *client, +const struct i2c_device_id *id) +{ +struct mma8653fc *mma; +const struct mma8653fc_pdata *pdata; +int err;
drivers/misc/mma8653fc.c line 643
Quoted 10 lines
drivers/misc/mma8653fc.c new file +10
-0+u8 byte; + + err =i2c_check_functionality (client->adapter, +I2C_FUNC_SMBUS_BYTE_DATA ); +if (!err) { +dev_err (&client->dev,"SMBUS Byte Data not Supported\n" ); +return -EIO ; + } + + mma =kzalloc (sizeof (*mma),GFP_KERNEL );
Why not devm_* API..?
drivers/misc/mma8653fc.c line 654
Quoted 11 lines
drivers/misc/mma8653fc.c new file +11
-0+if (!mma) { + err = -ENOMEM ; + goto err_out; + } + + pdata =dev_get_platdata (&client->dev); +if (!pdata) { + pdata =mma8653fc_probe_dt (&client->dev); +if (IS_ERR (pdata)) { + err =PTR_ERR (pdata); +pr_err ("pdata from DT failed\n" );
Use dev_err() instead of pr_err()..
Quoted 21 lines
drivers/misc/mma8653fc.c new file +21
-0+ goto err_free_mem; + } + } + mma->pdata = *pdata; + pdata = &mma->pdata; + mma->client = client; + mma->read = &mma8653fc_read; + mma->write = &mma8653fc_write; + +mutex_init (&mma->mutex); + +i2c_set_clientdata (client, mma); + + err =sysfs_create_group (&client->dev.kobj, &mma8653fc_attr_group); +if (err) + goto err_free_mem; + + mma->irq =irq_of_parse_and_map (client->dev.of_node,0 ); +if (!mma->irq) { +dev_err (&client->dev,"Unable to parse or map IRQ\n" ); + goto no_irq;
drivers/misc/mma8653fc.c line 685
Quoted 10 lines
drivers/misc/mma8653fc.c new file +10
-0+ } + + err =irq_set_irq_type (mma->irq,IRQ_TYPE_EDGE_FALLING ); +if (err) { +dev_err (&client->dev,"set_irq_type failed\n" ); + goto err_free_mem; + } + + err =request_threaded_irq (mma->irq,NULL , mma8653fc_irq,IRQF_ONESHOT , +dev_name (&mma->client->dev), mma);
devm_* API..?
Quoted 137 lines
drivers/misc/mma8653fc.c new file +137
-0+if (err) { +dev_err (&client->dev,"irq %d busy?\n" , mma->irq); + goto err_free_mem; + } + +if (mma->write (mma,MMA8653FC_CTRL_REG2 ,SOFT_RESET )) + goto err_free_irq; + +__mma8653fc_disable (mma); + mma->standby = true; + +/* enable desired interrupts */ + mma->orientation ='\0' ; + mma->bafro ='\0' ; + byte =0 ; +if (pdata->int_src_data_ready) { + byte |=INT_EN_DRDY ; +dev_dbg (&client->dev,"DATA READY interrupt source enabled\n" ); + } +if (pdata->int_src_ff_mt_x || pdata->int_src_ff_mt_y || + pdata->int_src_ff_mt_z) { + byte |=INT_EN_FF_MT ; +dev_dbg (&client->dev,"FF MT interrupt source enabled\n" ); + } +if (pdata->int_src_lndprt) { +if (mma->write (mma,MMA8653FC_PL_CFG ,PL_EN )) + goto err_free_irq; + byte |=INT_EN_LNDPRT ; +dev_dbg (&client->dev,"LNDPRT interrupt source enabled\n" ); + } +if (pdata->int_src_aslp) { + byte |=INT_EN_ASLP ; +dev_dbg (&client->dev,"ASLP interrupt source enabled\n" ); + } +if (mma->write (mma,MMA8653FC_CTRL_REG4 , byte)) + goto err_free_irq; + +/* force everything to line 1 */ +if (pdata->int1) { +if (mma->write (mma,MMA8653FC_CTRL_REG5 , + (INT_CFG_ASLP |INT_CFG_LNDPRT | +INT_CFG_FF_MT |INT_CFG_DRDY ))) + goto err_free_irq; +dev_dbg (&client->dev,"using interrupt line 1\n" ); + } +no_irq: +/* range mode */ + byte = mma->read (mma,MMA8653FC_XYZ_DATA_CFG ); + byte &= ~RANGE_MASK ; +switch (pdata->range) { +case DYN_RANGE_2G : + byte |=RANGE2G ; +dev_dbg (&client->dev,"use 2g range\n" ); +break ; +case DYN_RANGE_4G : + byte |=RANGE4G ; +dev_dbg (&client->dev,"use 4g range\n" ); +break ; +case DYN_RANGE_8G : + byte |=RANGE8G ; +dev_dbg (&client->dev,"use 8g range\n" ); +break ; +default : +dev_err (&client->dev,"wrong range mode value\n" ); + goto err_free_irq; + } +if (mma->write (mma,MMA8653FC_XYZ_DATA_CFG , byte)) + goto err_free_irq; + +/* data calibration offsets */ +if (pdata->x_axis_offset) { +if (mma->write (mma,MMA8653FC_OFF_X , pdata->x_axis_offset)) + goto err_free_irq; + } +if (pdata->y_axis_offset) { +if (mma->write (mma,MMA8653FC_OFF_Y , pdata->y_axis_offset)) + goto err_free_irq; + } +if (pdata->z_axis_offset) { +if (mma->write (mma,MMA8653FC_OFF_Z , pdata->z_axis_offset)) + goto err_free_irq; + } + +/* if autosleep, wake on both landscape and motion changes */ +if (pdata->auto_wake_sleep) { + byte =0 ; + byte |=WAKE_LNDPRT ; + byte |=WAKE_FF_MT ; +if (mma->write (mma,MMA8653FC_CTRL_REG3 , byte)) + goto err_free_irq; +if (mma->write (mma,MMA8653FC_CTRL_REG2 ,SLPE )) + goto err_free_irq; +dev_dbg (&client->dev,"auto sleep enabled\n" ); + } + +/* data rates */ + byte =0 ; + byte = mma->read (mma,MMA8653FC_CTRL_REG1 ); +if (byte <0 ) + goto err_free_irq; + byte &= ~ODR_MASK ; + byte |=ODR_DEFAULT ; + byte &= ~ASLP_RATE_MASK ; + byte |=ASLP_RATE_DEFAULT ; +if (mma->write (mma,MMA8653FC_CTRL_REG1 , byte)) + goto err_free_irq; + +/* freefall / motion config */ + byte =0 ; +if (pdata->motion_mode) { + byte |=FF_MT_CFG_OAE ; +dev_dbg (&client->dev,"detect motion instead of freefall\n" ); + } + byte |=FF_MT_CFG_ELE ; +if (pdata->int_src_ff_mt_x) + byte |=FF_MT_CFG_XEFE ; +if (pdata->int_src_ff_mt_y) + byte |=FF_MT_CFG_YEFE ; +if (pdata->int_src_ff_mt_z) + byte |=FF_MT_CFG_ZEFE ; +if (mma->write (mma,MMA8653FC_FF_MT_CFG , byte)) + goto err_free_irq; + +if (pdata->freefall_motion_thr) { +if (mma->write (mma,MMA8653FC_FF_MT_THS , + pdata->freefall_motion_thr)) + goto err_free_irq; +/* calculate back to mg */ +dev_dbg (&client->dev,"threshold set to %dmg\n" , + (63 * pdata->freefall_motion_thr) -1 ); + } + + byte = mma->read (mma,MMA8653FC_WHO_AM_I ); +if (byte !=MMA8653FC_DEVICE_ID ) { +dev_err (&client->dev,"wrong device for driver\n" ); + goto err_free_irq; + }
drivers/misc/mma8653fc.c line 832
Quoted 10 lines
drivers/misc/mma8653fc.c new file +10
-0+dev_info (&client->dev, +"accelerometer driver loaded. device id %x\n" , byte); + +return 0 ; + + err_free_irq: +if (mma->irq) +free_irq (mma->irq, mma); + err_free_mem: +kfree (mma);
If we use devm_* API's above steps are not required
drivers/misc/mma8653fc.c line 843
Quoted 11 lines
+
err_out:drivers/misc/mma8653fc.c new file +10
-0+return err; +} + +static int mma8653fc_remove (struct i2c_client *client) +{ +struct mma8653fc *mma =i2c_get_clientdata (client); + +free_irq (mma->irq, mma); +dev_dbg (&client->dev,"unregistered accelerometer\n" ); +kfree (mma);
same as above..
Signature · 1 line
Varka Bhadram
Am 2015-03-20 um 12:31 schrieb Varka Bhadram:
Quoted 3 lines · Martin Kepplinger
Quoted 2 lines
From: Martin Kepplinger <[email protected]>
( ...)
Quoted 10 lines
drivers/misc/mma8653fc.c line 832
Quoted 7 lines
drivers/misc/mma8653fc.c new file +7
-0+return 0 ; + + err_free_irq: +if (mma->irq) +free_irq (mma->irq, mma); + err_free_mem: +kfree (mma);If we use devm_* API's above steps are not required
Quoted 14 lines
drivers/misc/mma8653fc.c line 843
Quoted 11 lines
+
err_out:drivers/misc/mma8653fc.c new file +10
-0+return err; +} + +static int mma8653fc_remove (struct i2c_client *client) +{ +struct mma8653fc *mma =i2c_get_clientdata (client); + +free_irq (mma->irq, mma); +dev_dbg (&client->dev,"unregistered accelerometer\n" ); +kfree (mma);same as above..
thanks!