Skip to contentSkip to conversation

ufs: return correct errno for write_inode()

PATCH New Taesoo Kim 1 participant 1 message Mar 20, 2015

lore
Share & tools
lore

Taesoo Kim

author
#0 lore raw

PATCH 1/1 ufs: return correct errno for write_inode()

Instead of -1, properly return -EIO upon write_inode() error, similar/consistant to the rest of filesystems.

---
 fs/ufs/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ufs/inode.c +2 -2
index be7d42c..9f910d8 100644
@@ -836,13 +836,13 @@ static int ufs_update_inode(struct inode * inode, int do_sync)
 	if (inode->i_ino < UFS_ROOTINO ||
 	    inode->i_ino > (uspi->s_ncg * uspi->s_ipg)) {
 		ufs_warning (sb, "ufs_read_inode", "bad inode number (%lu)\n", inode->i_ino);
-		return -1;
+		return -EIO;
 	}
 
 	bh = sb_bread(sb, ufs_inotofsba(inode->i_ino));
 	if (!bh) {
 		ufs_warning (sb, "ufs_read_inode", "unable to read inode %lu\n", inode->i_ino);
-		return -1;
+		return -EIO;
 	}
 	if (uspi->fs_magic == UFS2_MAGIC) {
 		struct ufs2_inode *ufs2_inode = (struct ufs2_inode *)bh->b_data;
Signature · 1 line
2.3.3