Skip to contentSkip to conversation

net: dsa: make NET_DSA manually selectable from the config

PATCH Applied Mathieu Olivari 5 participants 5 messages Mar 21, 2015 – Mar 22, 2015

Subsystems (3)
Networking Network drivers Networking DSA
lore
Share & tools
lore

Mathieu Olivari

author
#0 lore raw

PATCH 1/1 net: dsa: make NET_DSA manually selectable from the config

Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers depend on NET_DSA rather than selecting them. However, as the only way to select this option was to actually select a driver, it made DSA impossible to enable at all.

This patch adds an explicit entry which the user will have to enable prior selecting a driver.

Signed-off-by Mathieu Olivari <[email protected]>
---
 net/dsa/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
net/dsa/Kconfig +4 -1
index 087e654..4f3cce1 100644
@@ -5,9 +5,12 @@ config HAVE_NET_DSA
 # Drivers must select NET_DSA and the appropriate tagging format
 
 config NET_DSA
-	tristate
+	tristate "Distributed Switch Architecture"
 	depends on HAVE_NET_DSA && NET_SWITCHDEV
 	select PHYLIB
+	---help---
+	  Say Y if you want to enable support for the hardware switches supported
+	  by the Distributed Switch Architecture.
 
 if NET_DSA
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Mathieu Olivari

Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers depend on NET_DSA rather than selecting them. However, as the only way to select this option was to actually select a driver, it made DSA impossible to enable at all.

This patch adds an explicit entry which the user will have to enable prior selecting a driver.

Fixes bd76a116707b ("dsa: change "select" to "depends on" for NET_SWITCHDEV and for NET_DSA")
Quoted 1 line
Signed-off-by Mathieu Olivari <[email protected]>

Andrew found the same problem yesterday and was about to submit the same patch...

Reviewed-by Guenter Roeck <[email protected]>
Quoted 23 lines
---
  net/dsa/Kconfig | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
net/dsa/Kconfig +4 -1
index 087e654..4f3cce1 100644
@@ -5,9 +5,12 @@ config HAVE_NET_DSA
  # Drivers must select NET_DSA and the appropriate tagging format
 
  config NET_DSA
-	tristate
+	tristate "Distributed Switch Architecture"
  	depends on HAVE_NET_DSA && NET_SWITCHDEV
  	select PHYLIB
+	---help---
+	  Say Y if you want to enable support for the hardware switches supported
+	  by the Distributed Switch Architecture.
 
  if NET_DSA
maintainer Applied
#2 lore raw
In reply to Mathieu Olivari

From: Mathieu Olivari <[email protected]>
Date: Fri, 20 Mar 2015 18:31:03 -0700

Quoted 9 lines

Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers depend on NET_DSA rather than selecting them. However, as the only way to select this option was to actually select a driver, it made DSA impossible to enable at all.

This patch adds an explicit entry which the user will have to enable prior selecting a driver.

Signed-off-by Mathieu Olivari <[email protected]>

Applied.

maintainer
#3 lore raw
In reply to Mathieu Olivari
Quoted 9 lines · Mathieu Olivari

Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers depend on NET_DSA rather than selecting them. However, as the only way to select this option was to actually select a driver, it made DSA impossible to enable at all.

This patch adds an explicit entry which the user will have to enable prior selecting a driver.

Signed-off-by Mathieu Olivari <[email protected]>

A bit late, but

Review-by Andrew Lunn <[email protected]>

Andrew

Quoted 29 lines
---
 net/dsa/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
net/dsa/Kconfig +4 -1
index 087e654..4f3cce1 100644
@@ -5,9 +5,12 @@ config HAVE_NET_DSA
 # Drivers must select NET_DSA and the appropriate tagging format
 
 config NET_DSA
-	tristate
+	tristate "Distributed Switch Architecture"
 	depends on HAVE_NET_DSA && NET_SWITCHDEV
 	select PHYLIB
+	---help---
+	  Say Y if you want to enable support for the hardware switches supported
+	  by the Distributed Switch Architecture.
 
 if NET_DSA
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
In reply to Mathieu Olivari

Hello.

Quoted 1 line · Mathieu Olivari

Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers

s/Change/Commit/, perhaps?
And please also specify that commit's summary line in parens.

Quoted 17 lines

depend on NET_DSA rather than selecting them. However, as the only way to select this option was to actually select a driver, it made DSA impossible to enable at all.

This patch adds an explicit entry which the user will have to enable prior selecting a driver.

Signed-off-by Mathieu Olivari <[email protected]>
---
  net/dsa/Kconfig | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
net/dsa/Kconfig +0 -0
index 087e654..4f3cce1 100644

net/dsa/Kconfig config HAVE_NET_DSA · line 11

Quoted 8 lines
net/dsa/Kconfig +2 -1
@@ -5,9 +5,12 @@ config HAVE_NET_DSA
  # Drivers must select NET_DSA and the appropriate tagging format
 
  config NET_DSA
-	tristate
+	tristate "Distributed Switch Architecture"
  	depends on HAVE_NET_DSA && NET_SWITCHDEV
  	select PHYLIB
+	---help---

Hm, why not just help?

WBR, Sergei