Skip to contentSkip to conversation

Net: ethernet: rocker: fixed a space coding style issue

PATCH In review Andrei Maresu 4 participants 4 messages Mar 21, 2015 – Mar 23, 2015

Subsystems (3)
Networking Network drivers Rocker driver
lore
Share & tools
lore

Andrei Maresu

author
#0 lore raw

PATCH 1/1 Net: ethernet: rocker: fixed a space coding style issue

Fixed a space coding style issue found by checkpatch.pl in rocker.c

Signed-off-by Andrei Maresu <[email protected]>
---
 drivers/net/ethernet/rocker/rocker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/rocker/rocker.c +1 -1
index 9fb6948..d364b12 100644
@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
 static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
 				       void *ptr)
 {
-	desc_info->desc->cookie = (uintptr_t) ptr;
+	desc_info->desc->cookie = (uintptr_t)ptr;
 }
 
 static struct rocker_desc_info *
Signature · 1 line
1.9.1
maintainer
#2 lore raw
In reply to Andrei Maresu
Quoted 12 lines · Sat, Mar 21, 2015 at 07:02:40PM CET, [email protected] wrote:

Fixed a space coding style issue found by checkpatch.pl in rocker.c

Signed-off-by Andrei Maresu <[email protected]>

---
drivers/net/ethernet/rocker/rocker.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/rocker/rocker.c +0 -0
index 9fb6948..d364b12 100644

drivers/net/ethernet/rocker/rocker.c static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info) · line 815

Quoted 5 lines
drivers/net/ethernet/rocker/rocker.c +1 -1
@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
 static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
 				       void *ptr)
 {
-	desc_info->desc->cookie = (uintptr_t) ptr;
+	desc_info->desc->cookie = (uintptr_t)ptr;

Checkpatch does not mark this as an error, not even as a warning:
"CHECK: No space is necessary after a cast". I personally like the notation with space better.

Quoted 10 lines
drivers/net/ethernet/rocker/rocker.c +0 -0
 }

static struct rocker_desc_info *

Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#3 lore raw

From: Jiri Pirko <[email protected]>
Date: Mon, 23 Mar 2015 14:18:39 +0100

Quoted 8 lines
Quoted 7 lines · Sat, Mar 21, 2015 at 07:02:40PM CET, [email protected] wrote:

Fixed a space coding style issue found by checkpatch.pl in rocker.c

Signed-off-by Andrei Maresu <[email protected]>

---
drivers/net/ethernet/rocker/rocker.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

drivers/net/ethernet/rocker/rocker.c static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info) · line 815

Quoted 10 lines
drivers/net/ethernet/rocker/rocker.c +1 -1
index 9fb6948..d364b12 100644
@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
 static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
 				       void *ptr)
 {
-	desc_info->desc->cookie = (uintptr_t) ptr;
+	desc_info->desc->cookie = (uintptr_t)ptr;

Checkpatch does not mark this as an error, not even as a warning:
"CHECK: No space is necessary after a cast". I personally like the notation with space better.

Me too, I'm not applying this.