drivers/of: Add empty ranges quirk for PA-Semi
PATCH 1/1 drivers/of: Add empty ranges quirk for PA-Semi
The "sdc" node is missing the ranges property, it needs to be treated as having an empty one otherwise translation fails for its children.
--- drivers/of/address.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/of/address.c +8 -3
@@ -450,12 +450,17 @@ static struct of_bus *of_match_bus(struct device_node *np)return NULL ; } -static int of_empty_ranges_quirk (void ) +static int of_empty_ranges_quirk (struct device_node *np) {if (IS_ENABLED (CONFIG_PPC )) { -/* To save cycles, we cache the result */ +/* To save cycles, we cache the result for global "Mac" setting */ static int quirk_state =-1 ; +/* PA-SEMI sdc DT bug */ +if (of_device_is_compatible (np,"1682m-sdc" )) +return true; + +/* Make quirk cached */ if (quirk_state <0 ) quirk_state = of_machine_is_compatible("Power Macintosh") ||
@@ -490,7 +495,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,* This code is only enabled on powerpc. --gcl */ ranges =of_get_property (parent, rprop, &rlen); -if (ranges ==NULL && !of_empty_ranges_quirk ()) { +if (ranges ==NULL && !of_empty_ranges_quirk (parent)) {pr_debug ("OF: no ranges; cannot translate\n" );return 1 ; }
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1427080598.4770.214.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org
Quoted 5 lines · Benjamin Herrenschmidt
The "sdc" node is missing the ranges property, it needs to be treated as having an empty one otherwise translation fails for its children.
Tested-by Steven Rostedt <[email protected]>Signed-off-by Benjamin Herrenschmidt <[email protected]>
Which went into 3.18-rc6, and was CC'ed to stable. So this should probably also go to stable no?
cheers
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20150323035004.2D6B9140134-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Quoted 11 lines · Michael Ellerman
Quoted 5 lines · Benjamin Herrenschmidt
The "sdc" node is missing the ranges property, it needs to be treated as having an empty one otherwise translation fails for its children.
Tested-by Steven Rostedt <[email protected]>Signed-off-by Benjamin Herrenschmidt <[email protected]>Fixes 746c9e9f92dd ("of/base: Fix PowerPC address parsing hack")Which went into 3.18-rc6, and was CC'ed to stable. So this should probably also go to stable no?
Sure, go for it.
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1427083595.4770.221.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org
Grant Likely
AppliedQuoted 8 lines · Benjamin Herrenschmidt
Quoted 7 lines · Michael Ellerman
Quoted 5 lines · Benjamin Herrenschmidt
The "sdc" node is missing the ranges property, it needs to be treated as having an empty one otherwise translation fails for its children.
Tested-by Steven Rostedt <[email protected]>Signed-off-by Benjamin Herrenschmidt <[email protected]>
Quoted 6 lines
Quoted 4 lines
Fixes 746c9e9f92dd ("of/base: Fix PowerPC address parsing hack")Which went into 3.18-rc6, and was CC'ed to stable. So this should probably also go to stable no?
Sure, go for it.
Applied, thanks.
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html