Skip to contentSkip to conversation

NVMe: Initialize device list head before starting

PATCH New Keith Busch 2 participants 2 messages Mar 23, 2015

Subsystems (2)
Block layer NVMe
lore
Share & tools
lore

Keith Busch

author
#0 lore raw

PATCH 1/1 NVMe: Initialize device list head before starting

Driver recovery requires the device's list node to have been initialized.

Fixes https://lkml.org/lkml/2015/3/22/262
Reported-by Steven Noonan <steven at uplinklabs.net>
Signed-off-by Keith Busch <keith.busch at intel.com>
Cc Matthew Wilcox <willy at linux.intel.com>
Cc Jens Axboe <axboe at fb.com>
---
 drivers/block/nvme-core.c |    1 +
 1 file changed, 1 insertion(+)
drivers/block/nvme-core.c +1 -0
index ceb32dd..e23be20 100644
@@ -3003,6 +3003,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	}
 	get_device(dev->device);
 
+	INIT_LIST_HEAD(&dev->node);
 	INIT_WORK(&dev->probe_work, nvme_async_probe);
 	schedule_work(&dev->probe_work);
 	return 0;
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 NVMe: Initialize device list head before starting

Quoted 8 lines · Keith Busch

Driver recovery requires the device's list node to have been initialized.

Fixes https://lkml.org/lkml/2015/3/22/262
Reported-by Steven Noonan <steven at uplinklabs.net>
Signed-off-by Keith Busch <keith.busch at intel.com>
Cc Matthew Wilcox <willy at linux.intel.com>
Cc Jens Axboe <axboe at fb.com>

I have applied this for the current series.

Signature · 1 line
Jens Axboe