checkpatch: Improve return negative errno check

PATCH New Joe Perches 1 participant 1 message Mar 23, 2015 Checkpatch

lore

Share & tools

lore

Joe Perches

author maintainer

2015-03-23 19:41 UTC #0 lore raw

PATCH 1/1 checkpatch: Improve return negative errno check

Add a few conditions to the test to find

	return (ERRNO);

Make the output message a bit less cryptic too.

Signed-off-by Joe Perches <[email protected]>

---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

scripts/checkpatch.pl +3 -3

index 5748c35..45babf2 100755
@@ -4009,12 +4009,12 @@ sub process {
 			}
 		}
 
-# Return of what appears to be an errno should normally be -'ve
-		if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
+# Return of what appears to be an errno should normally be negative
+		if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
 			my $name = $1;
 			if ($name ne 'EOF' && $name ne 'ERROR') {
 				WARN("USE_NEGATIVE_ERRNO",
-				     "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
+				     "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
 			}
 		}