Skip to contentSkip to conversation

arm64: dts: Add Qualcomm APQ8016 SBC evaluation board dts

PATCH In review Kumar Gala 2 participants 6 messages Mar 23, 2015 – Apr 3, 2015

Subsystems (3)
lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 arm64: dts: Add Qualcomm APQ8016 SBC evaluation board dts

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

---
 arch/arm64/boot/dts/qcom/Makefile         |  2 +-
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts  | 22 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 33 +++++++++++++++++++++++++++++++
 3 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dts
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -1
index 360ec4c..8e94af6 100644
@@ -1,4 +1,4 @@
-dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
 
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
arch/arm64/boot/dts/qcom/apq8016-sbc.dts new file +22 -0
new file mode 100644
index 0000000..3c563e7
@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2015, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/arm/qcom-ids.h>
+#include "apq8016-sbc.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. APQ 8016 SBC";
+	compatible = "qcom,apq8016-sbc", "qcom,apq8016", "qcom,sbc";
+};
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi new file +33 -0
new file mode 100644
index 0000000..703a4f1
@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2015, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include "msm8916.dtsi"
+
+/ {
+	aliases {
+		serial0 = &blsp1_uart2;
+	};
+
+	chosen {
+		stdout-path = "serial0";
+	};
+
+	soc {
+		serial at 78b0000 {
+			status = "okay";
+			pinctrl-names = "default", "sleep";
+			pinctrl-0 = <&blsp1_uart2_default>;
+			pinctrl-1 = <&blsp1_uart2_sleep>;
+		};
+	};
+};
Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw
Quoted 4 lines · Kumar Gala

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

Hi,

Patch applied but see comment below.

Quoted 26 lines
---
 arch/arm64/boot/dts/qcom/Makefile         |  2 +-
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts  | 22 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 33 +++++++++++++++++++++++++++++++
 3 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dts
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -1
index 360ec4c..8e94af6 100644
@@ -1,4 +1,4 @@
-dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
 
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
arch/arm64/boot/dts/qcom/apq8016-sbc.dts new file +2 -0
new file mode 100644
index 0000000..3c563e7
@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2015, The Linux Foundation. All rights reserved.

arch/arm64/boot/dts/qcom/apq8016-sbc.dts line 12

Quoted 10 lines
arch/arm64/boot/dts/qcom/apq8016-sbc.dts new file +10 -0
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */

Your 32-bit DTS:es lack copyright headers alltogether, and this is GPLv2 only. Given the movement to use dual GPL/X11 on DTS contents, it might be a good idea to kick off that process with your legal team if you haven't already. Please follow up with copyright revisions as appropriate, on both 32 and 64-bit.

-Olof

#2 lore raw
Quoted 9 lines · Olof Johansson
Quoted 4 lines · Kumar Gala

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

Hi,

Patch applied but see comment below.

You both sent us the patch and a pull request with this patch in it. Please only send patches to arm at kernel.org that you intend for us to apply.

-Olof

#3 lore raw
Quoted 7 lines · Olof Johansson
Quoted 6 lines · Olof Johansson
Quoted 4 lines · Kumar Gala

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

Quoted 7 lines
Quoted 3 lines

Hi,

Patch applied but see comment below.

You both sent us the patch and a pull request with this patch in it. Please only send patches to arm at kernel.org that you intend for us to apply.

Uh, need more coffee, please ignore. I got confused since your patch didn't apply cleanly due to the dts/qcom directory creation.

-Olof

author
#4 lore raw
Quoted 16 lines · Olof Johansson
Quoted 7 lines · Olof Johansson
Quoted 6 lines · Olof Johansson
Quoted 4 lines · Kumar Gala

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

Quoted 7 lines
Quoted 3 lines

Hi,

Patch applied but see comment below.

You both sent us the patch and a pull request with this patch in it. Please only send patches to arm at kernel.org that you intend for us to apply.

Quoted 5 lines

Uh, need more coffee, please ignore. I got confused since your patch didn't apply cleanly due to the dts/qcom directory creation.

-Olof

Ok, but this should be part of the 'qcom-dt-for-4.1? so hopefully you will end up pulling all of that in as well

- k

Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#5 lore raw
Quoted 19 lines · Kumar Gala
Quoted 16 lines · Olof Johansson
Quoted 14 lines · Olof Johansson
Quoted 9 lines · Olof Johansson
Quoted 4 lines · Kumar Gala

Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c.

Hi,

Patch applied but see comment below.

You both sent us the patch and a pull request with this patch in it. Please only send patches to arm at kernel.org that you intend for us to apply.

Quoted 7 lines
Quoted 5 lines

Uh, need more coffee, please ignore. I got confused since your patch didn't apply cleanly due to the dts/qcom directory creation.

-Olof

Ok, but this should be part of the 'qcom-dt-for-4.1? so hopefully you will end up pulling all of that in as well

If you pick up a patch that you have sent us, please reply to that email with a redaction so we don't waste time dealing with it. Especially if some time has passed.

I'll get to your dt branch this afternoon.

-Olof