bfs: correct return values

PATCH New Sanidhya Kashyap 1 participant 1 message Mar 24, 2015

Share & tools

Sanidhya Kashyap

author

2015-03-24 23:11 UTC #0 lore raw

PATCH 1/1 bfs: correct return values

In case of no memory allocation, the return should be ENOMEM instead of ENOSPC. Well, for the other case, in which the buffer head is not allocated, in that case -EIO should be returned.

Signed-off-by Sanidhya Kashyap <[email protected]>

---
 fs/bfs/dir.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

fs/bfs/dir.c +2 -2

index 08063ae..7a818277 100644
@@ -86,7 +86,7 @@ static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
 
 	inode = new_inode(s);
 	if (!inode)
-		return -ENOSPC;
+		return -ENOMEM;
 	mutex_lock(&info->bfs_lock);
 	ino = find_first_zero_bit(info->si_imap, info->si_lasti + 1);
 	if (ino > info->si_lasti) {

@@ -293,7 +293,7 @@ static int bfs_add_entry(struct inode *dir, const unsigned char *name,
 	for (block = sblock; block <= eblock; block++) {
 		bh = sb_bread(dir->i_sb, block);
 		if (!bh)
-			return -ENOSPC;
+			return -EIO;
 		for (off = 0; off < BFS_BSIZE; off += BFS_DIRENT_SIZE) {
 			de = (struct bfs_dirent *)(bh->b_data + off);
 			if (!de->ino) {

Signature · 1 line

2.1.0