Skip to contentSkip to conversation

Ash Charles : mpd: ship systemd socket file

oe-commits Superseded Martin Jansa 3 participants 7 messages Mar 21, 2015 – Mar 25, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Martin Jansa

author
#1 lore raw
Quoted 5 lines · On Mon, Jan 12, 2015 at 02:36:29PM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit: c702fc4dfab0c09449bd47a04deecca5946d981f
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=c702fc4dfab0c09449bd47a04deecca5946d981f
Quoted 7 lines
Author: Ash Charles <[email protected]>
Date:   Thu Jan  8 10:58:19 2015 -0800

mpd: ship systemd socket file

As of mpd version 19.1, as systemd socket file, mpd.socket, is installed. Ship this file as part of the mpd-systemd package.

Can you please fix this issue?
mpd-0.19.1: mpd rdepends on libsmbclient, but it isn't a build dependency? [build-deps]

Quoted 28 lines
Signed-off-by Ash Charles <[email protected]>
Signed-off-by Martin Jansa <[email protected]>

---

 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -1
index 04eed0a..feec985 100644
@@ -48,7 +48,7 @@ do_install_append() {
 RPROVIDES_${PN} += "${PN}-systemd"
 RREPLACES_${PN} += "${PN}-systemd"
 RCONFLICTS_${PN} += "${PN}-systemd"
-SYSTEMD_SERVICE_${PN} = "mpd.service"
+SYSTEMD_SERVICE_${PN} = "mpd.service mpd.socket"
 
 USERADD_PACKAGES = "${PN}"
 USERADD_PARAM_${PN} = " \
Signature · 5 lines
-- 
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw

PATCH 1/1 mpd: Add build dependency on samba

Signed-off-by Ash Charles <[email protected]>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -1
index feec985..b3d88e0 100644
@@ -3,7 +3,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 HOMEPAGE ="http://www.musicpd.org"
 
-DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
+DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"
 
 SRC_URI = " \
     http://www.musicpd.org/download/${BPN}/0.19/${BP}.tar.xz \
Signature · 1 line
2.1.0
#3 lore raw

Re: [PATCH] mpd: Add build dependency on samba

meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb LICENSE = "GPLv2" · line 6

Quoted 2 lines · Ash Charles
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -1
-DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
+DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"

where is this dependency coming from ? some explanation to this would be nice. Can this be avoided ?

#4 lore raw

Re: [PATCH] mpd: Add build dependency on samba

Hi Khem,

Sorry--my commit message was rather unhelpful! I'll confess I was just trying to resolve a build warning as I don't have detailed knowledge of the package. Digging a little deeper, version 0.19 introduces smbclient which looks to be the source of the dependency of samba.

Sending a v2 with an updated commit message and packageconfig. Please let me know if you see any issues.

--Ash

Quoted 11 lines · Khem Raj

meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb LICENSE = "GPLv2" · line 6

Quoted 2 lines · Ash Charles
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -1
-DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
+DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"

where is this dependency coming from ? some explanation to this would be nice. Can this be avoided ?
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw

PATCH v2 1/1 mpd: Add build dependency on samba

In reply to Khem Raj

Version 0.19 [1], adds the smbclient plugins for storage and input so needs samba when building with the --enable-samba option.

[1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19

Signed-off-by Ash Charles <[email protected]>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
 1 file changed, 1 insertion(+)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -0
index feec985..f6152a6 100644
@@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
 PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
+PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba,samba"
 
 do_install_append() {
     install -d ${D}/${localstatedir}/lib/mpd/music
Signature · 1 line
2.1.0
author
#6 lore raw

Re: [PATCH v2] mpd: Add build dependency on samba

Quoted 15 lines · Ash Charles

Version 0.19 [1], adds the smbclient plugins for storage and input so needs samba when building with the --enable-samba option.

[1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19

Signed-off-by Ash Charles <[email protected]>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
 1 file changed, 1 insertion(+)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +0 -0
index feec985..f6152a6 100644

meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds · line 23

Quoted 4 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -0
@@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
 PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
+PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba,samba"

You don't need to repeat samba in 4th parameter.

Quoted 6 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +0 -0
 do_install_append() {
     install -d ${D}/${localstatedir}/lib/mpd/music
Signature · 1 line
2.1.0
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#7 lore raw

PATCH v3 1/1 mpd: Add build dependency on samba

Version 0.19 [1], adds the smbclient plugins for storage and input so needs samba when building with the --enable-samba option.

[1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19

Signed-off-by Ash Charles <[email protected]>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
 1 file changed, 1 insertion(+)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb +1 -0
index feec985..a5cd557 100644
@@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
 PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
+PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba"
 
 do_install_append() {
     install -d ${D}/${localstatedir}/lib/mpd/music
Signature · 1 line
2.1.0