Skip to contentSkip to conversation

ufs: missing check for block_truncate_page

PATCH New Chengyu Song 1 participant 1 message Mar 25, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ufs: missing check for block_truncate_page

block_truncate_page may fail under certain circumstances, so its result should be checked.

---
 fs/ufs/truncate.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
fs/ufs/truncate.c +6 -1
index f04f89f..8b41f07 100644
@@ -464,7 +464,12 @@ int ufs_truncate(struct inode *inode, loff_t old_i_size)
 		goto out;
 	}
 
-	block_truncate_page(inode->i_mapping, inode->i_size, ufs_getfrag_block);
+	err = block_truncate_page(inode->i_mapping, inode->i_size, ufs_getfrag_block);
+
+	if (err) {
+		i_size_write(inode, old_i_size);
+		goto out;
+	}
 
 	while (1) {
 		retry = ufs_trunc_direct(inode);
Signature · 1 line
2.1.0