Skip to contentSkip to conversation

usb: Enable LPM for USB 2.01+ full-speed devices

PATCH Superseded [email protected] 4 participants 8 messages Mar 25, 2015 – Apr 14, 2015

Subsystems (2)
USB Arm Qualcomm mailing list
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 usb: Enable LPM for USB 2.01+ full-speed devices

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Change-Id Ic055d51c02651810d3eb7141bab20a090fe8453b
Signed-off-by Rupesh Tatiya <[email protected]>
---
 drivers/usb/core/hub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/core/hub.c +1 -1
index 9ef2d2c..1ed7b5d 100644
@@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev)
 	/* USB 2.1 (and greater) devices indicate LPM support through
 	 * their USB 2.0 Extended Capabilities BOS descriptor.
 	 */
-	if (udev->speed == USB_SPEED_HIGH) {
+	if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) {
 		if (udev->bos->ext_cap &&
 			(USB_LPM_SUPPORT &
 			 le32_to_cpu(udev->bos->ext_cap->bmAttributes)))
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 6 lines · On Wed, Mar 25, 2015 at 12:23:19PM +0530, [email protected] wrote:

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

We can't take patches with this in it, as it makes no sense in a kernel changelog :(

author
#2 lore raw
Quoted 12 lines · On Wed, Mar 25, 2015 at 12:23:19PM +0530…
Quoted 6 lines

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

We can't take patches with this in it, as it makes no sense in a kernel changelog :(

Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message?

Thanks,
Rupesh

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw
Quoted 18 lines · On Wed, Apr 08, 2015 at 11:27:40AM -0000, [email protected] wrote:
Quoted 12 lines · On Wed, Mar 25, 2015 at 12:23:19PM +0530, [email protected] wrote:
Quoted 6 lines

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

We can't take patches with this in it, as it makes no sense in a kernel changelog :(

Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message?

From line is fine.

#4 lore raw
In reply to [email protected]
Quoted 8 lines
Quoted 8 lines · On Wed, Mar 25, 2015 at 12:23:19PM +0530…
Quoted 6 lines

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

Quoted 8 lines
Quoted 4 lines

We can't take patches with this in it, as it makes no sense in a kernel changelog :(

Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message?

Rupesh, Just remove below line from commit message:

Quoted 13 lines
Quoted 1 line
Quoted 1 line

Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

Thanks,
Rupesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

author
#5 lore raw

PATCH v2 1/1 usb: Enable LPM for USB 2.01+ full-speed devices

In reply to [email protected]

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Signed-off-by Rupesh Tatiya <[email protected]>
---
 drivers/usb/core/hub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/core/hub.c +1 -1
index 9ef2d2c..1ed7b5d 100644
@@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev)
 	/* USB 2.1 (and greater) devices indicate LPM support through
 	 * their USB 2.0 Extended Capabilities BOS descriptor.
 	 */
-	if (udev->speed == USB_SPEED_HIGH) {
+	if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) {
 		if (udev->bos->ext_cap &&
 			(USB_LPM_SUPPORT &
 			 le32_to_cpu(udev->bos->ext_cap->bmAttributes)))
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project
#6 lore raw
In reply to [email protected]
Quoted 4 lines · On Wed, 2015-03-25 at 12:23 +0530, [email protected].…

From: Rupesh Tatiya <[email protected]>

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Yes, they in theory can, but what happens if they are actually asked to do so? On how many devices have you tested this patch?

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#7 lore raw
Quoted 7 lines
Quoted 3 lines

USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM.

Yes, they in theory can, but what happens if they are actually asked to do so? On how many devices have you tested this patch?

I have tested this on Qualcomm USB controller, LPM works. LPM works with same controller with Microsoft Windows as well. I have looked through few Broadcom/CSR controllers, but could not find one that had USB version >= 2.01.

Thanks,
Rupesh