Skip to contentSkip to conversation

c6x: platforms: cache: Export symbol L1P_cache_block_invalidate and L1D_cache_block_writeback

PATCH In review Chen Gang 2 participants 6 messages Mar 4, 2015 – Apr 1, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Chen Gang

author
#1 lore raw

PATCH 1/1 c6x: platforms: cache: Export symbol L1P_cache_block_invalidate and L1D_cache_block_writeback

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

---
 arch/c6x/platforms/cache.c | 2 ++
 1 file changed, 2 insertions(+)
arch/c6x/platforms/cache.c +2 -0
index 86318a1..46fd2d5 100644
@@ -350,6 +350,7 @@ void L1P_cache_block_invalidate(unsigned int start, unsigned int end)
 			      (unsigned int *) end,
 			      IMCR_L1PIBAR, IMCR_L1PIWC);
 }
+EXPORT_SYMBOL(L1P_cache_block_invalidate);
 
 void L1D_cache_block_invalidate(unsigned int start, unsigned int end)
 {
@@ -371,6 +372,7 @@ void L1D_cache_block_writeback(unsigned int start, unsigned int end)
 			      (unsigned int *) end,
 			      IMCR_L1DWBAR, IMCR_L1DWWC);
 }
+EXPORT_SYMBOL(L1D_cache_block_writeback);
 
 /*
  *  L2 block operations
Signature · 1 line
1.9.3
#2 lore raw
Quoted 8 lines · Chen Gang

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

---

Thanks! I added this to the c6x tree for next merge window.

Quoted 23 lines
 arch/c6x/platforms/cache.c | 2 ++
 1 file changed, 2 insertions(+)
arch/c6x/platforms/cache.c +2 -0
index 86318a1..46fd2d5 100644
@@ -350,6 +350,7 @@ void L1P_cache_block_invalidate(unsigned int start, unsigned int end)
 			      (unsigned int *) end,
 			      IMCR_L1PIBAR, IMCR_L1PIWC);
 }
+EXPORT_SYMBOL(L1P_cache_block_invalidate);
 
 void L1D_cache_block_invalidate(unsigned int start, unsigned int end)
 {
@@ -371,6 +372,7 @@ void L1D_cache_block_writeback(unsigned int start, unsigned int end)
 			      (unsigned int *) end,
 			      IMCR_L1DWBAR, IMCR_L1DWWC);
 }
+EXPORT_SYMBOL(L1D_cache_block_writeback);
 
 /*
  *  L2 block operations
author
#3 lore raw
Quoted 12 lines · Mark Salter
Quoted 8 lines · Chen Gang

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

---

Thanks! I added this to the c6x tree for next merge window.

Thank you for your work for all the related patches. And I am analyzing related c6x gcc/binutils issues:

- For binutils/ld issue, I have sent fix patch for it, the patch is OK (really fix the root cause), but need some additional improvement, I shall sent patch v2 for it within this month.

- For gcc issue, I am analyzing, hope I can find root cause today, and send fix patch within this month.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
author
#4 lore raw
Quoted 8 lines · Chen Gang
Quoted 7 lines · Mark Salter
Quoted 6 lines · Chen Gang

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

---

Thanks! I added this to the c6x tree for next merge window.

Sorry, I did not finish the gcc/binutils issues on time.

- For binutils patch, it is fixed by me, it is passed binutils related member's first checking, I guess it can correctly fix the related issue (although may still need improvement). It is in attachment.

- For gcc, it is fixed by c6x gcc related member and it is integrated into gcc main line. (I sent fix patch for it, but my original patch is incorrect).

I guess, I reported issues and sent patches were too late. And next I should report and send fix patches in time (within 20??-??-20), so can leave a little more time to others for reviewing and integrating

Quoted 14 lines

Thank you for your work for all the related patches. And I am analyzing related c6x gcc/binutils issues:

- For binutils/ld issue, I have sent fix patch for it, the patch is OK (really fix the root cause), but need some additional improvement, I shall sent patch v2 for it within this month.

- For gcc issue, I am analyzing, hope I can find root cause today, and send fix patch within this month.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

It will cause multiple definitions for _HEAP_START, _HEAP_MAX, and _STACK_START (e.g. build linux kernel).

2015-03-27 Chen Gang <[email protected]>

* emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for relocating operation.

---
 ld/ChangeLog                    | 5 +++++
 ld/emulparams/elf32_tic6x_le.sh | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
ld/ChangeLog +5 -0
index 3a5edf2..587e2be 100644
@@ -1,3 +1,8 @@
+2015-03-27  Chen Gang  <[email protected]>
+
+	* emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for
+	relocating operation.
+
 2015-03-24  Marcus Shawcroft  <[email protected]>
 
 	* emultempl/aarch64elf.em (_aarch64_add_stub_section): Set section
ld/emulparams/elf32_tic6x_le.sh +7 -2
index dfd64c1..6533c7f 100644
@@ -44,7 +44,11 @@ OTHER_READWRITE_SECTIONS=".fardata ${RELOCATING-0} : { *(.fardata${RELOCATING+ .
 OTHER_READWRITE_RELOC_SECTIONS="
   .rel.fardata     ${RELOCATING-0} : { *(.rel.fardata${RELOCATING+ .rel.fardata.*}) }
   .rela.fardata    ${RELOCATING-0} : { *(.rela.fardata${RELOCATING+ .rela.fardata.*}) }"
-case ${target} in
+# For relocating operation, skip OTHER_BSS_SECTIONS, or will cause multiple definition.
+if [ ${RELOCATING-0} ]; then
+  OTHER_BSS_SECTIONS="";
+else
+  case ${target} in
     *-elf)
 	OTHER_BSS_SECTIONS="
   .heap :
@@ -60,5 +64,6 @@ case ${target} in
     _STACK_START = .;
   }"
 	;;
-esac
+  esac
+fi
 ATTRS_SECTIONS='.c6xabi.attributes 0 : { KEEP (*(.c6xabi.attributes)) KEEP (*(.gnu.attributes)) }'

-- 1.9.3

author
#5 lore raw
In reply to Chen Gang
Quoted 8 lines · Chen Gang
Quoted 7 lines · Mark Salter
Quoted 6 lines · Chen Gang

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

---

Thanks! I added this to the c6x tree for next merge window.

Sorry, I did not finish the gcc/binutils issues on time.

- For binutils patch, it is fixed by me, it is passed binutils related member's first checking, I guess it can correctly fix the related issue (although may still need improvement). It is in attachment.

- For gcc, it is fixed by c6x gcc related member and it is integrated into gcc main line. (I sent fix patch for it, but my original patch is incorrect).

I guess, I reported issues and sent patches were too late. And next I should report and send fix patches in time (within 20??-??-20), so can leave a little more time to others for reviewing and integrating

Quoted 14 lines

Thank you for your work for all the related patches. And I am analyzing related c6x gcc/binutils issues:

- For binutils/ld issue, I have sent fix patch for it, the patch is OK (really fix the root cause), but need some additional improvement, I shall sent patch v2 for it within this month.

- For gcc issue, I am analyzing, hope I can find root cause today, and send fix patch within this month.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

It will cause multiple definitions for _HEAP_START, _HEAP_MAX, and _STACK_START (e.g. build linux kernel).

2015-03-27 Chen Gang <[email protected]>

* emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for relocating operation.

---
 ld/ChangeLog                    | 5 +++++
 ld/emulparams/elf32_tic6x_le.sh | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
ld/ChangeLog +5 -0
index 3a5edf2..587e2be 100644
@@ -1,3 +1,8 @@
+2015-03-27  Chen Gang  <[email protected]>
+
+	* emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for
+	relocating operation.
+
 2015-03-24  Marcus Shawcroft  <[email protected]>
 
 	* emultempl/aarch64elf.em (_aarch64_add_stub_section): Set section
ld/emulparams/elf32_tic6x_le.sh +7 -2
index dfd64c1..6533c7f 100644
@@ -44,7 +44,11 @@ OTHER_READWRITE_SECTIONS=".fardata ${RELOCATING-0} : { *(.fardata${RELOCATING+ .
 OTHER_READWRITE_RELOC_SECTIONS="
   .rel.fardata     ${RELOCATING-0} : { *(.rel.fardata${RELOCATING+ .rel.fardata.*}) }
   .rela.fardata    ${RELOCATING-0} : { *(.rela.fardata${RELOCATING+ .rela.fardata.*}) }"
-case ${target} in
+# For relocating operation, skip OTHER_BSS_SECTIONS, or will cause multiple definition.
+if [ ${RELOCATING-0} ]; then
+  OTHER_BSS_SECTIONS="";
+else
+  case ${target} in
     *-elf)
 	OTHER_BSS_SECTIONS="
   .heap :
@@ -60,5 +64,6 @@ case ${target} in
     _STACK_START = .;
   }"
 	;;
-esac
+  esac
+fi
 ATTRS_SECTIONS='.c6xabi.attributes 0 : { KEEP (*(.c6xabi.attributes)) KEEP (*(.gnu.attributes)) }'

-- 1.9.3

author
#6 lore raw
Quoted 9 lines · Chen Gang
Quoted 8 lines · Chen Gang
Quoted 7 lines · Mark Salter
Quoted 6 lines · Chen Gang

They are needed by other modules, the related error with allmodconfig:

MODPOST 3327 modules
ERROR: "L1P_cache_block_invalidate" [drivers/misc/lkdtm.ko] undefined!
ERROR: "L1D_cache_block_writeback" [drivers/misc/lkdtm.ko] undefined!

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

---

Thanks! I added this to the c6x tree for next merge window.

The related binutils patch is merged into the latest binutils tree. At present, we can use the latest gcc/binutils to cross compile c6x with allmodconfig successfully. :-)

Thanks.

Quoted 30 lines

Sorry, I did not finish the gcc/binutils issues on time.

- For binutils patch, it is fixed by me, it is passed binutils related member's first checking, I guess it can correctly fix the related issue (although may still need improvement). It is in attachment.

- For gcc, it is fixed by c6x gcc related member and it is integrated into gcc main line. (I sent fix patch for it, but my original patch is incorrect).

I guess, I reported issues and sent patches were too late. And next I should report and send fix patches in time (within 20??-??-20), so can leave a little more time to others for reviewing and integrating

Quoted 14 lines

Thank you for your work for all the related patches. And I am analyzing related c6x gcc/binutils issues:

- For binutils/ld issue, I have sent fix patch for it, the patch is OK (really fix the root cause), but need some additional improvement, I shall sent patch v2 for it within this month.

- For gcc issue, I am analyzing, hope I can find root cause today, and send fix patch within this month.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed