MAINTAINERS: Add me on list of Dell laptop drivers
PATCH 1/1 MAINTAINERS: Add me on list of Dell laptop drivers
--- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
@@ -3058,10 +3058,16 @@ F: drivers/net/fddi/defxx.* DELL LAPTOP DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/dell-laptop.c +DELL LAPTOP FREEFALL DRIVER +M: Pali Rohár <[email protected]> +S: Maintained +F: drivers/platform/x86/dell-smo8800.c + DELL LAPTOP SMM DRIVER M: Guenter Roeck <[email protected]> S: Maintained
@@ -3076,6 +3082,7 @@ F: drivers/firmware/dcdbas.* DELL WMI EXTRAS DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> S: Maintained F: drivers/platform/x86/dell-wmi.c
Signature · 1 line
1.7.9.5
On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:
Please include why. No empty commit messages please.
For example, you've written nearly a third of the dell-wmi.c driver, and all the dell-smo8800.c driver.
Dell Laptop is still pending the keyboard backlight patches though I believe (have I missed them?), so you don't currently have code ownership there. I agree you should be on the MAINTAINERS list, but it would be good to get your keyboard backlight changes in first.
Gosh... sure seems like we should have merged that already... am I missing something? The last thing I see in master, testing, and next is the revert from Jan 21....
Also, Matthew, you're the listed maintainer for these, do you agree to adding Pali?
Quoted 38 lines
Signed-off-by Pali Rohár <[email protected]>--- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)MAINTAINERS +7
-0@@ -3058,10 +3058,16 @@ F: drivers/net/fddi/defxx.* DELL LAPTOP DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/dell-laptop.c +DELL LAPTOP FREEFALL DRIVER +M: Pali Rohár <[email protected]> +S: Maintained +F: drivers/platform/x86/dell-smo8800.c + DELL LAPTOP SMM DRIVER M: Guenter Roeck <[email protected]> S: Maintained@@ -3076,6 +3082,7 @@ F: drivers/firmware/dcdbas.* DELL WMI EXTRAS DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> S: Maintained F: drivers/platform/x86/dell-wmi.cSignature · 1 line
1.7.9.5
Signature · 2 lines
Darren Hart Intel Open Source Technology Center
Quoted 7 lines · On Thursday 02 April 2015 07:10:27 Darren Hart wrote:
On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:
Please include why. No empty commit messages please.
For example, you've written nearly a third of the
dell-wmi.cdriver, and all thedell-smo8800.cdriver.
Ok. If you need description include this:
===MAINTAINERS: Add me on list of Dell laptop drivers
I have written more parts of dell laptop drivers dell-laptop.c, dell-wmi.c and dell-smo8800.c
===
Quoted 6 lines
Dell Laptop is still pending the keyboard backlight patches though I believe (have I missed them?), so you don't currently have code ownership there. I agree you should be on the
MAINTAINERSlist, but it would be good to get your keyboard backlight changes in first.
ok.
Quoted 4 lines
Gosh... sure seems like we should have merged that already... am I missing something? The last thing I see in master, testing, and next is the revert from Jan 21....
backlight support was merged for 3.19, but has small problem with ALS settings. And then you decided to revert it for 3.19. After that problem was fixed and last (2015-03-06) you wrote that you queued patch again for 4.1 release.
Quoted 43 lines
Also, Matthew, you're the listed maintainer for these, do you agree to adding Pali?
Quoted 40 lines
Signed-off-by Pali Rohár <[email protected]>---
MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)MAINTAINERS +6
-0@@ -3058,10 +3058,16 @@ F: drivers/net/fddi/defxx.* DELL LAPTOP DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/dell-laptop.c +DELL LAPTOP FREEFALL DRIVER +M: Pali Rohár <[email protected]> +S: Maintained +F: drivers/platform/x86/dell-smo8800.c +DELL LAPTOP SMM DRIVER
M: Guenter Roeck <[email protected]>
S: MaintainedMAINTAINERS +1
-0@@ -3076,6 +3082,7 @@ F: drivers/firmware/dcdbas.* DELL WMI EXTRAS DRIVER M: Matthew Garrett <[email protected]> +M: Pali Rohár <[email protected]> S: MaintainedF:
drivers/platform/x86/dell-wmi.c
Signature · 2 lines
Pali Rohár [email protected]
Quoted 32 lines · Pali Rohár
Quoted 7 lines · On Thursday 02 April 2015 07:10:27 Darren Hart wrote:
On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:
Please include why. No empty commit messages please.
For example, you've written nearly a third of the
dell-wmi.cdriver, and all thedell-smo8800.cdriver.Ok. If you need description include this:
===
MAINTAINERS: Add me on list of Dell laptop driversI have written more parts of dell laptop drivers
dell-laptop.c,dell-wmi.canddell-smo8800.c
===Quoted 6 lines
Dell Laptop is still pending the keyboard backlight patches though I believe (have I missed them?), so you don't currently have code ownership there. I agree you should be on the
MAINTAINERSlist, but it would be good to get your keyboard backlight changes in first.ok.
Quoted 4 lines
Gosh... sure seems like we should have merged that already... am I missing something? The last thing I see in master, testing, and next is the revert from Jan 21....
Quoted 4 lines
backlight support was merged for 3.19, but has small problem with ALS settings. And then you decided to revert it for 3.19. After that problem was fixed and last (2015-03-06) you wrote that you queued patch again for 4.1 release.
Right you are, and I appear to have dropped that ball. Found it, and it's now in my testing branch, and will run through the 0day testing, then into my next tomorrow, still on track for 4.1.
Quoted 3 lines
Quoted 3 lines
Also, Matthew, you're the listed maintainer for these, do you agree to adding Pali?
I'm accepted silence as acceptance :-)
Signature · 2 lines
Darren Hart Intel Open Source Technology Center