Skip to contentSkip to conversation

spi: pxa2xx: missing break in pxa2xx_ssp_get_clk_div()

PATCH Applied Andy Shevchenko 3 participants 3 messages Mar 31, 2015 1 message not in the archive

Subsystems (3)
SPI PXA2xx/PXA3xx support Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH v2 1/1 spi: pxa2xx: missing break in pxa2xx_ssp_get_clk_div()

From: Dan Carpenter <[email protected]>

We refactored this code but accidentally left out a break statement so QUARK_X1000_SSP isn't handled correctly.

Fixes 025ffe88ee60 ('spi: pxa2xx: shift clk_div in one place')
Tested-by Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]>
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/spi/spi-pxa2xx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi-pxa2xx.c +2 -0
index 60526a5..e3223ac 100644
@@ -791,8 +791,10 @@ static unsigned int pxa2xx_ssp_get_clk_div(struct driver_data *drv_data,
 	switch (drv_data->ssp_type) {
 	case QUARK_X1000_SSP:
 		clk_div = quark_x1000_get_clk_div(rate, &chip->dds_rate);
+		break;
 	default:
 		clk_div = ssp_get_clk_div(drv_data, rate);
+		break;
 	}
 	return clk_div << 8;
 }
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1427809778-99984-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]

#2 lore raw
Quoted 8 lines · Andy Shevchenko

From: Dan Carpenter <[email protected]>

We refactored this code but accidentally left out a break statement so QUARK_X1000_SSP isn't handled correctly.

Fixes 025ffe88ee60 ('spi: pxa2xx: shift clk_div in one place')
Tested-by Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]>
Signed-off-by Dan Carpenter <[email protected]>

Thanks for this. Sorry, for the delay I was confused earlier about if I should wait for you to switch it to an if statement but after Mark's comments then planning to resend later. But you have done it for me, thanks!

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html