Skip to contentSkip to conversation

thermal: user_space: add trip point number to uevent data

PATCH New Brian Norris 1 participant 1 message Apr 2, 2015 Thermal

lore
Share & tools
lore

Brian Norris

author
#0 lore raw

PATCH 1/1 thermal: user_space: add trip point number to uevent data

A user-space thermal governor does not currently know which trip point caused a uevent to trigger. Let's add this information to the payload.

This is just an RFC, because this patch (on its own) is not very useful. The only current caller of the .throttle callback is in thermal_zone_device_update(), which loops over *all* trip points. This seems very counter-intuitive and unhelpful, but maybe I'm just clueless.

Signed-off-by Brian Norris <[email protected]>
---
 drivers/thermal/user_space.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/thermal/user_space.c +12 -1
index 10adcddc8821..9fc03d3271d6 100644
@@ -22,6 +22,8 @@
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  */
 
+#include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/thermal.h>
 
 #include "thermal_core.h"

@@ -34,9 +36,18 @@
  */
 static int notify_user_space(struct thermal_zone_device *tz, int trip)
 {
+	char *envp[] = { NULL, NULL };
+
+	envp[0] = kasprintf(GFP_KERNEL, "TRIPNUM=%u", trip);
+	if (!envp[0])
+		return -ENOMEM;
+
 	mutex_lock(&tz->lock);
-	kobject_uevent(&tz->device.kobj, KOBJ_CHANGE);
+	kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, envp);
 	mutex_unlock(&tz->lock);
+
+	kfree(envp[0]);
+
 	return 0;
 }
Signature · 1 line
1.9.1