Skip to contentSkip to conversation

Correct drm display mode table about 1856x1392 @75Hz mode

PATCH In review liu,lei 4 participants 4 messages Apr 2, 2015 – Apr 3, 2015

Subsystems (2)
lore
Share & tools
lore

liu,lei

author
#0 lore raw

PATCH 1/1 Correct drm display mode table about 1856x1392 @75Hz mode

From: "liu,lei" <[email protected]>

According DMT spec, vss of this mode should be 1393, vse should be 1396.

VESA MONITOR TIMING STANDARD:

Timing Name = 1856 x 1392 @ 75Hz
Hor Total Time = 8.889; (usec) = 320 chars = 2560 Pixels Hor Sync Start = 6.889; (usec) = 248 chars = 1984 Pixels H Back Porch = 1.222; (usec) = 44 chars = 352 Pixels

Ver Total Time = 13.333; (msec) = 1500 lines HT – (1.06xHA) Ver Sync Start = 12.382; (msec) = 1393 lines
V Back Porch = 0.924; (msec) = 104 lines

---
 drivers/gpu/drm/drm_edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +1 -1
index 53bc7a6..16991ea 100644
@@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@75Hz */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
-		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
+		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@120Hz RB */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Please prefix the subject with "drm/edid: " and send the patch to [email protected].

In general, scripts/get_maintainer.pl will tell you where to send the patches; intel-gfx is for stuff under drivers/gpu/drm/i915.

Thanks,
Jani.

Quoted 39 lines · liu,lei

From: "liu,lei" <[email protected]>

According DMT spec, vss of this mode should be 1393, vse should be 1396.

VESA MONITOR TIMING STANDARD:

Timing Name = 1856 x 1392 @ 75Hz
Hor Total Time = 8.889; (usec) = 320 chars = 2560 Pixels Hor Sync Start = 6.889; (usec) = 248 chars = 1984 Pixels H Back Porch = 1.222; (usec) = 44 chars = 352 Pixels

Ver Total Time = 13.333; (msec) = 1500 lines HT – (1.06xHA) Ver Sync Start = 12.382; (msec) = 1393 lines
V Back Porch = 0.924; (msec) = 104 lines

---
 drivers/gpu/drm/drm_edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +1 -1
index 53bc7a6..16991ea 100644
@@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@75Hz */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
-		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
+		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@120Hz RB */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
In reply to liu,lei
Quoted 24 lines · liu,lei

From: "liu,lei" <[email protected]>

According DMT spec, vss of this mode should be 1393, vse should be 1396.

VESA MONITOR TIMING STANDARD:

Timing Name = 1856 x 1392 @ 75Hz
Hor Total Time = 8.889; (usec) = 320 chars = 2560 Pixels Hor Sync Start = 6.889; (usec) = 248 chars = 1984 Pixels H Back Porch = 1.222; (usec) = 44 chars = 352 Pixels

Ver Total Time = 13.333; (msec) = 1500 lines HT – (1.06xHA) Ver Sync Start = 12.382; (msec) = 1393 lines
V Back Porch = 0.924; (msec) = 104 lines

---
 drivers/gpu/drm/drm_edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +0 -0
index 53bc7a6..16991ea 100644

drivers/gpu/drm/drm_edid.c static const struct drm_display_mode drm_dmt_modes[] = { · line 412

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1 -1
@@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@75Hz */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
-		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
+		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,

That is indeed what the spec says. However to review this I wrote a quick awk script to parse the spec, and that shows a few more differences. I'll toss out a patch with the results of my script...

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +0 -0
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@120Hz RB */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#3 lore raw
In reply to liu,lei

Task id: 6127 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -1 272/272 271/272

ILK                                  302/302              302/302
SNB                                  303/303              303/303
IVB                                  338/338              338/338
BYT                 -1              287/287              286/287
HSW                                  361/361              361/361
BDW                                  308/308              308/308

-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
PNV igt@gen3_render_tiledx_blits FAIL(6)PASS(6) FAIL(1)PASS(1)
*BYT igt@gem_exec_bad_domains@conflicting-write-domain PASS(17) FAIL(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx