Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

DISCUSSION Chris Mason 7 participants 9 messages Apr 2, 2015 – Apr 23, 2015 Btrfs file system

lore

Share & tools

lore

Chris Mason

author

2015-04-02 14:17 UTC #0 lore raw

Hi stable friends,

Can you please backport this one to 3.19.y. It fixes a bug introduced by:

381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+

The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Please put this commit everywhere you've cherry-picked 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756

commit 9c4f61f01d269815bb7c37be3ede59c5587747c6

Author: David Sterba <[email protected]>
Date:   Fri Jan 2 19:12:57 2015 +0100

btrfs: simplify insert_orphan_item

We can search and add the orphan item in one go, btrfs_insert_orphan_item will find out if the item already exists.

Signed-off-by David Sterba <[email protected]>

-chris

Luis Henriques

2015-04-06 08:58 UTC #1 lore raw

Quoted 4 lines · Chris Mason

Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:

Quoted 9 lines

381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.
Please put this commit everywhere you've cherry-picked 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756

Thank you, I'll queue this fix for the 3.16 kernel.

Cheers,
--
Luís

Quoted 19 lines

commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
Author: David Sterba <[email protected]>
Date:   Fri Jan 2 19:12:57 2015 +0100
btrfs: simplify insert_orphan_item
We can search and add the orphan item in one go, btrfs_insert_orphan_item will find out if the item already exists.
Signed-off-by David Sterba <[email protected]>
-chris
--
To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Roman Mamedov

2015-04-13 14:28 UTC #2 lore raw

In reply to Chris Mason

Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:

Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.

Quoted 23 lines

Please put this commit everywhere you've cherry-picked 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756
commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
Author: David Sterba <[email protected]>
Date:   Fri Jan 2 19:12:57 2015 +0100
btrfs: simplify insert_orphan_item
We can search and add the orphan item in one go, btrfs_insert_orphan_item will find out if the item already exists.
Signed-off-by David Sterba <[email protected]>
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines

With respect,
Roman

Greg KH

2015-04-13 16:58 UTC #3 lore raw

Quoted 11 lines · Roman Mamedov

Quoted 8 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+

Quoted 6 lines

Quoted 3 lines
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.

I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.

greg k-h

Rich Freeman

2015-04-23 18:16 UTC #4 lore raw

Quoted 16 lines · Greg KH

Quoted 15 lines · Roman Mamedov
Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Quoted 5 lines

Quoted 2 lines
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.
I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.

It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

--
Rich

Josh Boyer

2015-04-23 18:24 UTC #5 lore raw

Quoted 17 lines · Rich Freeman

Quoted 16 lines · Greg KH
Quoted 15 lines · Roman Mamedov
Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.
I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.
It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

Sasha is maintaining the 3.18.y stable tree, not Greg. Added to CC.

josh

Sasha Levin

2015-04-23 18:35 UTC #6 lore raw

Quoted 19 lines · Josh Boyer

Quoted 17 lines · Rich Freeman
Quoted 17 lines · Greg KH
Quoted 16 lines
Quoted 16 lines · Roman Mamedov
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Quoted 11 lines
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Quoted 8 lines

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.
I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.
It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.
Sasha is maintaining the 3.18.y stable tree, not Greg. Added to CC.

Um, that commit was shipped back in 3.18.9.

Thanks,
Sasha

Sasha Levin

2015-04-23 18:39 UTC #7 lore raw

Quoted 23 lines · Sasha Levin

Quoted 22 lines · Josh Boyer
Quoted 20 lines · Rich Freeman
Quoted 20 lines · Greg KH
Quoted 19 lines
Quoted 19 lines · Roman Mamedov
Quoted 17 lines
Quoted 17 lines
Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Quoted 11 lines
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.

Quoted 7 lines

Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.
It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.
Sasha is maintaining the 3.18.y stable tree, not Greg. Added to CC.
Um, that commit was shipped back in 3.18.9.

Oh, bleh, I've looked the wrong commit. I've queued 9c4f61f01d269815bb7c37be3ede59c5587747c6 up for 3.18.13.

Thanks!

Greg KH

2015-04-23 18:25 UTC #8 lore raw

In reply to Rich Freeman

Quoted 17 lines · Rich Freeman

Quoted 16 lines · Greg KH
Quoted 15 lines · Roman Mamedov
Quoted 11 lines · On Thu, 2 Apr 2015 10:17:47 -0400 Chris Mason <[email protected]> wrote:
Hi stable friends,
Can you please backport this one to 3.19.y. It fixes a bug introduced by:
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
The symptoms of the bug are deadlocks during log reply after a crash. The patch wasn't intentionally fixing the deadlock, which is why we missed it when tagging fixes.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and 3.18.11 released today.
I have a few hundred stable backports left to sort through, don't worry, this is still in the queue, it's not lost.
It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

I don't manage 3.18-stable anymore, so there's nothing I can do here :)