Skip to contentSkip to conversation

tty: Re-add external interface for tty_set_termios()

PATCH NAK Frederic Danis 2 participants 4 messages Apr 3, 2015 – Apr 10, 2015

Subsystems (2)
Bluetooth drivers TTY layer and serial drivers
lore
Share & tools
lore

Frederic Danis

author
#0 lore raw

PATCH 1/1 tty: Re-add external interface for tty_set_termios()

This is a partial revert of patch "tty: Remove external interface for tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to set tty_set_termios() publicly available.

This will be needed by Bluetooth hci_uart module to be able to change Bluetooth controller and local UART speed during vendor specific initialization.

Signed-off-by Frederic Danis <[email protected]>
---
 drivers/tty/tty_ioctl.c | 3 ++-
 include/linux/tty.h     | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/tty/tty_ioctl.c +2 -1
index 632fc81..8e53fe4 100644
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
  *	Locking: termios_rwsem
  */
 
-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
 {
 	struct ktermios old_termios;
 	struct tty_ldisc *ld;

@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
 	up_write(&tty->termios_rwsem);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(tty_set_termios);
 
 /**
  *	set_termios		-	set termios values for a tty
include/linux/tty.h +1 -0
index 358a337..fe5623c 100644
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
 
 extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
 extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
 
 extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
 extern void tty_ldisc_deref(struct tty_ldisc *);
Signature · 1 line
1.9.1
NAK
#1 lore raw

Hi Frederic,

Quoted 7 lines · Frederic Danis

This is a partial revert of patch "tty: Remove external interface for tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to set tty_set_termios() publicly available.

This will be needed by Bluetooth hci_uart module to be able to change Bluetooth controller and local UART speed during vendor specific initialization.

NAK.

1. Where is this _proposed_ usage?
2. The HCI line discipline has no business changing the line rate.

Regards,
Peter Hurley

#2 lore raw

[ +cc GregKH, JiriS ]

Quoted 7 lines · Peter Hurley

Hi Frederic,

Quoted 4 lines · Frederic Danis

This is a partial revert of patch "tty: Remove external interface for tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to set tty_set_termios() publicly available.

Quoted 7 lines
Quoted 3 lines

This will be needed by Bluetooth hci_uart module to be able to change Bluetooth controller and local UART speed during vendor specific initialization.

NAK.

1. Where is this _proposed_ usage?

Found it. RFC series in linux-bluetooth.

#3 lore raw
In reply to Frederic Danis
Quoted 7 lines · Frederic Danis

This is a partial revert of patch "tty: Remove external interface for tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to set tty_set_termios() publicly available.

This will be needed by Bluetooth hci_uart module to be able to change Bluetooth controller and local UART speed during vendor specific initialization.

Please resend to tty maintainers (and cc me).