Skip to contentSkip to conversation

Bluetooth: cmtp: Use BIT(x) instead of (1 << x)

PATCH In review Marcel Holtmann 2 participants 2 messages Apr 3, 2015 – Apr 4, 2015

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 1/2 Bluetooth: cmtp: Use BIT(x) instead of (1 << x)

Signed-off-by Marcel Holtmann <[email protected]>
---
 net/bluetooth/cmtp/capi.c | 2 +-
 net/bluetooth/cmtp/core.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
net/bluetooth/cmtp/capi.c +1 -1
index 75bd2c42e3e7..b0c6c6af76ef 100644
@@ -333,7 +333,7 @@ void cmtp_recv_capimsg(struct cmtp_session *session, struct sk_buff *skb)
 		return;
 	}
 
-	if (session->flags & (1 << CMTP_LOOPBACK)) {
+	if (session->flags & BIT(CMTP_LOOPBACK)) {
 		kfree_skb(skb);
 		return;
 	}
net/bluetooth/cmtp/core.c +2 -2
index ddbc348c9dff..298ed37010e6 100644
@@ -314,7 +314,7 @@ static int cmtp_session(void *arg)
 
 	down_write(&cmtp_session_sem);
 
-	if (!(session->flags & (1 << CMTP_LOOPBACK)))
+	if (!(session->flags & BIT(CMTP_LOOPBACK)))
 		cmtp_detach_device(session);
 
 	fput(session->sock->file);

@@ -390,7 +390,7 @@ int cmtp_add_connection(struct cmtp_connadd_req *req, struct socket *sock)
 		goto unlink;
 	}
 
-	if (!(session->flags & (1 << CMTP_LOOPBACK))) {
+	if (!(session->flags & BIT(CMTP_LOOPBACK))) {
 		err = cmtp_attach_device(session);
 		if (err < 0) {
 			atomic_inc(&session->terminate);
Signature · 1 line
2.1.0
#1 lore raw

Hi Marcel,

Quoted 5 lines · Marcel Holtmann
Signed-off-by Marcel Holtmann <[email protected]>
---
 net/bluetooth/cmtp/capi.c | 2 +-
 net/bluetooth/cmtp/core.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Both patches have been applied to bluetooth-next. Thanks.

Johan