Skip to contentSkip to conversation

staging: fbtft: 80 characters per line in fb_ili9163.c

PATCH In review Andreas Theodosiou 3 participants 3 messages Apr 4, 2015

Subsystems (3)
Staging Kernel janitors Fbtft Framebuffer drivers
lore
Share & tools
lore

Andreas Theodosiou

author
#0 lore raw

PATCH 1/1 staging: fbtft: 80 characters per line in fb_ili9163.c

This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit.

Signed-off-by Andreas Theodosiou <[email protected]>
---
 drivers/staging/fbtft/fb_ili9163.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_ili9163.c +2 -1
index ed92a64..fc7568b 100644
@@ -89,7 +89,8 @@
 
 /*
 This display:
-http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
+http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
+Color-TFT-LCD-Display-Module-/271422122271
 This particular display has a design error! The controller has 3 pins to
 configure to constrain the memory and resolution to a fixed dimension (in
 that case 128x128) but they leaved those pins configured for 128x160 so
Signature · 1 line
2.3.5
#1 lore raw
Quoted 2 lines · Andreas Theodosiou

This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit.

[]

drivers/staging/fbtft/fb_ili9163.c

Quoted 1 line
drivers/staging/fbtft/fb_ili9163.c +0 -0

[]

drivers/staging/fbtft/fb_ili9163.c line 93

Quoted 7 lines
drivers/staging/fbtft/fb_ili9163.c +2 -1
@@ -89,7 +89,8 @@
 
 /*
 This display:
-http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
+http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
+Color-TFT-LCD-Display-Module-/271422122271

Please don't do this to links.

There are many real defects to fix and other code to improve.

This isn't one of those.

I doubt though that an ebay link is very long lasting.

#2 lore raw
In reply to Andreas Theodosiou
Quoted 13 lines · Andreas Theodosiou

This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit.

Signed-off-by Andreas Theodosiou <[email protected]>
---
 drivers/staging/fbtft/fb_ili9163.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_ili9163.c +0 -0
index ed92a64..fc7568b 100644

drivers/staging/fbtft/fb_ili9163.c line 93

Quoted 6 lines
drivers/staging/fbtft/fb_ili9163.c +2 -1
@@ -89,7 +89,8 @@
 
 /*
 This display:
-http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
+http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
+Color-TFT-LCD-Display-Module-/271422122271

With this change the user won't be able to just simply click on the url and have it open for him. Thus I don't think this is a good change. Sometimes in the kernel people leave lines over 80 characters to make the code more grep-able, sometimes it's just more clear when it's over 80 characters or, probably, in cases like this.

Su pagarba / Regards,
Giedrius