staging: fbtft: fix all print warnings reported by sparse

PATCH Superseded Marcus Folkesson 2 participants 5 messages Apr 7, 2015 – Apr 30, 2015

Subsystems (2)

Staging Fbtft Framebuffer drivers

lore

Share & tools

lore

Marcus Folkesson

author

2015-04-07 19:32 UTC #0 lore raw

PATCH 1/1 staging: fbtft: fix all print warnings reported by sparse

Signed-off-by Marcus Folkesson <[email protected]>

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 drivers/staging/fbtft/fbtft-io.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

drivers/staging/fbtft/fbtft-core.c +1 -1

index 37dcf7e..b82870b 100644
@@ -1000,7 +1000,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 	fbtft_sysfs_init(par);
 
 	if (par->txbuf.buf)
-		sprintf(text1, ", %d KiB %sbuffer memory",
+		sprintf(text1, ", %zu KiB %sbuffer memory",
 			par->txbuf.len >> 10, par->txbuf.dma ? "DMA " : "");
 	if (spi)
 		sprintf(text2, ", spi%d.%d at %d MHz", spi->master->bus_num,

drivers/staging/fbtft/fbtft-io.c +2 -2

index 32155a7..9b2f8cf 100644
@@ -59,7 +59,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
 	}
 	if ((len % 8) != 0) {
 		dev_err(par->info->device,
-			"%s: error: len=%d must be divisible by 8\n",
+			"%s: error: len=%zu must be divisible by 8\n",
 			__func__, len);
 		return -EINVAL;
 	}

@@ -106,7 +106,7 @@ int fbtft_read_spi(struct fbtft_par *par, void *buf, size_t len)
 	if (par->startbyte) {
 		if (len > 32) {
 			dev_err(par->info->device,
-				"%s: len=%d can't be larger than 32 when using 'startbyte'\n",
+				"%s: len=%zu can't be larger than 32 when using 'startbyte'\n",
 				__func__, len);
 			return -EINVAL;
 		}

Signature · 1 line

1.9.1

Greg Kroah-Hartman

maintainer

2015-04-10 13:27 UTC #1 lore raw

Quoted 1 line · Marcus Folkesson

Signed-off-by Marcus Folkesson <[email protected]>

Please include the exact warning that sparse gives you for this, it's not obvious to me what is wrong with the original code.

thanks,

greg k-h

Marcus Folkesson

author

2015-04-10 13:46 UTC #2 lore raw

Changelog: staging: fbtft: fix all print warnings reported by sparse

In reply to Marcus Folkesson

Include sparse-warnings in commit-log according to Gregs comments.

Marcus Folkesson

author

2015-04-10 13:46 UTC #3 lore raw

PATCH v2 1/1 staging: fbtft: fix all print warnings reported by sparse

Warnings reported by sparse:

drivers/staging/fbtft/fbtft-core.c:1004:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]

    par->txbuf.len >> 10, par->txbuf.dma ? "DMA " : "");

drivers/staging/fbtft/fbtft-io.c:63:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]

    __func__, len);

drivers/staging/fbtft/fbtft-io.c:110:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]

     __func__, len);

Signed-off-by Marcus Folkesson <[email protected]>

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 drivers/staging/fbtft/fbtft-io.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

drivers/staging/fbtft/fbtft-core.c +1 -1

index 37dcf7e..b82870b 100644
@@ -1000,7 +1000,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 	fbtft_sysfs_init(par);
 
 	if (par->txbuf.buf)
-		sprintf(text1, ", %d KiB %sbuffer memory",
+		sprintf(text1, ", %zu KiB %sbuffer memory",
 			par->txbuf.len >> 10, par->txbuf.dma ? "DMA " : "");
 	if (spi)
 		sprintf(text2, ", spi%d.%d at %d MHz", spi->master->bus_num,

drivers/staging/fbtft/fbtft-io.c +2 -2

index 32155a7..9b2f8cf 100644
@@ -59,7 +59,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
 	}
 	if ((len % 8) != 0) {
 		dev_err(par->info->device,
-			"%s: error: len=%d must be divisible by 8\n",
+			"%s: error: len=%zu must be divisible by 8\n",
 			__func__, len);
 		return -EINVAL;
 	}

@@ -106,7 +106,7 @@ int fbtft_read_spi(struct fbtft_par *par, void *buf, size_t len)
 	if (par->startbyte) {
 		if (len > 32) {
 			dev_err(par->info->device,
-				"%s: len=%d can't be larger than 32 when using 'startbyte'\n",
+				"%s: len=%zu can't be larger than 32 when using 'startbyte'\n",
 				__func__, len);
 			return -EINVAL;
 		}

Signature · 1 line

1.9.1

Greg Kroah-Hartman

maintainer

2015-04-30 14:46 UTC #4 lore raw

Quoted 12 lines · Marcus Folkesson

Warnings reported by sparse:
drivers/staging/fbtft/fbtft-core.c:1004:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
    par->txbuf.len >> 10, par->txbuf.dma ? "DMA " : "");
drivers/staging/fbtft/fbtft-io.c:63:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
    __func__, len);
drivers/staging/fbtft/fbtft-io.c:110:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]

Quoted 7 lines

     __func__, len);

Signed-off-by Marcus Folkesson <[email protected]>

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 drivers/staging/fbtft/fbtft-io.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Doesn't apply to my tree :(