Skip to contentSkip to conversation

tests/kms_fbc_crc: fix fread() return value assertion

PATCH New Thomas Wood 1 participant 1 message Apr 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_fbc_crc: fix fread() return value assertion

Use 1 as the element size to check the number of bytes returned is greater than 0, rather than checking the number of elements returned.

This fixes a regression from commit 47f6b13 (igt.cocci: check the return values of various functions).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89833

---
 tests/kms_fbc_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_fbc_crc.c +1 -1
index 10e1ca4..ccdec33 100644
@@ -510,7 +510,7 @@ igt_main
 
 		status = igt_debugfs_fopen("i915_fbc_status", "r");
 		igt_require_f(status, "No i915_fbc_status found\n");
-		igt_assert_eq(fread(buf, sizeof(buf), 1, status), sizeof(buf));
+		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
 		fclose(status);
 		buf[sizeof(buf) - 1] = '\0';
 		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx