x86, iommu: Fix header comments regarding standard and _FINISH macros
PATCH 1/1 x86, iommu: Fix header comments regarding standard and _FINISH macros
The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros is incorrect:
"The standard vs the _FINISH differs in that the _FINISH variant will
continue detecting other IOMMUs in the call list..."
It should be "..the *standard* variant will continue detecting..."
Fix that.
--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/iommu_table.h +1 -1
@@ -79,7 +79,7 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will +* The standard vs the _FINISH differs in that the standard variant will * continue detecting other IOMMUs in the call list after the * the detection routine returns a positive number. The _FINISH will * stop the execution chain. Both will still call the 'init' and
Signature · 1 line
1.9.1
Borislav Petkov
AppliedQuoted 18 lines · Aravind Gopalakrishnan
The comment line regarding
IOMMU_INITandIOMMU_INIT_FINISHmacros is incorrect:
"The standard vs the_FINISHdiffers in that the_FINISHvariant will
continue detecting other IOMMUs in the call list..."
It should be "..the *standard* variant will continue detecting..."Fix that.
Signed-off-by Aravind Gopalakrishnan <[email protected]>--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/include/asm/iommu_table.h +0
-0
arch/x86/include/asm/iommu_table.h struct iommu_table_entry { · line 85
Quoted 8 lines
arch/x86/include/asm/iommu_table.h +1
-1@@ -79,7 +79,7 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will +* The standard vs the _FINISH differs in that the standard variant will * continue detecting other IOMMUs in the call list after the * the detection routine returns a positive number. The _FINISH will * stop the execution chain. Both will still call the 'init' and
Applied, thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--Quoted 18 lines · Aravind Gopalakrishnan
The comment line regarding
IOMMU_INITandIOMMU_INIT_FINISHmacros is incorrect:
"The standard vs the_FINISHdiffers in that the_FINISHvariant will
continue detecting other IOMMUs in the call list..."
It should be "..the *standard* variant will continue detecting..."Fix that.
Signed-off-by Aravind Gopalakrishnan <[email protected]>--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/include/asm/iommu_table.h +0
-0
arch/x86/include/asm/iommu_table.h struct iommu_table_entry { · line 85
Quoted 8 lines
arch/x86/include/asm/iommu_table.h +1
-1@@ -79,7 +79,7 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will +* The standard vs the _FINISH differs in that the standard variant will * continue detecting other IOMMUs in the call list after the * the detection routine returns a positive number. The _FINISH will * stop the execution chain. Both will still call the 'init' and
So while we are touching it, how about making it more readable:
*
* The standard vs the _FINISH variants differ in that the
* standard variant will continue detecting other IOMMUs in the
* call list after the detection routine returns a positive number.
* The _FINISH variant will stop the execution chain. Both variants
* will still call the 'init' and ...
*
I also fixed a 'the the' typo.
Thanks,
Ingo
Quoted 9 lines · Ingo Molnar
So while we are touching it, how about making it more readable:
*
* The standard vs the_FINISHvariants differ in that the
* standard variant will continue detecting other IOMMUs in the
* call list after the detection routine returns a positive number.
* The_FINISHvariant will stop the execution chain. Both variants
* will still call the 'init' and ...
*
I went a step further :-)
---
From: Aravind Gopalakrishnan <[email protected]>
Date: Wed, 8 Apr 2015 10:46:57 -0500
Subject: [PATCH] x86/iommu: Fix header comments regarding standard and _FINISH
macros
The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros is incorrect:
"The standard vs the _FINISH differs in that the _FINISH variant will continue detecting other IOMMUs in the call list..."
It should be "..the *standard* variant will continue detecting..."
Fix that. Also, make it readable while at it.
Signed-off-by:
--- arch/x86/include/asm/iommu_table.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/x86/include/asm/iommu_table.h +6 -5
@@ -79,11 +79,12 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will -* continue detecting other IOMMUs in the call list after the -* the detection routine returns a positive number. The _FINISH will -* stop the execution chain. Both will still call the 'init' and -* 'late_init' functions if they are set. +* The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant +* in that the former will continue detecting other IOMMUs in the call +* list after the detection routine returns a positive number, while the +* latter will stop the execution chain upon first successful detection. +* Both variants will still call the 'init' and 'late_init' functions if +* they are set. */ #define IOMMU_INIT_FINISH (_detect, _depend, _init, _late_init) \ __IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
Signature · 8 lines
2.3.3
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--Quoted 53 lines · Borislav Petkov
Quoted 9 lines · Ingo Molnar
So while we are touching it, how about making it more readable:
*
* The standard vs the_FINISHvariants differ in that the
* standard variant will continue detecting other IOMMUs in the
* call list after the detection routine returns a positive number.
* The_FINISHvariant will stop the execution chain. Both variants
* will still call the 'init' and ...
*I went a step further :-)
---
From: Aravind Gopalakrishnan <[email protected]>
Date: Wed, 8 Apr 2015 10:46:57 -0500
Subject: [PATCH] x86/iommu: Fix header comments regarding standard and_FINISH
macrosThe comment line regarding
IOMMU_INITandIOMMU_INIT_FINISHmacros is incorrect:"The standard vs the
_FINISHdiffers in that the_FINISHvariant will continue detecting other IOMMUs in the call list..."It should be "..the *standard* variant will continue detecting..."
Fix that. Also, make it readable while at it.
Signed-off-by Aravind Gopalakrishnan <[email protected]>Fixes 6e9636693373 ("x86, iommu: Update header comments with appropriate naming")Cc Thomas Gleixner <[email protected]>Cc H. Peter Anvin <[email protected]>Cc x86-ml <[email protected]>Signed-off-by:
--- arch/x86/include/asm/iommu_table.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)arch/x86/include/asm/iommu_table.h +0
-4@@ -79,11 +79,12 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will -* continue detecting other IOMMUs in the call list after the -* the detection routine returns a positive number. The _FINISH will -* stop the execution chain. Both will still call the 'init' and
arch/x86/include/asm/iommu_table.h struct iommu_table_entry { · line 90
Quoted 10 lines
arch/x86/include/asm/iommu_table.h +6
-1-* 'late_init' functions if they are set. +* The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant +* in that the former will continue detecting other IOMMUs in the call +* list after the detection routine returns a positive number, while the +* latter will stop the execution chain upon first successful detection. +* Both variants will still call the 'init' and 'late_init' functions if +* they are set. */ #define IOMMU_INIT_FINISH (_detect, _depend, _init, _late_init) \ __IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
Sounds good to me!
Thanks,
Ingo
Quoted 34 lines · Borislav Petkov
Quoted 6 lines · Ingo Molnar
So while we are touching it, how about making it more readable:
*
* The standard vs the_FINISHvariants differ in that the
* standard variant will continue detecting other IOMMUs in the
* call list after the detection routine returns a positivenumber.
Quoted 1 line
* The
_FINISHvariant will stop the execution chain. Bothvariants
Quoted 2 lines
* will still call the 'init' and ...
*I went a step further :-)
---
From: Aravind Gopalakrishnan <[email protected]>
Date: Wed, 8 Apr 2015 10:46:57 -0500
Subject: [PATCH] x86/iommu: Fix header comments regarding standard and_FINISH
macrosThe comment line regarding
IOMMU_INITandIOMMU_INIT_FINISHmacros is incorrect:"The standard vs the
_FINISHdiffers in that the_FINISHvariant will continue detecting other IOMMUs in the call list..."It should be "..the *standard* variant will continue detecting..."
Fix that. Also, make it readable while at it.
Signed-off-by Aravind Gopalakrishnan <[email protected]>Fixes 6e9636693373 ("x86, iommu: Update header comments with
Quoted 8 lines
appropriate naming")
Cc: Thomas Gleixner <[email protected]>
Cc: H. Peter Anvin <[email protected]>
Cc: x86-ml <[email protected]>
Cc: [email protected]
Link:
http://lkml.kernel.org/r/[email protected]
Signed-off-by:
What is with that empty SoB?
Otherwise Reviewed-by: Konrad Rzeszutek Wilk <[email protected]>
Quoted 32 lines
---
arch/x86/include/asm/iommu_table.h| 11 ++++++-----1 file changed, 6 insertions(+), 5 deletions(-)arch/x86/include/asm/iommu_table.h +0
-0@@ -79,11 +79,12 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from
pci_iommu_init
* where we do have a memory allocator.
*
- * The standard vs the_FINISHdiffers in that the_FINISHvariant will
- * continue detecting other IOMMUs in the call list after the
- * the detection routine returns a positive number. The_FINISHwill
- * stop the execution chain. Both will still call the 'init' and
- * 'late_init' functions if they are set.
+ * The standardIOMMU_INITdiffers from theIOMMU_INIT_FINISHvariant
+ * in that the former will continue detecting other IOMMUs in the call
+ * list after the detection routine returns a positive number, while the
+ * latter will stop the execution chain upon first successful detection.
+ * Both variants will still call the 'init' and 'late_init' functions if
+ * they are set.
*/#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init) \ __IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
Quoted 4 lines · Konrad Rzeszutek Wilk
Quoted 2 lines
http://lkml.kernel.org/r/[email protected]
Signed-off-by:What is with that empty SoB?
I'm invisible :-)
Anyway, Ingo applied the correct version.
Signature · 5 lines
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--tip-bot for Aravind Gopalakrishnan
merge bot[tip:x86/cleanups] x86/iommu: Fix header comments regarding standard and _FINISH macros
In reply to Aravind Gopalakrishnanx86/iommu: Fix header comments regarding standard and _FINISH macros
Commit-ID: b44915927ca88084a7292e4ddd4cf91036f365e1 Gitweb: http://git.kernel.org/tip/b44915927ca88084a7292e4ddd4cf91036f365e1 Author: Aravind Gopalakrishnan <[email protected]> AuthorDate: Thu, 9 Apr 2015 10:51:48 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 9 Apr 2015 10:56:31 +0200
x86/iommu: Fix header comments regarding standard and _FINISH macros
The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros is incorrect:
"The standard vs the _FINISH differs in that the _FINISH variant will continue detecting other IOMMUs in the call list..."
It should be "..the *standard* variant will continue detecting..."
Fix that. Also, make it readable while at it.
--- arch/x86/include/asm/iommu_table.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/x86/include/asm/iommu_table.h +6 -5
@@ -79,11 +79,12 @@ struct iommu_table_entry {* d). Similar to the 'init', except that this gets called from pci_iommu_init * where we do have a memory allocator. * -* The standard vs the _FINISH differs in that the _FINISH variant will -* continue detecting other IOMMUs in the call list after the -* the detection routine returns a positive number. The _FINISH will -* stop the execution chain. Both will still call the 'init' and -* 'late_init' functions if they are set. +* The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant +* in that the former will continue detecting other IOMMUs in the call +* list after the detection routine returns a positive number, while the +* latter will stop the execution chain upon first successful detection. +* Both variants will still call the 'init' and 'late_init' functions if +* they are set. */ #define IOMMU_INIT_FINISH (_detect, _depend, _init, _late_init) \ __IOMMU_INIT(_detect, _depend, _init, _late_init, 1)