ixgbe: Release semaphore bits in the right order
Subsystems (2)
PATCH 1/1 ixgbe: Release semaphore bits in the right order
The global semaphore bits should be released in the reverse of the order that they were taken, so correct that.
---
0 files changed
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c +4 -4
@@ -696,14 +696,14 @@ static void ixgbe_release_swfw_sync_semaphore(struct ixgbe_hw *hw)/* Release both semaphores by writing 0 to the bits REGSMP and SMBI */ - swsm =IXGBE_READ_REG (hw,IXGBE_SWSM ); - swsm &= ~IXGBE_SWSM_SMBI ; -IXGBE_WRITE_REG (hw,IXGBE_SWSM , swsm); - swsm =IXGBE_READ_REG (hw,IXGBE_SWFW_SYNC ); swsm &= ~IXGBE_SWFW_REGSMP ;IXGBE_WRITE_REG (hw,IXGBE_SWFW_SYNC , swsm); + swsm =IXGBE_READ_REG (hw,IXGBE_SWSM ); + swsm &= ~IXGBE_SWSM_SMBI ; +IXGBE_WRITE_REG (hw,IXGBE_SWSM , swsm); +IXGBE_WRITE_FLUSH (hw); }
PATCH 1/1 ixgbe: Release semaphore bits in the right order
Quoted 4 lines · Mark D Rustad
The global semaphore bits should be released in the reverse of the order that they were taken, so correct that.
Signed-off-by Mark Rustad <[email protected]>
Thanks Mark, I have applied your patch to my queue.
Signature · 9 lines
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150410/b90ec94f/attachment.asc>
Schmitt
PATCH 1/1 ixgbe: Release semaphore bits in the right order
Quoted 15 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jeff Kirsher
Sent: Friday, April 10, 2015 3:56 PM
To: Rustad, Mark D
Cc: intel-wired-lan at lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Release semaphore bits in the right orderQuoted 3 lines · Mark D Rustad
The global semaphore bits should be released in the reverse of the order that they were taken, so correct that.
Quoted 6 lines
Quoted 1 line
Signed-off-by Mark Rustad <[email protected]>Thanks Mark, I have applied your patch to my queue. --
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue