ALSA: hda - Add dock support for ThinkPad X250
PATCH 1/1 ALSA: hda - Add dock support for ThinkPad X250
Hi,
I recently bought a 2015 ThinkPad (X250) along with a dockstation (ThinkPad Ultra dock). The audio output (mini-jack) doesn't work on the dock station, but after some research it seems that the snd_hda_intel module just miss the correct pin configuration.
This pin configuration seems shared between 2014 and 2015 ThinkPads, so this patch just add the same quirk for the X250 subsystem product id.
After that, the audio output works fine on the internal speakers, on the laptop output jack and on the dockstation output jack.
I didn't add the CC: [email protected] because I'm unsure how the ALSA maintainers stand on this, but similar previous patches have been targeted to stable so it might be worth adding it.
Regards,
Signature · 10 lines
Yves-Alexis Perez Yves-Alexis Perez (1): ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226) sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) -- 2.1.4
PATCH 1/1 ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)
This model uses the same dock port as the previous generation.
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
@@ -5030,6 +5030,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x2212 ,"Thinkpad T440" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x2214 ,"Thinkpad X240" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x2215 ,"Thinkpad" ,ALC269_FIXUP_LIMIT_INT_MIC_BOOST ), +SND_PCI_QUIRK (0x17aa ,0x2226 ,"ThinkPad X250" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3977 ,"IdeaPad S210" ,ALC283_FIXUP_INT_MIC ),SND_PCI_QUIRK (0x17aa ,0x3978 ,"IdeaPad Y410P" ,ALC269_FIXUP_NO_SHUTUP ), SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
Signature · 1 line
2.1.4
Takashi Iwai
AppliedRe: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)
At Sat, 11 Apr 2015 09:31:35 +0200,
Quoted 4 lines · Yves-Alexis Perez
This model uses the same dock port as the previous generation.
Signed-off-by Yves-Alexis Perez <[email protected]>
Thanks, applied with Cc to stable.
But, at the next time, please put maintainers to Cc.
Takashi
Quoted 25 lines
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +1
-0@@ -5030,6 +5030,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x2212 ,"Thinkpad T440" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x2214 ,"Thinkpad X240" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x2215 ,"Thinkpad" ,ALC269_FIXUP_LIMIT_INT_MIC_BOOST ), +SND_PCI_QUIRK (0x17aa ,0x2226 ,"ThinkPad X250" ,ALC292_FIXUP_TPT440_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3977 ,"IdeaPad S210" ,ALC283_FIXUP_INT_MIC ),SND_PCI_QUIRK (0x17aa ,0x3978 ,"IdeaPad Y410P" ,ALC269_FIXUP_NO_SHUTUP ), SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),Signature · 7 lines
2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)
Quoted 9 lines · Takashi Iwai
At Sat, 11 Apr 2015 09:31:35 +0200,
Quoted 4 lines · Yves-Alexis Perez
This model uses the same dock port as the previous generation.
Signed-off-by Yves-Alexis Perez <[email protected]>Thanks, applied with Cc to stable.
But, at the next time, please put maintainers to Cc.
Thanks, and sorry for that, will pay attention next time.
Regards,
Signature · 1 line
Yves-Alexis
Re: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)
In reply to Takashi IwaiQuoted 9 lines · Takashi Iwai
At Sat, 11 Apr 2015 09:31:35 +0200,
Quoted 4 lines · Yves-Alexis Perez
This model uses the same dock port as the previous generation.
Signed-off-by Yves-Alexis Perez <[email protected]>Thanks, applied with Cc to stable.
But, at the next time, please put maintainers to Cc.
Hi Greg,
I noticed a similar patch (f2aa1110 for the ThinkPad T450) was correctly included in 3.19.5 (as 3b941649), but this one (c0278669) was not.
Is there something I'm missing?
Regards,
Signature · 1 line
Yves-Alexis
Re: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)
Quoted 11 lines · Yves-Alexis Perez
Quoted 9 lines · Takashi Iwai
At Sat, 11 Apr 2015 09:31:35 +0200,
Quoted 4 lines · Yves-Alexis Perez
This model uses the same dock port as the previous generation.
Signed-off-by Yves-Alexis Perez <[email protected]>Thanks, applied with Cc to stable.
But, at the next time, please put maintainers to Cc.
Quoted 6 lines
Hi Greg,
I noticed a similar patch (
f2aa1110for the ThinkPad T450) was correctly included in 3.19.5 (as3b941649), but this one (c0278669) was not.Is there something I'm missing?
It was not in a released kernel from Linus yet. It now showed up in 4.1-rc1, so it can go into a stable tree.
greg k-h