Skip to contentSkip to conversation

spi: bcm2835: Add GPIOLIB dependency

PATCH Applied Guenter Roeck 3 participants 4 messages Apr 14, 2015 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: bcm2835: Add GPIOLIB dependency

Fix:

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
dereferencing pointer to incomplete type
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:2: error:
` implicit declaration of function 'gpiochip_find'
drivers/spi/spi-bcm2835.c:387:21: error:
dereferencing pointer to incomplete type

by adding the now mandatory GPIOLIB dependency.

Fixes a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs

on first spi_setup")

---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
index 198f96b7fb45..a132180a9251 100644
@@ -78,6 +78,7 @@ config SPI_ATMEL
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
 	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on GPIOLIB
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.
 
Signature · 6 lines
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 5 lines · Guenter Roeck

by adding the now mandatory GPIOLIB dependency.

Note this shows up during automated randconfig testing.

Quoted 4 lines
Fixes a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs

on first spi_setup")

I have had an identical patch in the pipeline as well, but I was still testing it over the night.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 7 lines · Martin Sperl
Quoted 5 lines · Guenter Roeck

by adding the now mandatory GPIOLIB dependency.

Note this shows up during automated randconfig testing.

Also for m68k:allmodconfig and mips:allmodconfig in both mainline and -next.

http://server.roeck-us.net:8010/builders/hwmon-m68k-master/builds/129
http://server.roeck-us.net:8010/builders/hwmon-mips-master/builds/129

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer Applied
#3 lore raw
In reply to Guenter Roeck
Quoted 5 lines · Guenter Roeck

Fix:

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
dereferencing pointer to incomplete type

Applied, thanks.