Skip to contentSkip to conversation

Input: set INPUT_PROP_POINTING_STICK in hid-lenovo

PATCH In review Andreas Fleig 2 participants 3 messages Apr 14, 2015 – Apr 23, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 Input: set INPUT_PROP_POINTING_STICK in hid-lenovo

Set flags INPUT_PROP_POINTER and INPUT_PROP_POINTING_STICK for the trackpoint integrated in Lenovo USB and Bluetooth keyboards. Libinput checks these flags to enable features such as middle-button-scrolling by default.

drivers/hid/hid-lenovo.c +0 -0
index c4c3f09..59f21a0 100644
@@ -762,6 +762,23 @@ static void lenovo_remove(struct hid_device *hdev)
	hid_hw_stop(hdev);
}

+static void lenovo_input_configured(struct hid_device *hdev,
+ struct hid_input *hi)
+{
+ switch (hdev->product) {
+ case USB_DEVICE_ID_LENOVO_TPKBD:
+ case USB_DEVICE_ID_LENOVO_CUSBKBD:
+ case USB_DEVICE_ID_LENOVO_CBTKBD:
+ if (test_bit(EV_REL, hi->input->evbit)) {
+ /* set only for trackpoint device */
+ __set_bit(INPUT_PROP_POINTER, hi->input->propbit);
+ __set_bit(INPUT_PROP_POINTING_STICK,
+ hi->input->propbit);
+ }
+ break;
+ }
+}
+
static const struct hid_device_id lenovo_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) }, { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_CUSBKBD)
},
@@ -774,6 +791,7 @@ MODULE_DEVICE_TABLE(hid, lenovo_devices);

static struct hid_driver lenovo_driver = {
	.name = "lenovo",
	.id_table = lenovo_devices,

+ .input_configured = lenovo_input_configured,
.input_mapping = lenovo_input_mapping,
.probe = lenovo_probe,
.remove = lenovo_remove,

#1 lore raw
Quoted 7 lines · Andreas Fleig

Set flags INPUT_PROP_POINTER and INPUT_PROP_POINTING_STICK for the trackpoint integrated in Lenovo USB and Bluetooth keyboards. Libinput checks these flags to enable features such as middle-button-scrolling by default.

Andreas,

your patch has been severely damaged by your mail client. I have fixed everything by hand for now and applied the patch to for-4.2/lenovo branch, but please fix your workflow for your future submissions.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw
Quoted 3 lines · Jiri Kosina

your patch has been severely damaged by your mail client. I have fixed everything by hand for now and applied the patch to for-4.2/lenovo branch, but please fix your workflow for your future submissions.

Thanks, I didn't notice the rewrapped lines. I should fix geary now ;-)

Andreas