Skip to contentSkip to conversation

sched/debug: Reduce SEQ_printf footprint

PATCH In review Joe Perches 1 participant 2 messages Apr 17, 2015 Scheduler

lore
Share & tools
lore

Joe Perches

author
#0 lore raw

PATCH 1/1 sched/debug: Reduce SEQ_printf footprint

This macro can be converted to a static inline to reduce object size.

(x86-64 defconfig, with SCHED_DEBUG)

$ size kernel/sched/debug.o*
   text	   data	    bss	    dec	    hex	filename
  13885	      8	   4098	  17991	   4647	kernel/sched/debug.o.new
  20413	      8	   4098	  24519	   5fc7	kernel/sched/debug.o.old
Signed-off-by Joe Perches <[email protected]>
---
 kernel/sched/debug.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
kernel/sched/debug.c +14 -7
index a245c1f..c7932cc 100644
@@ -25,13 +25,20 @@ static DEFINE_SPINLOCK(sched_debug_lock);
  * This allows printing both to /proc/sched_debug and
  * to the console
  */
-#define SEQ_printf(m, x...)			\
- do {						\
-	if (m)					\
-		seq_printf(m, x);		\
-	else					\
-		printk(x);			\
- } while (0)
+__printf(2, 3)
+static void SEQ_printf(struct seq_file *m, const char *fmt, ...)
+{
+	va_list args;
+
+	va_start(args, fmt);
+
+	if (m)
+		seq_vprintf(m, fmt, args);
+	else
+		vprintk(fmt, args);
+
+	va_end(args);
+}
 
 /*
  * Ease the printing of nsec fields:
author
#1 lore raw
Quoted 2 lines · Joe Perches

This macro can be converted to a static inline to reduce object size.

bah, that should be "static function".