drm/i915: Don't read dpcd for disconnected ports
Subsystems (2)
PATCH 1/1 drm/i915: Don't read dpcd for disconnected ports
Reading from disconnected ports will spit out timeout error on the dmesg. Skip the attempted read if the port is not connected and avoid confusing users/testcases about expected timeouts.
This new dpcd debugfs entry was introduced by commit aa7471d228eb ("drm/i915: add i915 specific connector debugfs file for DPCD")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +3 -0
@@ -4938,6 +4938,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data) connector->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +if (connector->status != connector_status_connected) +continue ; +/* low tech for now */ if (WARN_ON (size >sizeof (buf)))continue ;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6243 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276 ILK 302/302 302/302 SNB 318/318 318/318 IVB 341/341 341/341 BYT 287/287 287/287 BDW 318/318 318/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · Mika Kuoppala
Reading from disconnected ports will spit out timeout error on the dmesg. Skip the attempted read if the port is not connected and avoid confusing users/testcases about expected timeouts.
This new dpcd debugfs entry was introduced by commit
aa7471d228eb("drm/i915: add i915 specific connector debugfs file for DPCD")Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
Tested-by [email protected]Cc Jani Nikula <[email protected]>Cc Bob Paauwe <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +0
-0
drivers/gpu/drm/i915/i915_debugfs.c static int i915_dpcd_show(struct seq_file *m, void *data) · line 4942
Quoted 5 lines
drivers/gpu/drm/i915/i915_debugfs.c +2
-0@@ -4938,6 +4938,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data) connector->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +if (connector->status != connector_status_connected) +continue ;
The loop isn't iterating over connectors, so this check should be at the top of the function.
BR,
Jani.
Quoted 11 lines
drivers/gpu/drm/i915/i915_debugfs.c +1
-0+/* low tech for now */ if (WARN_ON (size >sizeof (buf)))continue ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: Don't read dpcd for disconnected ports
From: Mika Kuoppala <[email protected]>
Reading from disconnected ports will spit out timeout error on the dmesg. Skip the attempted read if the port is not connected and avoid confusing users/testcases about expected timeouts.
This new dpcd debugfs entry was introduced by commit aa7471d228eb ("drm/i915: add i915 specific connector debugfs file for DPCD")
v2 by Jani: move the check at the top, out of the loop.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +3 -0
@@ -5154,6 +5154,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data)ssize_t err;int i; +if (connector->status != connector_status_connected) +return -ENODEV ; +for (i =0 ; i <ARRAY_SIZE (i915_dpcd_debug); i++) {const struct dpcd_block *b = &i915_dpcd_debug[i];size_t size = b->end ? b->end - b->offset +1 : (b->size ?:1 );
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6416 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276 ILK 302/302 302/302 SNB -1 314/314 313/314 IVB 338/338 338/338 BYT 286/286 286/286 BDW 320/320 320/320
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
SNB igt@pm_rpm@dpms-mode-unset-non-lpsp DMESG_WARN(15)PASS(1) DMESG_WARN(1)
(dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#assert_device_not_suspended[i915]()@WARNING:.* at .* assert_device_not_suspended+0x
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 10 lines · Jani Nikula
From: Mika Kuoppala <[email protected]>
Reading from disconnected ports will spit out timeout error on the dmesg. Skip the attempted read if the port is not connected and avoid confusing users/testcases about expected timeouts.
This new dpcd debugfs entry was introduced by commit
aa7471d228eb("drm/i915: add i915 specific connector debugfs file for DPCD")
Quoted 8 lines
v2 by Jani: move the check at the top, out of the loop.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
Tested-by [email protected]Cc Jani Nikula <[email protected]>Cc Bob Paauwe <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 25 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +3
-0@@ -5154,6 +5154,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data)ssize_t err;int i; +if (connector->status != connector_status_connected) +return -ENODEV ; +for (i =0 ; i <ARRAY_SIZE (i915_dpcd_debug); i++) {const struct dpcd_block *b = &i915_dpcd_debug[i];size_t size = b->end ? b->end - b->offset +1 : (b->size ?:1 );Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx