Skip to contentSkip to conversation

pl2303: Remove antiquated support for I330 phone

PATCH In review Jason A. Donenfeld 4 participants 17 messages Apr 21, 2015 – Apr 29, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pl2303: Remove antiquated support for I330 phone

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver for the Samsung I330 phone cradle. This phone was manufactured in 2001, and I seriously doubt it is still in use on any contemporary networks. Having pl2303 pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD. In this patch I remove the device ID of the old antiquated telephone from the pl2303 driver, so that usb-storage can handle it.

---
 drivers/usb/serial/pl2303.c | 1 -
 drivers/usb/serial/pl2303.h | 4 ----
 2 files changed, 5 deletions(-)
drivers/usb/serial/pl2303.c +0 -1
index 829604d..f5257af 100644
@@ -61,7 +61,6 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
 	{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1),
 		.driver_info = PL2303_QUIRK_UART_STATE_IDX0 },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65),
drivers/usb/serial/pl2303.h +0 -4
index 71fd9da..e3b7af8 100644
@@ -62,10 +62,6 @@
 #define ALCATEL_VENDOR_ID	0x11f7
 #define ALCATEL_PRODUCT_ID	0x02df
 
-/* Samsung I330 phone cradle */
-#define SAMSUNG_VENDOR_ID	0x04e8
-#define SAMSUNG_PRODUCT_ID	0x8001
-
 #define SIEMENS_VENDOR_ID	0x11f5
 #define SIEMENS_PRODUCT_ID_SX1	0x0001
 #define SIEMENS_PRODUCT_ID_X65	0x0003
Signature · 1 line
2.3.5
#1 lore raw
Quoted 21 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver for the Samsung I330 phone cradle. This phone was manufactured in 2001, and I seriously doubt it is still in use on any contemporary networks. Having pl2303 pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD. In this patch I remove the device ID of the old antiquated telephone from the pl2303 driver, so that usb-storage can handle it.

---
 drivers/usb/serial/pl2303.c | 1 -
 drivers/usb/serial/pl2303.h | 4 ----
 2 files changed, 5 deletions(-)
drivers/usb/serial/pl2303.c +0 -0
index 829604d..f5257af 100644

drivers/usb/serial/pl2303.c static const struct usb_device_id id_table[] = { · line 64

Quoted 4 lines
drivers/usb/serial/pl2303.c +0 -1
@@ -61,7 +61,6 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
 	{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },

How about adding a .driver_info quirk, that checks the device to see if it matches a mass storage device? If so, don't accept the probe, which will keep the driver from working on the SSD device, and still keep working on the old docking station.

thanks,

greg k-h

#2 lore raw

PATCH 1/1 pl2303, visor: Match I330 phone more precisely

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside pl2303 and visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

---
 drivers/usb/serial/pl2303.c | 2 +-
 drivers/usb/serial/pl2303.h | 1 +
 drivers/usb/serial/visor.c  | 2 +-
 drivers/usb/serial/visor.h  | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)
drivers/usb/serial/pl2303.c +1 -1
index 829604d..45e0c5a 100644
@@ -61,7 +61,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
 	{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
+	{ USB_DEVICE_INTERFACE_CLASS(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID, SAMSUNG_IF_CLASS) },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1),
 		.driver_info = PL2303_QUIRK_UART_STATE_IDX0 },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65),
drivers/usb/serial/pl2303.h +1 -0
index 71fd9da..9c29fe8 100644
@@ -65,6 +65,7 @@
 /* Samsung I330 phone cradle */
 #define SAMSUNG_VENDOR_ID	0x04e8
 #define SAMSUNG_PRODUCT_ID	0x8001
+#define SAMSUNG_IF_CLASS	0xff
 
 #define SIEMENS_VENDOR_ID	0x11f5
 #define SIEMENS_PRODUCT_ID_SX1	0x0001
drivers/usb/serial/visor.c +1 -1
index bf2bd40..4e439ef 100644
@@ -95,7 +95,7 @@ static const struct usb_device_id id_table[] = {
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(ACER_VENDOR_ID, ACER_S10_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SCH_I330_ID),
+	{ USB_DEVICE_INTERFACE_CLASS(SAMSUNG_VENDOR_ID, SAMSUNG_SCH_I330_ID, SAMSUNG_SCH_I330_IFCLASS),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SPH_I500_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
drivers/usb/serial/visor.h +1 -0
index 4c456dd..ffe93a2 100644
@@ -54,6 +54,7 @@
 
 #define SAMSUNG_VENDOR_ID		0x04E8
 #define SAMSUNG_SCH_I330_ID		0x8001
+#define SAMSUNG_SCH_I330_IFCLASS	0xFF
 #define SAMSUNG_SPH_I500_ID		0x6601
 
 #define TAPWAVE_VENDOR_ID		0x12EF
Signature · 1 line
2.3.5
#3 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

Hello.

Quoted 17 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside pl2303 and visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

[...]

drivers/usb/serial/pl2303.h line 68

Quoted 9 lines
drivers/usb/serial/pl2303.h +1 -0
index 71fd9da..9c29fe8 100644
@@ -65,6 +65,7 @@
  /* Samsung I330 phone cradle */
  #define SAMSUNG_VENDOR_ID	0x04e8
  #define SAMSUNG_PRODUCT_ID	0x8001
+#define SAMSUNG_IF_CLASS	0xff

No need for this #define, especially here. 0xff just means vendor-specific
AFAIK.

Quoted 3 lines
drivers/usb/serial/pl2303.h +0 -0
  #define SIEMENS_VENDOR_ID	0x11f5
  #define SIEMENS_PRODUCT_ID_SX1	0x0001

[...]

drivers/usb/serial/visor.h line 57

Quoted 9 lines
drivers/usb/serial/visor.h +1 -0
index 4c456dd..ffe93a2 100644
@@ -54,6 +54,7 @@
 
  #define SAMSUNG_VENDOR_ID		0x04E8
  #define SAMSUNG_SCH_I330_ID		0x8001
+#define SAMSUNG_SCH_I330_IFCLASS	0xFF

No need for this #define, especially here. 0xff just means vendor-specific
AFAIK.

drivers/usb/serial/visor.h line 60

Quoted 3 lines
drivers/usb/serial/visor.h +0 -0
  #define SAMSUNG_SPH_I500_ID		0x6601
 
  #define TAPWAVE_VENDOR_ID		0x12EF

WBR, Sergei

maintainer
#4 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

In reply to Jason A. Donenfeld
Quoted 6 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

First of all, the device should not be claimed by both pl2303 and visor. This predates the git, but it looks like the device id should simply be removed from pl2303. Care to do that as a preparatory patch?

Quoted 8 lines

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside pl2303 and visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

That seems like the way to go. As Sergei already suggested you can use the interface class 0xff directly in the USB_DEVICE_INTERFACE_CLASS macro.

Thanks,
Johan

#5 lore raw

PATCH 1/2 pl2303: Remove support for Samsung I330

This phone is already supported by the visor driver.

---
 drivers/usb/serial/pl2303.c | 1 -
 drivers/usb/serial/pl2303.h | 4 ----
 2 files changed, 5 deletions(-)
drivers/usb/serial/pl2303.c +0 -1
index 829604d..f5257af 100644
@@ -61,7 +61,6 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
 	{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1),
 		.driver_info = PL2303_QUIRK_UART_STATE_IDX0 },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65),
drivers/usb/serial/pl2303.h +0 -4
index 71fd9da..e3b7af8 100644
@@ -62,10 +62,6 @@
 #define ALCATEL_VENDOR_ID	0x11f7
 #define ALCATEL_PRODUCT_ID	0x02df
 
-/* Samsung I330 phone cradle */
-#define SAMSUNG_VENDOR_ID	0x04e8
-#define SAMSUNG_PRODUCT_ID	0x8001
-
 #define SIEMENS_VENDOR_ID	0x11f5
 #define SIEMENS_PRODUCT_ID_SX1	0x0001
 #define SIEMENS_PRODUCT_ID_X65	0x0003
Signature · 1 line
2.3.5
#6 lore raw

PATCH 2/2 visor: Match I330 phone more precisely

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

---
 drivers/usb/serial/visor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/visor.c +1 -1
index bf2bd40..60afb39 100644
@@ -95,7 +95,7 @@ static const struct usb_device_id id_table[] = {
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(ACER_VENDOR_ID, ACER_S10_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SCH_I330_ID),
+	{ USB_DEVICE_INTERFACE_CLASS(SAMSUNG_VENDOR_ID, SAMSUNG_SCH_I330_ID, 0xff),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SPH_I500_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
Signature · 1 line
2.3.5
maintainer
#7 lore raw

Re: [PATCH 2/2] visor: Match I330 phone more precisely

Quoted 14 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside visor.

Quoted 3 lines

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

Both patches look good, but next time remember to include a patch revision in the subject of all patches in a series (this would be [PATCH v3]). Please use a "USB: " prefix as well.

I'll fix it up before applying this time.

Thanks,
Johan

maintainer
#8 lore raw

Re: [PATCH 2/2] visor: Match I330 phone more precisely

Quoted 17 lines · Johan Hovold
Quoted 16 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

Quoted 7 lines
Quoted 1 line

Both patches look good, but next time remember to include a patch revision in the subject of all patches in a series (this would be [PATCH v3]). Please use a "USB: " prefix as well.

I'll fix it up before applying this time.

Both patches now applied with stable tags.

Thanks,
Johan

#9 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

In reply to Johan Hovold
Quoted 11 lines · Johan Hovold
Quoted 6 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

First of all, the device should not be claimed by both pl2303 and visor. This predates the git, but it looks like the device id should simply be removed from pl2303. Care to do that as a preparatory patch?

It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky asked me to add it, and sent a patch as he had the device.

But before that, back in 2003 Adam emailed saying that the visor driver worked with the device, and sent me a patch for it. I didn't notice the duplicate ids for well over a decade now :(

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

Petr, do you still have this device? Is it still really a pl2303 device?

thanks,

greg k-h

#10 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

Quoted 4 lines · Greg Kroah-Hartman

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

In the latest patch set I sent a minute ago, I removed the pl2303 entry, not the visor one. I guess I should resubmit with this the other way around?

#11 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

Quoted 10 lines · Jason A. Donenfeld
Quoted 4 lines · Greg Kroah-Hartman

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

In the latest patch set I sent a minute ago, I removed the pl2303 entry, not the visor one. I guess I should resubmit with this the other way around?

Johan is the maintainer of this subsystem now, I'll defer to him as to what he wants to accept :)

thanks,

greg k-h

#12 lore raw

PATCH 1/2 visor: Remove support for Samsung I330

In reply to Greg Kroah-Hartman

This phone is actually a pl2303 device, and is already supported there.

---
 drivers/usb/serial/visor.c | 2 --
 drivers/usb/serial/visor.h | 1 -
 2 files changed, 3 deletions(-)
drivers/usb/serial/visor.c +0 -2
index bf2bd40..2fe4afb 100644
@@ -95,8 +95,6 @@ static const struct usb_device_id id_table[] = {
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(ACER_VENDOR_ID, ACER_S10_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SCH_I330_ID),
-		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_SPH_I500_ID),
 		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
 	{ USB_DEVICE(TAPWAVE_VENDOR_ID, TAPWAVE_ZODIAC_ID),
drivers/usb/serial/visor.h +0 -1
index 4c456dd..3a2c25f 100644
@@ -53,7 +53,6 @@
 #define ACER_S10_ID			0x0001
 
 #define SAMSUNG_VENDOR_ID		0x04E8
-#define SAMSUNG_SCH_I330_ID		0x8001
 #define SAMSUNG_SPH_I500_ID		0x6601
 
 #define TAPWAVE_VENDOR_ID		0x12EF
Signature · 1 line
2.3.5
#13 lore raw

PATCH 2/2 pl2303: Match I330 phone more precisely

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. Its USB ID is 04e8:8001, which unfortunately is already used by the pl2303 driver for the Samsung I330 phone cradle. Having pl2303 pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

To work around this conflict, I've dug up a mailing list post [1] from a long time ago, in which a user posts the full USB descriptor information. The most specific value in this appears to be the interface class, which has value 255 (0xff). Since usb-storage requires an interface class of 0x8, I believe it's correct to disambiguate the two devices by matching on 0xff inside pl2303.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

---
 drivers/usb/serial/pl2303.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/pl2303.c +1 -1
index 829604d..8bb929a 100644
@@ -61,7 +61,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
 	{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
-	{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
+	{ USB_DEVICE_INTERFACE_CLASS(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID, 0xff) },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1),
 		.driver_info = PL2303_QUIRK_UART_STATE_IDX0 },
 	{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65),
Signature · 1 line
2.3.5
maintainer
#14 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

In reply to Greg Kroah-Hartman
Quoted 16 lines · Greg Kroah-Hartman
Quoted 11 lines · Johan Hovold
Quoted 6 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

First of all, the device should not be claimed by both pl2303 and visor. This predates the git, but it looks like the device id should simply be removed from pl2303. Care to do that as a preparatory patch?

It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky asked me to add it, and sent a patch as he had the device.

Quoted 8 lines

But before that, back in 2003 Adam emailed saying that the visor driver worked with the device, and sent me a patch for it. I didn't notice the duplicate ids for well over a decade now :(

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

My thinking was the other way around; that a dumb, generic device (visor) would never work with a more specialised driver (pl2303).

The opposite could work though as the pl2303 setup commands would simply fail, but the bulk in/out layout appears to be the same and should work with a dumb device.

I double checked just now with a pl2303 HX device, and I can't seem to get anything through with the default settings (visor or generic driver) in loopback.

Note that there's another Samsung SPH-I500 Palm OS phone handled by visor as well.

Quoted 2 lines

Petr, do you still have this device? Is it still really a pl2303 device?

Let's see if we get some feedback first. But unless someone thinks my reasoning above is flawed we could try removing it from pl2303 a little later either way.

Thanks,
Johan

#15 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

Quoted 29 lines · Johan Hovold
Quoted 16 lines · Greg Kroah-Hartman
Quoted 11 lines · Johan Hovold
Quoted 6 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

First of all, the device should not be claimed by both pl2303 and visor. This predates the git, but it looks like the device id should simply be removed from pl2303. Care to do that as a preparatory patch?

It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky asked me to add it, and sent a patch as he had the device.

Quoted 8 lines

But before that, back in 2003 Adam emailed saying that the visor driver worked with the device, and sent me a patch for it. I didn't notice the duplicate ids for well over a decade now :(

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

My thinking was the other way around; that a dumb, generic device (visor) would never work with a more specialised driver (pl2303).

Quoted 7 lines

The opposite could work though as the pl2303 setup commands would simply fail, but the bulk in/out layout appears to be the same and should work with a dumb device.

I double checked just now with a pl2303 HX device, and I can't seem to get anything through with the default settings (visor or generic driver) in loopback.

Ok, fair enough, I wonder how Petr got it to work. Given that there were reports of it working just fine for the visor driver a full year before Petr's patch, odds are he forgot to build that driver into his kernel.

thanks,

greg k-h

maintainer
#16 lore raw

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

Quoted 34 lines · Greg Kroah-Hartman
Quoted 33 lines · Johan Hovold
Quoted 16 lines · Greg Kroah-Hartman
Quoted 11 lines · Johan Hovold
Quoted 6 lines · Jason A. Donenfeld

Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the usb-storage driver, which handles the newly released portable USB3 SSD.

First of all, the device should not be claimed by both pl2303 and visor. This predates the git, but it looks like the device id should simply be removed from pl2303. Care to do that as a preparatory patch?

It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky asked me to add it, and sent a patch as he had the device.

Quoted 8 lines

But before that, back in 2003 Adam emailed saying that the visor driver worked with the device, and sent me a patch for it. I didn't notice the duplicate ids for well over a decade now :(

I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed.

My thinking was the other way around; that a dumb, generic device (visor) would never work with a more specialised driver (pl2303).

The opposite could work though as the pl2303 setup commands would simply fail, but the bulk in/out layout appears to be the same and should work with a dumb device.

Quoted 8 lines
Quoted 3 lines

I double checked just now with a pl2303 HX device, and I can't seem to get anything through with the default settings (visor or generic driver) in loopback.

Ok, fair enough, I wonder how Petr got it to work. Given that there were reports of it working just fine for the visor driver a full year before Petr's patch, odds are he forgot to build that driver into his kernel.

Sounds like a plausible explanation.

Johan