mfd: arizona: Remove redundant register sync
Subsystems (2)
PATCH RESEND 1/1 mfd: arizona: Remove redundant register sync
This soft reset used to be located after the register patch had been applied, but has since moved to before the patch is applied. At the new location there is no requirement to do a register sync as no register writes will have happened yet.
Signed-off-by Charles Keepax <[email protected]>
--- drivers/mfd/arizona-core.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
drivers/mfd/arizona-core.c +0 -8
@@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)/* If we have a /RESET GPIO we'll already be reset */ if (!arizona->pdata.reset) { -regcache_mark_dirty (arizona->regmap); - ret =regmap_write (arizona->regmap,ARIZONA_SOFTWARE_RESET ,0 );if (ret !=0 ) {dev_err (dev,"Failed to reset device: %d\n" , ret);
@@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona) }msleep (1 ); - - ret =regcache_sync (arizona->regmap); -if (ret !=0 ) { -dev_err (dev,"Failed to sync device: %d\n" , ret); - goto err_reset; - } }/* Ensure device startup is complete */
Signature · 1 line
1.7.2.5
Lee Jones
AppliedQuoted 9 lines · Charles Keepax
This soft reset used to be located after the register patch had been applied, but has since moved to before the patch is applied. At the new location there is no requirement to do a register sync as no register writes will have happened yet.
Signed-off-by Charles Keepax <[email protected]>--- drivers/mfd/arizona-core.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
Applied, thanks.
Quoted 26 lines
drivers/mfd/arizona-core.c +0
-8@@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)/* If we have a /RESET GPIO we'll already be reset */ if (!arizona->pdata.reset) { -regcache_mark_dirty (arizona->regmap); - ret =regmap_write (arizona->regmap,ARIZONA_SOFTWARE_RESET ,0 );if (ret !=0 ) {dev_err (dev,"Failed to reset device: %d\n" , ret);@@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona) }msleep (1 ); - - ret =regcache_sync (arizona->regmap); -if (ret !=0 ) { -dev_err (dev,"Failed to sync device: %d\n" , ret); - goto err_reset; - } }/* Ensure device startup is complete */
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog