Skip to contentSkip to conversation

adfs:Remove unneeded kmem_cache_alloc() return value cast

PATCH In review Firo Yang 2 participants 2 messages Apr 23, 2015 Kernel janitors

lore
Share & tools
lore

Firo Yang

author
#0 lore raw

PATCH 8/15 adfs:Remove unneeded kmem_cache_alloc() return value cast

kmem_cache_alloc() returns a void pointer - no need to cast it in fs/adfs/super.c::adfs_alloc_inode()

---
 fs/adfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/adfs/super.c +1 -1
index a19c31d..4d4a0df 100644
@@ -242,7 +242,7 @@ static struct kmem_cache *adfs_inode_cachep;
 static struct inode *adfs_alloc_inode(struct super_block *sb)
 {
 	struct adfs_inode_info *ei;
-	ei = (struct adfs_inode_info *)kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;
Signature · 1 line
2.1.0
#1 lore raw

Sorry to be picky, but normally people put a space after the colon. Also, the subject line could be shorter: Remove unneeded cast. The description part of the subject doesn't have to be unique, just the whole thing, asfter the [PATCH] part.

julia

Quoted 29 lines · Firo Yang

kmem_cache_alloc() returns a void pointer - no need to cast it in fs/adfs/super.c::adfs_alloc_inode()

---
 fs/adfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/adfs/super.c +1 -2
index a19c31d..4d4a0df 100644
@@ -242,7 +242,7 @@ static struct kmem_cache *adfs_inode_cachep;
 static struct inode *adfs_alloc_inode(struct super_block *sb)
 {
 	struct adfs_inode_info *ei;
-	ei = (struct adfs_inode_info *)kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;
--

2.1.0

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html